Re: [PATCH 16/33] mmc: sdhci-xenon: use match_string() helper

[Ulf Hansson]

On 21 May 2018 at 13:57, Yisheng Xie  wrote:
> match_string() returns the index of an array for a matching string,
> which can be used intead of open coded variant.
>
> Cc: Adrian Hunter 
> Cc: Hu Ziji 
> Cc: Ulf Hansson 
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Yisheng Xie 

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/sdhci-xenon-phy.c | 11 +++
>  1 file changed, 3 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-xenon-phy.c 
> b/drivers/mmc/host/sdhci-xenon-phy.c
> index ec87943..a35804b 100644
> --- a/drivers/mmc/host/sdhci-xenon-phy.c
> +++ b/drivers/mmc/host/sdhci-xenon-phy.c
> @@ -814,15 +814,10 @@ static int xenon_add_phy(struct device_node *np, struct 
> sdhci_host *host,
>  {
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> struct xenon_priv *priv = sdhci_pltfm_priv(pltfm_host);
> -   int i, ret;
> +   int ret;
>
> -   for (i = 0; i < NR_PHY_TYPES; i++) {
> -   if (!strcmp(phy_name, phy_types[i])) {
> -   priv->phy_type = i;
> -   break;
> -   }
> -   }
> -   if (i == NR_PHY_TYPES) {
> +   priv->phy_type = match_string(phy_types, NR_PHY_TYPES, phy_name);
> +   if (priv->phy_type < 0) {
> dev_err(mmc_dev(host->mmc),
> "Unable to determine PHY name %s. Use default eMMC 
> 5.1 PHY\n",
> phy_name);
> --
> 1.7.12.4
>

Re: [PATCH 16/33] mmc: sdhci-xenon: use match_string() helper

[Adrian Hunter]

On 21/05/18 14:57, Yisheng Xie wrote:
> match_string() returns the index of an array for a matching string,
> which can be used intead of open coded variant.
> 
> Cc: Adrian Hunter 
> Cc: Hu Ziji 
> Cc: Ulf Hansson 
> Cc: linux-...@vger.kernel.org
> Signed-off-by: Yisheng Xie 

Acked-by: Adrian Hunter 

> ---
>  drivers/mmc/host/sdhci-xenon-phy.c | 11 +++
>  1 file changed, 3 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-xenon-phy.c 
> b/drivers/mmc/host/sdhci-xenon-phy.c
> index ec87943..a35804b 100644
> --- a/drivers/mmc/host/sdhci-xenon-phy.c
> +++ b/drivers/mmc/host/sdhci-xenon-phy.c
> @@ -814,15 +814,10 @@ static int xenon_add_phy(struct device_node *np, struct 
> sdhci_host *host,
>  {
>   struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>   struct xenon_priv *priv = sdhci_pltfm_priv(pltfm_host);
> - int i, ret;
> + int ret;
>  
> - for (i = 0; i < NR_PHY_TYPES; i++) {
> - if (!strcmp(phy_name, phy_types[i])) {
> - priv->phy_type = i;
> - break;
> - }
> - }
> - if (i == NR_PHY_TYPES) {
> + priv->phy_type = match_string(phy_types, NR_PHY_TYPES, phy_name);
> + if (priv->phy_type < 0) {
>   dev_err(mmc_dev(host->mmc),
>   "Unable to determine PHY name %s. Use default eMMC 5.1 
> PHY\n",
>   phy_name);
> 

[PATCH 16/33] mmc: sdhci-xenon: use match_string() helper

[Yisheng Xie]

match_string() returns the index of an array for a matching string,
which can be used intead of open coded variant.

Cc: Adrian Hunter 
Cc: Hu Ziji 
Cc: Ulf Hansson 
Cc: linux-...@vger.kernel.org
Signed-off-by: Yisheng Xie 
---
 drivers/mmc/host/sdhci-xenon-phy.c | 11 +++
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/drivers/mmc/host/sdhci-xenon-phy.c 
b/drivers/mmc/host/sdhci-xenon-phy.c
index ec87943..a35804b 100644
--- a/drivers/mmc/host/sdhci-xenon-phy.c
+++ b/drivers/mmc/host/sdhci-xenon-phy.c
@@ -814,15 +814,10 @@ static int xenon_add_phy(struct device_node *np, struct 
sdhci_host *host,
 {
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
struct xenon_priv *priv = sdhci_pltfm_priv(pltfm_host);
-   int i, ret;
+   int ret;
 
-   for (i = 0; i < NR_PHY_TYPES; i++) {
-   if (!strcmp(phy_name, phy_types[i])) {
-   priv->phy_type = i;
-   break;
-   }
-   }
-   if (i == NR_PHY_TYPES) {
+   priv->phy_type = match_string(phy_types, NR_PHY_TYPES, phy_name);
+   if (priv->phy_type < 0) {
dev_err(mmc_dev(host->mmc),
"Unable to determine PHY name %s. Use default eMMC 5.1 
PHY\n",
phy_name);
-- 
1.7.12.4