Re: [PATCH 17/33] pinctrl: armada-37xx: use match_string() helper

[Andy Shevchenko]

On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie  wrote:
> match_string() returns the index of an array for a matching string,
> which can be used intead of open coded variant.

https://patchwork.kernel.org/patch/10378781/

> Cc: Jason Cooper 
> Cc: Andrew Lunn 
> Cc: Gregory Clement 
> Cc: Sebastian Hesselbarth 
> Cc: Linus Walleij 
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-g...@vger.kernel.org

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 17/33] pinctrl: armada-37xx: use match_string() helper

[Andy Shevchenko]

On Mon, May 21, 2018 at 2:57 PM, Yisheng Xie  wrote:
> match_string() returns the index of an array for a matching string,
> which can be used intead of open coded variant.

https://patchwork.kernel.org/patch/10378781/

> Cc: Jason Cooper 
> Cc: Andrew Lunn 
> Cc: Gregory Clement 
> Cc: Sebastian Hesselbarth 
> Cc: Linus Walleij 
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-g...@vger.kernel.org

-- 
With Best Regards,
Andy Shevchenko

[PATCH 17/33] pinctrl: armada-37xx: use match_string() helper

[Yisheng Xie]

match_string() returns the index of an array for a matching string,
which can be used intead of open coded variant.

Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Gregory Clement 
Cc: Sebastian Hesselbarth 
Cc: Linus Walleij 
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-g...@vger.kernel.org
Signed-off-by: Yisheng Xie 
---
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 16 ++--
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c 
b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 5b63248..e338327 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -214,18 +214,6 @@ static inline void armada_37xx_update_reg(unsigned int 
*reg,
}
 }
 
-static int armada_37xx_get_func_reg(struct armada_37xx_pin_group *grp,
-   const char *func)
-{
-   int f;
-
-   for (f = 0; (f < NB_FUNCS) && grp->funcs[f]; f++)
-   if (!strcmp(grp->funcs[f], func))
-   return f;
-
-   return -ENOTSUPP;
-}
-
 static struct armada_37xx_pin_group *armada_37xx_find_next_grp_by_pin(
struct armada_37xx_pinctrl *info, int pin, int *grp)
 {
@@ -344,10 +332,10 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev 
*pctldev,
dev_dbg(info->dev, "enable function %s group %s\n",
name, grp->name);
 
-   func = armada_37xx_get_func_reg(grp, name);
+   func = match_string(grp->funcs, NB_FUNCS, name);
 
if (func < 0)
-   return func;
+   return -ENOTSUPP;
 
val = grp->val[func];
 
-- 
1.7.12.4

[PATCH 17/33] pinctrl: armada-37xx: use match_string() helper

[Yisheng Xie]

match_string() returns the index of an array for a matching string,
which can be used intead of open coded variant.

Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Gregory Clement 
Cc: Sebastian Hesselbarth 
Cc: Linus Walleij 
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-g...@vger.kernel.org
Signed-off-by: Yisheng Xie 
---
 drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 16 ++--
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c 
b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
index 5b63248..e338327 100644
--- a/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
+++ b/drivers/pinctrl/mvebu/pinctrl-armada-37xx.c
@@ -214,18 +214,6 @@ static inline void armada_37xx_update_reg(unsigned int 
*reg,
}
 }
 
-static int armada_37xx_get_func_reg(struct armada_37xx_pin_group *grp,
-   const char *func)
-{
-   int f;
-
-   for (f = 0; (f < NB_FUNCS) && grp->funcs[f]; f++)
-   if (!strcmp(grp->funcs[f], func))
-   return f;
-
-   return -ENOTSUPP;
-}
-
 static struct armada_37xx_pin_group *armada_37xx_find_next_grp_by_pin(
struct armada_37xx_pinctrl *info, int pin, int *grp)
 {
@@ -344,10 +332,10 @@ static int armada_37xx_pmx_set_by_name(struct pinctrl_dev 
*pctldev,
dev_dbg(info->dev, "enable function %s group %s\n",
name, grp->name);
 
-   func = armada_37xx_get_func_reg(grp, name);
+   func = match_string(grp->funcs, NB_FUNCS, name);
 
if (func < 0)
-   return func;
+   return -ENOTSUPP;
 
val = grp->val[func];
 
-- 
1.7.12.4