Re: [alsa-devel] [PATCH 2/2] ASoC: simple_card_utils.h: Fix potential multiple redefinition error

2019-10-14 Thread Kuninori Morimoto


Hi

> asoc_simple_debug_info and asoc_simple_debug_dai must be static
> otherwise we might a compilation error if the compiler decides
> not to inline the given function.
> 
> Fixes: 0580dde59438686d ("ASoC: simple-card-utils: add 
> asoc_simple_debug_info()")
> Signed-off-by: Daniel Baluta 
> ---

Acked-by: Kuninori Morimoto 

Thank you for your help !!
Best regards
---
Kuninori Morimoto


[PATCH 2/2] ASoC: simple_card_utils.h: Fix potential multiple redefinition error

2019-10-09 Thread Daniel Baluta
asoc_simple_debug_info and asoc_simple_debug_dai must be static
otherwise we might a compilation error if the compiler decides
not to inline the given function.

Fixes: 0580dde59438686d ("ASoC: simple-card-utils: add 
asoc_simple_debug_info()")
Signed-off-by: Daniel Baluta 
---
 include/sound/simple_card_utils.h | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/sound/simple_card_utils.h 
b/include/sound/simple_card_utils.h
index 293ff8115960..bbdd1542d6f1 100644
--- a/include/sound/simple_card_utils.h
+++ b/include/sound/simple_card_utils.h
@@ -136,9 +136,9 @@ int asoc_simple_init_priv(struct asoc_simple_priv *priv,
   struct link_info *li);
 
 #ifdef DEBUG
-inline void asoc_simple_debug_dai(struct asoc_simple_priv *priv,
- char *name,
- struct asoc_simple_dai *dai)
+static inline void asoc_simple_debug_dai(struct asoc_simple_priv *priv,
+char *name,
+struct asoc_simple_dai *dai)
 {
struct device *dev = simple_priv_to_dev(priv);
 
@@ -168,7 +168,7 @@ inline void asoc_simple_debug_dai(struct asoc_simple_priv 
*priv,
dev_dbg(dev, "%s clk %luHz\n", name, clk_get_rate(dai->clk));
 }
 
-inline void asoc_simple_debug_info(struct asoc_simple_priv *priv)
+static inline void asoc_simple_debug_info(struct asoc_simple_priv *priv)
 {
struct snd_soc_card *card = simple_priv_to_card(priv);
struct device *dev = simple_priv_to_dev(priv);
-- 
2.17.1