Re: [PATCH 2/2] Input: evbug - Use 'pr_debug()' instead of hand-writing it

[Joe Perches]

On Thu, 2021-04-15 at 22:58 +0200, Christophe JAILLET wrote:
> 'printk(KERN_DEBUG pr_fmt(...))' can be replaced by a much less verbose
> 'pr_debug()'.

This is not really true because
printk(KERN_DEBUG ...);
will _always_ be emitted if the console level allows
pr_debug(...);
will _only_ be emitted if the console level allows _and_
DEBUG is defined or dynamic_debug is enabled
(and for dynamic_debug, only if specifically enabled)
DEBUG is defined and dynamic_debug is enabled

> diff --git a/drivers/input/evbug.c b/drivers/input/evbug.c
[]
> @@ -21,8 +21,8 @@ MODULE_LICENSE("GPL");
>  
> 
>  static void evbug_event(struct input_handle *handle, unsigned int type, 
> unsigned int code, int value)
>  {
> - printk(KERN_DEBUG pr_fmt("Event. Dev: %s, Type: %d, Code: %d, Value: 
> %d\n"),
> -dev_name(&handle->dev->dev), type, code, value);
> + pr_debug("Event. Dev: %s, Type: %d, Code: %d, Value: %d\n",
> +  dev_name(&handle->dev->dev), type, code, value);
>  }

[PATCH 2/2] Input: evbug - Use 'pr_debug()' instead of hand-writing it

[Christophe JAILLET]

'printk(KERN_DEBUG pr_fmt(...))' can be replaced by a much less verbose
'pr_debug()'.

Signed-off-by: Christophe JAILLET 
---
 drivers/input/evbug.c | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/input/evbug.c b/drivers/input/evbug.c
index e47bdf92088a..88ad88300181 100644
--- a/drivers/input/evbug.c
+++ b/drivers/input/evbug.c
@@ -21,8 +21,8 @@ MODULE_LICENSE("GPL");
 
 static void evbug_event(struct input_handle *handle, unsigned int type, 
unsigned int code, int value)
 {
-   printk(KERN_DEBUG pr_fmt("Event. Dev: %s, Type: %d, Code: %d, Value: 
%d\n"),
-  dev_name(&handle->dev->dev), type, code, value);
+   pr_debug("Event. Dev: %s, Type: %d, Code: %d, Value: %d\n",
+dev_name(&handle->dev->dev), type, code, value);
 }
 
 static int evbug_connect(struct input_handler *handler, struct input_dev *dev,
@@ -47,10 +47,10 @@ static int evbug_connect(struct input_handler *handler, 
struct input_dev *dev,
if (error)
goto err_unregister_handle;
 
-   printk(KERN_DEBUG pr_fmt("Connected device: %s (%s at %s)\n"),
-  dev_name(&dev->dev),
-  dev->name ?: "unknown",
-  dev->phys ?: "unknown");
+   pr_debug("Connected device: %s (%s at %s)\n",
+dev_name(&dev->dev),
+dev->name ?: "unknown",
+dev->phys ?: "unknown");
 
return 0;
 
@@ -63,8 +63,8 @@ static int evbug_connect(struct input_handler *handler, 
struct input_dev *dev,
 
 static void evbug_disconnect(struct input_handle *handle)
 {
-   printk(KERN_DEBUG pr_fmt("Disconnected device: %s\n"),
-  dev_name(&handle->dev->dev));
+   pr_debug("Disconnected device: %s\n",
+dev_name(&handle->dev->dev));
 
input_close_device(handle);
input_unregister_handle(handle);
-- 
2.27.0