Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

[Gregory CLEMENT]

Hi Ben,
 
 On mar., juin 21 2016, Arnd Bergmann  wrote:

> On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote:
>> 
>> -struct syscore_ops mvebu_mbus_syscore_ops = {
>> +static struct syscore_ops mvebu_mbus_syscore_ops = {
>> .suspend= mvebu_mbus_suspend,
>> .resume = mvebu_mbus_resume,
>>  };
>> 
>
>
> Looks good, but I immediately thought it should be "const" as well.
> Unfortunately there is a list_head in them, so that isn't easy,
> but if anyone has an idea for how to make these all const, that
> would be nice.
>
> Anyway, that shouldn't stop your patch from getting merged, so
>
> Acked-by: Arnd Bergmann 
>
> (also for patch 1/2).

So I applied both patch in mvebu/cleanup

Thanks,

Gregory

>
>   Arnd

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

[Gregory CLEMENT]

Hi Ben,
 
 On mar., juin 21 2016, Arnd Bergmann  wrote:

> On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote:
>> 
>> -struct syscore_ops mvebu_mbus_syscore_ops = {
>> +static struct syscore_ops mvebu_mbus_syscore_ops = {
>> .suspend= mvebu_mbus_suspend,
>> .resume = mvebu_mbus_resume,
>>  };
>> 
>
>
> Looks good, but I immediately thought it should be "const" as well.
> Unfortunately there is a list_head in them, so that isn't easy,
> but if anyone has an idea for how to make these all const, that
> would be nice.
>
> Anyway, that shouldn't stop your patch from getting merged, so
>
> Acked-by: Arnd Bergmann 
>
> (also for patch 1/2).

So I applied both patch in mvebu/cleanup

Thanks,

Gregory

>
>   Arnd

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

[Ben Dooks]

Make mvebu_mbus_syscore_ops static as it does not get
used or declared outside mvebu-mbus.c to fix the following
sparse warning:

linux/drivers/bus/mvebu-mbus.c:1092:20: warning: symbol 
'mvebu_mbus_syscore_ops' was not declared. Should it be static?

Signed-off-by: Ben Dooks 
---
Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Gregory CLEMENT 
Cc: Evan Wang 
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
---
 drivers/bus/mvebu-mbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 8cac3b8..c7f3969 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -1089,7 +1089,7 @@ static void mvebu_mbus_resume(void)
}
 }
 
-struct syscore_ops mvebu_mbus_syscore_ops = {
+static struct syscore_ops mvebu_mbus_syscore_ops = {
.suspend= mvebu_mbus_suspend,
.resume = mvebu_mbus_resume,
 };
-- 
2.8.1

[PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

[Ben Dooks]

Make mvebu_mbus_syscore_ops static as it does not get
used or declared outside mvebu-mbus.c to fix the following
sparse warning:

linux/drivers/bus/mvebu-mbus.c:1092:20: warning: symbol 
'mvebu_mbus_syscore_ops' was not declared. Should it be static?

Signed-off-by: Ben Dooks 
---
Cc: Jason Cooper 
Cc: Andrew Lunn 
Cc: Gregory CLEMENT 
Cc: Evan Wang 
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-ker...@lists.infradead.org
---
 drivers/bus/mvebu-mbus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c
index 8cac3b8..c7f3969 100644
--- a/drivers/bus/mvebu-mbus.c
+++ b/drivers/bus/mvebu-mbus.c
@@ -1089,7 +1089,7 @@ static void mvebu_mbus_resume(void)
}
 }
 
-struct syscore_ops mvebu_mbus_syscore_ops = {
+static struct syscore_ops mvebu_mbus_syscore_ops = {
.suspend= mvebu_mbus_suspend,
.resume = mvebu_mbus_resume,
 };
-- 
2.8.1

Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

[Arnd Bergmann]

On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote:
> 
> -struct syscore_ops mvebu_mbus_syscore_ops = {
> +static struct syscore_ops mvebu_mbus_syscore_ops = {
> .suspend= mvebu_mbus_suspend,
> .resume = mvebu_mbus_resume,
>  };
> 


Looks good, but I immediately thought it should be "const" as well.
Unfortunately there is a list_head in them, so that isn't easy,
but if anyone has an idea for how to make these all const, that
would be nice.

Anyway, that shouldn't stop your patch from getting merged, so

Acked-by: Arnd Bergmann 

(also for patch 1/2).

Arnd

Re: [PATCH 2/2] bus: mvebu-mbus: make mvebu_mbus_syscore_ops static

[Arnd Bergmann]

On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote:
> 
> -struct syscore_ops mvebu_mbus_syscore_ops = {
> +static struct syscore_ops mvebu_mbus_syscore_ops = {
> .suspend= mvebu_mbus_suspend,
> .resume = mvebu_mbus_resume,
>  };
> 


Looks good, but I immediately thought it should be "const" as well.
Unfortunately there is a list_head in them, so that isn't easy,
but if anyone has an idea for how to make these all const, that
would be nice.

Anyway, that shouldn't stop your patch from getting merged, so

Acked-by: Arnd Bergmann 

(also for patch 1/2).

Arnd