Re: [PATCH 2/2] drivers: android: binder: fixed a brace coding style issue

2018-03-12 Thread Dan Carpenter
On Sat, Mar 10, 2018 at 01:16:58PM +0530, Vaibhav Murkute wrote:
> Fixed a coding style issue.
> 

This commit log is not the greatest.  Say something like "The curly
braces aren't needed and checkpatch.pl complains so I removed them."

Where is [PATCH 1/2]?

regards,
dan carpenter



Re: [PATCH 2/2] drivers: android: binder: fixed a brace coding style issue

2018-03-12 Thread Dan Carpenter
On Sat, Mar 10, 2018 at 01:16:58PM +0530, Vaibhav Murkute wrote:
> Fixed a coding style issue.
> 

This commit log is not the greatest.  Say something like "The curly
braces aren't needed and checkpatch.pl complains so I removed them."

Where is [PATCH 1/2]?

regards,
dan carpenter



[PATCH 2/2] drivers: android: binder: fixed a brace coding style issue

2018-03-09 Thread Vaibhav Murkute
Fixed a coding style issue.

Signed-off-by: Vaibhav Murkute 
---
 drivers/android/binder.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 764b63a5aade..2729bb75ca19 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2641,11 +2641,11 @@ static bool binder_proc_transaction(struct 
binder_transaction *t,
binder_node_lock(node);
if (oneway) {
BUG_ON(thread);
-   if (node->has_async_transaction) {
+   if (node->has_async_transaction)
pending_async = true;
-   } else {
+   else
node->has_async_transaction = true;
-   }
+
}
 
binder_inner_proc_lock(proc);
-- 
2.15.1



[PATCH 2/2] drivers: android: binder: fixed a brace coding style issue

2018-03-09 Thread Vaibhav Murkute
Fixed a coding style issue.

Signed-off-by: Vaibhav Murkute 
---
 drivers/android/binder.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/android/binder.c b/drivers/android/binder.c
index 764b63a5aade..2729bb75ca19 100644
--- a/drivers/android/binder.c
+++ b/drivers/android/binder.c
@@ -2641,11 +2641,11 @@ static bool binder_proc_transaction(struct 
binder_transaction *t,
binder_node_lock(node);
if (oneway) {
BUG_ON(thread);
-   if (node->has_async_transaction) {
+   if (node->has_async_transaction)
pending_async = true;
-   } else {
+   else
node->has_async_transaction = true;
-   }
+
}
 
binder_inner_proc_lock(proc);
-- 
2.15.1