Re: [PATCH 2/2] drm/exynos: hdmi: Simplify with dev_err_probe()

2020-08-26 Thread Andrzej Hajda


On 26.08.2020 16:55, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski 
Reviewed-by: Andrzej Hajda 

Regards
Andrzej


[PATCH 2/2] drm/exynos: hdmi: Simplify with dev_err_probe()

2020-08-26 Thread Krzysztof Kozlowski
Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski 
---
 drivers/gpu/drm/exynos/exynos_hdmi.c | 7 ++-
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c 
b/drivers/gpu/drm/exynos/exynos_hdmi.c
index c5ba32fca5f3..dc01c188c0e0 100644
--- a/drivers/gpu/drm/exynos/exynos_hdmi.c
+++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
@@ -1797,11 +1797,8 @@ static int hdmi_resources_init(struct hdmi_context 
*hdata)
hdata->regul_bulk[i].supply = supply[i];
 
ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(supply), 
hdata->regul_bulk);
-   if (ret) {
-   if (ret != -EPROBE_DEFER)
-   DRM_DEV_ERROR(dev, "failed to get regulators\n");
-   return ret;
-   }
+   if (ret)
+   return dev_err_probe(dev, ret, "failed to get regulators\n");
 
hdata->reg_hdmi_en = devm_regulator_get_optional(dev, "hdmi-en");
 
-- 
2.17.1