subject:"\[PATCH 2\/2\] extcon\: max8997\: Fix return value"

Re: [PATCH 2/2] extcon: max8997: Fix return value

2013-03-27 Thread Chanwoo Choi

On 03/27/2013 08:23 PM, Sachin Kamat wrote:
> Return the value obtained from the function instead of hardcoding.
> drivers/extcon/extcon-max8997.c:235 max8997_muic_set_path() info:
> why not propagate 'ret' from max8997_update_reg() instead of (-11)?
> drivers/extcon/extcon-max8997.c:248 max8997_muic_set_path() info:
> why not propagate 'ret' from max8997_update_reg() instead of (-11)?
>
> Signed-off-by: Sachin Kamat 
> ---
>  drivers/extcon/extcon-max8997.c |4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
> index 69641bc..05b76b3 100644
> --- a/drivers/extcon/extcon-max8997.c
> +++ b/drivers/extcon/extcon-max8997.c
> @@ -232,7 +232,7 @@ static int max8997_muic_set_path(struct max8997_muic_info 
> *info,
>   MAX8997_MUIC_REG_CONTROL1, ctrl1, COMP_SW_MASK);
>   if (ret < 0) {
>   dev_err(info->dev, "failed to update MUIC register\n");
> - return -EAGAIN;
> + return ret;
>   }
>  
>   if (attached)
> @@ -245,7 +245,7 @@ static int max8997_muic_set_path(struct max8997_muic_info 
> *info,
>   CONTROL2_LOWPWR_MASK | CONTROL2_CPEN_MASK);
>   if (ret < 0) {
>   dev_err(info->dev, "failed to update MUIC register\n");
> - return -EAGAIN;
> + return ret;
>   }
>  
>   dev_info(info->dev,
OK, I agree with your opinion. So, can you fix all of these return type
on extcon-max8997.c? I'd like to receive one patch related
to modification for fixing return type.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] extcon: max8997: Fix return value

2013-03-27 Thread Sachin Kamat

Return the value obtained from the function instead of hardcoding.
drivers/extcon/extcon-max8997.c:235 max8997_muic_set_path() info:
why not propagate 'ret' from max8997_update_reg() instead of (-11)?
drivers/extcon/extcon-max8997.c:248 max8997_muic_set_path() info:
why not propagate 'ret' from max8997_update_reg() instead of (-11)?

Signed-off-by: Sachin Kamat 
---
 drivers/extcon/extcon-max8997.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 69641bc..05b76b3 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -232,7 +232,7 @@ static int max8997_muic_set_path(struct max8997_muic_info 
*info,
MAX8997_MUIC_REG_CONTROL1, ctrl1, COMP_SW_MASK);
if (ret < 0) {
dev_err(info->dev, "failed to update MUIC register\n");
-   return -EAGAIN;
+   return ret;
}
 
if (attached)
@@ -245,7 +245,7 @@ static int max8997_muic_set_path(struct max8997_muic_info 
*info,
CONTROL2_LOWPWR_MASK | CONTROL2_CPEN_MASK);
if (ret < 0) {
dev_err(info->dev, "failed to update MUIC register\n");
-   return -EAGAIN;
+   return ret;
}
 
dev_info(info->dev,
-- 
1.7.4.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] extcon: max8997: Fix return value

2013-03-27 Thread Sachin Kamat

Return the value obtained from the function instead of hardcoding.
drivers/extcon/extcon-max8997.c:235 max8997_muic_set_path() info:
why not propagate 'ret' from max8997_update_reg() instead of (-11)?
drivers/extcon/extcon-max8997.c:248 max8997_muic_set_path() info:
why not propagate 'ret' from max8997_update_reg() instead of (-11)?

Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
---
 drivers/extcon/extcon-max8997.c |4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
index 69641bc..05b76b3 100644
--- a/drivers/extcon/extcon-max8997.c
+++ b/drivers/extcon/extcon-max8997.c
@@ -232,7 +232,7 @@ static int max8997_muic_set_path(struct max8997_muic_info 
*info,
MAX8997_MUIC_REG_CONTROL1, ctrl1, COMP_SW_MASK);
if (ret  0) {
dev_err(info-dev, failed to update MUIC register\n);
-   return -EAGAIN;
+   return ret;
}
 
if (attached)
@@ -245,7 +245,7 @@ static int max8997_muic_set_path(struct max8997_muic_info 
*info,
CONTROL2_LOWPWR_MASK | CONTROL2_CPEN_MASK);
if (ret  0) {
dev_err(info-dev, failed to update MUIC register\n);
-   return -EAGAIN;
+   return ret;
}
 
dev_info(info-dev,
-- 
1.7.4.1

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] extcon: max8997: Fix return value

2013-03-27 Thread Chanwoo Choi

On 03/27/2013 08:23 PM, Sachin Kamat wrote:
 Return the value obtained from the function instead of hardcoding.
 drivers/extcon/extcon-max8997.c:235 max8997_muic_set_path() info:
 why not propagate 'ret' from max8997_update_reg() instead of (-11)?
 drivers/extcon/extcon-max8997.c:248 max8997_muic_set_path() info:
 why not propagate 'ret' from max8997_update_reg() instead of (-11)?

 Signed-off-by: Sachin Kamat sachin.ka...@linaro.org
 ---
  drivers/extcon/extcon-max8997.c |4 ++--
  1 files changed, 2 insertions(+), 2 deletions(-)

 diff --git a/drivers/extcon/extcon-max8997.c b/drivers/extcon/extcon-max8997.c
 index 69641bc..05b76b3 100644
 --- a/drivers/extcon/extcon-max8997.c
 +++ b/drivers/extcon/extcon-max8997.c
 @@ -232,7 +232,7 @@ static int max8997_muic_set_path(struct max8997_muic_info 
 *info,
   MAX8997_MUIC_REG_CONTROL1, ctrl1, COMP_SW_MASK);
   if (ret  0) {
   dev_err(info-dev, failed to update MUIC register\n);
 - return -EAGAIN;
 + return ret;
   }
  
   if (attached)
 @@ -245,7 +245,7 @@ static int max8997_muic_set_path(struct max8997_muic_info 
 *info,
   CONTROL2_LOWPWR_MASK | CONTROL2_CPEN_MASK);
   if (ret  0) {
   dev_err(info-dev, failed to update MUIC register\n);
 - return -EAGAIN;
 + return ret;
   }
  
   dev_info(info-dev,
OK, I agree with your opinion. So, can you fix all of these return type
on extcon-max8997.c? I'd like to receive one patch related
to modification for fixing return type.

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] extcon: max8997: Fix return value

[PATCH 2/2] extcon: max8997: Fix return value

[PATCH 2/2] extcon: max8997: Fix return value

Re: [PATCH 2/2] extcon: max8997: Fix return value

4 matches

Site Navigation

Mail list logo

Footer information