Re: [PATCH 2/2] gpio: max732x: use devm_gpiochip_add_data()

[Linus Walleij]

On Tue, May 21, 2019 at 11:03 AM Bartosz Golaszewski  wrote:

> From: Bartosz Golaszewski 
>
> We can simplify the code a bit with a resource managed variant of
> gpiochip_add_data().
>
> Signed-off-by: Bartosz Golaszewski 

Reviewed-by: Linus Walleij 

Yours,
Linus Walleij

[PATCH 2/2] gpio: max732x: use devm_gpiochip_add_data()

[Bartosz Golaszewski]

From: Bartosz Golaszewski 

We can simplify the code a bit with a resource managed variant of
gpiochip_add_data().

Signed-off-by: Bartosz Golaszewski 
---
 drivers/gpio/gpio-max732x.c | 8 ++--
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/drivers/gpio/gpio-max732x.c b/drivers/gpio/gpio-max732x.c
index 7fd1bdfe00e5..42c9b6ce4227 100644
--- a/drivers/gpio/gpio-max732x.c
+++ b/drivers/gpio/gpio-max732x.c
@@ -698,15 +698,13 @@ static int max732x_probe(struct i2c_client *client,
return ret;
}
 
-   ret = gpiochip_add_data(>gpio_chip, chip);
+   ret = devm_gpiochip_add_data(>dev, >gpio_chip, chip);
if (ret)
return ret;
 
ret = max732x_irq_setup(chip, id);
-   if (ret) {
-   gpiochip_remove(>gpio_chip);
+   if (ret)
return ret;
-   }
 
if (pdata && pdata->setup) {
ret = pdata->setup(client, chip->gpio_chip.base,
@@ -736,8 +734,6 @@ static int max732x_remove(struct i2c_client *client)
}
}
 
-   gpiochip_remove(>gpio_chip);
-
return 0;
 }
 
-- 
2.21.0