Re: [PATCH 2/2] notifiers: double register detection

[Vasily Averin]

Dear Andrew,
could you please pick up this patch?

It helps to detect double register of the same notifiers.
This kind of problem can lead to unexpected failures (some notifiers can be not 
called),
endless cycles, memory corruption or crashes.
Initially I've found such cases in OpenVZ kernels in our custom code,
then found similar bug in mainline nfsd (commit 1eca45f8)

On 21.09.2016 15:33, Vasily Averin wrote:
> WARN_ON should help to detect double register of the same notifiers
> 
> Signed-off-by: Vasily Averin 
> ---
>  kernel/notifier.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/notifier.c b/kernel/notifier.c
> index fd2c9ac..e02b2f0 100644
> --- a/kernel/notifier.c
> +++ b/kernel/notifier.c
> @@ -22,6 +22,7 @@ static int notifier_chain_register(struct notifier_block 
> **nl,
>   struct notifier_block *n)
>  {
>   while ((*nl) != NULL) {
> + WARN_ON((*nl) == n);
>   if (n->priority > (*nl)->priority)
>   break;
>   nl = &((*nl)->next);
> 

Re: [PATCH 2/2] notifiers: double register detection

[Vasily Averin]

Dear Andrew,
could you please pick up this patch?

It helps to detect double register of the same notifiers.
This kind of problem can lead to unexpected failures (some notifiers can be not 
called),
endless cycles, memory corruption or crashes.
Initially I've found such cases in OpenVZ kernels in our custom code,
then found similar bug in mainline nfsd (commit 1eca45f8)

On 21.09.2016 15:33, Vasily Averin wrote:
> WARN_ON should help to detect double register of the same notifiers
> 
> Signed-off-by: Vasily Averin 
> ---
>  kernel/notifier.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/notifier.c b/kernel/notifier.c
> index fd2c9ac..e02b2f0 100644
> --- a/kernel/notifier.c
> +++ b/kernel/notifier.c
> @@ -22,6 +22,7 @@ static int notifier_chain_register(struct notifier_block 
> **nl,
>   struct notifier_block *n)
>  {
>   while ((*nl) != NULL) {
> + WARN_ON((*nl) == n);
>   if (n->priority > (*nl)->priority)
>   break;
>   nl = &((*nl)->next);
> 

[PATCH 2/2] notifiers: double register detection

[Vasily Averin]

WARN_ON should help to detect double register of the same notifiers

Signed-off-by: Vasily Averin 
---
 kernel/notifier.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/notifier.c b/kernel/notifier.c
index fd2c9ac..e02b2f0 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -22,6 +22,7 @@ static int notifier_chain_register(struct notifier_block **nl,
struct notifier_block *n)
 {
while ((*nl) != NULL) {
+   WARN_ON((*nl) == n);
if (n->priority > (*nl)->priority)
break;
nl = &((*nl)->next);
-- 
1.9.1

[PATCH 2/2] notifiers: double register detection

[Vasily Averin]

WARN_ON should help to detect double register of the same notifiers

Signed-off-by: Vasily Averin 
---
 kernel/notifier.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/kernel/notifier.c b/kernel/notifier.c
index fd2c9ac..e02b2f0 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -22,6 +22,7 @@ static int notifier_chain_register(struct notifier_block **nl,
struct notifier_block *n)
 {
while ((*nl) != NULL) {
+   WARN_ON((*nl) == n);
if (n->priority > (*nl)->priority)
break;
nl = &((*nl)->next);
-- 
1.9.1