Re: [PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument

2015-08-30 Thread walter harms 


Am 30.08.2015 20:05, schrieb Julia Lawall:
> Apply PTR_ERR to the value that was recently assigned.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // 
> @@
> expression x,y;
> @@
> 
> if (IS_ERR(x) || ...) {
>   ... when any
>   when != IS_ERR(...)
> (
>PTR_ERR(x)
> |
> *  PTR_ERR(y)
> )
>   ... when any
> }
> // 
> 
> Signed-off-by: Julia Lawall 
> 
> ---
>  drivers/spi/spi-ep93xx.c |3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
> index bb00be8..1a7696c 100644
> --- a/drivers/spi/spi-ep93xx.c
> +++ b/drivers/spi/spi-ep93xx.c
> @@ -567,7 +567,8 @@ static void ep93xx_spi_dma_transfer(struct ep93xx_spi 
> *espi)
>   txd = ep93xx_spi_dma_prepare(espi, DMA_MEM_TO_DEV);
>   if (IS_ERR(txd)) {
>   ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM);
> - dev_err(>pdev->dev, "DMA TX failed: %ld\n", PTR_ERR(rxd));
> + dev_err(>pdev->dev, "DMA TX failed: %ld\n",
> + PTR_ERR(txd));
>   msg->status = PTR_ERR(txd);
>   return;
>   }
>

I improve readability i would suggest:

ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM);
msg->status = PTR_ERR(txd);
dev_err(>pdev->dev, "DMA TX failed: %ld\n",msg->status):
return;


just my 2 cents,

re,
 wh
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument

2015-08-30 Thread Julia Lawall 
Apply PTR_ERR to the value that was recently assigned.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression x,y;
@@

if (IS_ERR(x) || ...) {
  ... when any
  when != IS_ERR(...)
(
   PTR_ERR(x)
|
*  PTR_ERR(y)
)
  ... when any
}
// 

Signed-off-by: Julia Lawall 

---
 drivers/spi/spi-ep93xx.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index bb00be8..1a7696c 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -567,7 +567,8 @@ static void ep93xx_spi_dma_transfer(struct ep93xx_spi *espi)
txd = ep93xx_spi_dma_prepare(espi, DMA_MEM_TO_DEV);
if (IS_ERR(txd)) {
ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM);
-   dev_err(>pdev->dev, "DMA TX failed: %ld\n", PTR_ERR(rxd));
+   dev_err(>pdev->dev, "DMA TX failed: %ld\n",
+   PTR_ERR(txd));
msg->status = PTR_ERR(txd);
return;
}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument

2015-08-30 Thread walter harms 


Am 30.08.2015 20:05, schrieb Julia Lawall:
 Apply PTR_ERR to the value that was recently assigned.
 
 The semantic match that finds this problem is as follows:
 (http://coccinelle.lip6.fr/)
 
 // smpl
 @@
 expression x,y;
 @@
 
 if (IS_ERR(x) || ...) {
   ... when any
   when != IS_ERR(...)
 (
PTR_ERR(x)
 |
 *  PTR_ERR(y)
 )
   ... when any
 }
 // /smpl
 
 Signed-off-by: Julia Lawall julia.law...@lip6.fr
 
 ---
  drivers/spi/spi-ep93xx.c |3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)
 
 diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
 index bb00be8..1a7696c 100644
 --- a/drivers/spi/spi-ep93xx.c
 +++ b/drivers/spi/spi-ep93xx.c
 @@ -567,7 +567,8 @@ static void ep93xx_spi_dma_transfer(struct ep93xx_spi 
 *espi)
   txd = ep93xx_spi_dma_prepare(espi, DMA_MEM_TO_DEV);
   if (IS_ERR(txd)) {
   ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM);
 - dev_err(espi-pdev-dev, DMA TX failed: %ld\n, PTR_ERR(rxd));
 + dev_err(espi-pdev-dev, DMA TX failed: %ld\n,
 + PTR_ERR(txd));
   msg-status = PTR_ERR(txd);
   return;
   }


I improve readability i would suggest:

ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM);
msg-status = PTR_ERR(txd);
dev_err(espi-pdev-dev, DMA TX failed: %ld\n,msg-status):
return;


just my 2 cents,

re,
 wh
 --
 To unsubscribe from this list: send the line unsubscribe kernel-janitors in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/2] spi: spi-ep93xx: change PTR_ERR argument

2015-08-30 Thread Julia Lawall 
Apply PTR_ERR to the value that was recently assigned.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// smpl
@@
expression x,y;
@@

if (IS_ERR(x) || ...) {
  ... when any
  when != IS_ERR(...)
(
   PTR_ERR(x)
|
*  PTR_ERR(y)
)
  ... when any
}
// /smpl

Signed-off-by: Julia Lawall julia.law...@lip6.fr

---
 drivers/spi/spi-ep93xx.c |3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c
index bb00be8..1a7696c 100644
--- a/drivers/spi/spi-ep93xx.c
+++ b/drivers/spi/spi-ep93xx.c
@@ -567,7 +567,8 @@ static void ep93xx_spi_dma_transfer(struct ep93xx_spi *espi)
txd = ep93xx_spi_dma_prepare(espi, DMA_MEM_TO_DEV);
if (IS_ERR(txd)) {
ep93xx_spi_dma_finish(espi, DMA_DEV_TO_MEM);
-   dev_err(espi-pdev-dev, DMA TX failed: %ld\n, PTR_ERR(rxd));
+   dev_err(espi-pdev-dev, DMA TX failed: %ld\n,
+   PTR_ERR(txd));
msg-status = PTR_ERR(txd);
return;
}

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/