subject:"\[PATCH 2\/2\] staging\: ks7010\: Unnecessary parentheses are removed and also improved coding style."

Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

2017-02-21 Thread Julia Lawall



On Tue, 21 Feb 2017, Arushi Singhal wrote:

> Unnecessary parentheses are removed as reported by checkpatch.pl
> to make coder nicer and to improve readability.
> Also coding style is improved.For example:-
> It's often nicer to read if &(foo[0]) is converted to foo like:
>  memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
>  memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);


Should this be a v2, or some larger number?

julia

>
> Signed-off-by: Arushi Singhal 
> ---
>  drivers/staging/ks7010/ks_hostif.c   | 20 ++--
>  drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
>  2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c 
> b/drivers/staging/ks7010/ks_hostif.c
> index b643a37fb943..6e36aa2aea99 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -239,19 +239,19 @@ int get_ap_information(struct ks_wlan_private *priv, 
> struct ap_info_t *ap_info,
>   *(bp + 1));
>   ap->ssid.size = SSID_MAX_SIZE;
>   }
> - memcpy(&(ap->ssid.body[0]), bp + 2, ap->ssid.size);
> + memcpy(ap->ssid.body, bp + 2, ap->ssid.size);
>   break;
>   case 1: /* rate */
>   case 50:/* ext rate */
>   if ((*(bp + 1) + ap->rate_set.size) <=
>   RATE_SET_MAX_SIZE) {
> - memcpy(&(ap->rate_set.body[ap->rate_set.size]),
> + memcpy(>rate_set.body[ap->rate_set.size],
>  bp + 2, *(bp + 1));
>   ap->rate_set.size += *(bp + 1);
>   } else {
>   DPRINTK(1, "size over :: rate size=%d\n",
>   (*(bp + 1) + ap->rate_set.size));
> - memcpy(&(ap->rate_set.body[ap->rate_set.size]),
> + memcpy(>rate_set.body[ap->rate_set.size],
>  bp + 2,
>  RATE_SET_MAX_SIZE - ap->rate_set.size);
>   ap->rate_set.size +=
> @@ -269,7 +269,7 @@ int get_ap_information(struct ks_wlan_private *priv, 
> struct ap_info_t *ap_info,
>   *(bp + 1));
>   ap->rsn_ie.size = RSN_IE_BODY_MAX;
>   }
> - memcpy(&(ap->rsn_ie.body[0]), bp + 2, ap->rsn_ie.size);
> + memcpy(ap->rsn_ie.body, bp + 2, ap->rsn_ie.size);
>   break;
>   case 221:   /* WPA */
>   if (!memcmp(bp + 2, "\x00\x50\xf2\x01", 4)) {   /* WPA 
> OUI check */
> @@ -282,7 +282,7 @@ int get_ap_information(struct ks_wlan_private *priv, 
> struct ap_info_t *ap_info,
>   *(bp + 1));
>   ap->wpa_ie.size = RSN_IE_BODY_MAX;
>   }
> - memcpy(&(ap->wpa_ie.body[0]), bp + 2,
> + memcpy(ap->wpa_ie.body, bp + 2,
>  ap->wpa_ie.size);
>   }
>   break;
> @@ -832,8 +832,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
>   if (priv->scan_ind_count != 0) {
>   for (i = 0; i < priv->aplist.size; i++) {   /* bssid check 
> */
>   if (!memcmp
> - (&(ap_info->bssid[0]),
> -  &(priv->aplist.ap[i].bssid[0]), ETH_ALEN)) {
> + (ap_info->bssid,
> +  >aplist.ap[i].bssid[0], ETH_ALEN)) {
>   if (ap_info->frame_type ==
>   FRAME_TYPE_PROBE_RESP)
>   get_ap_information(priv, ap_info,
> @@ -2652,7 +2652,7 @@ int hostif_init(struct ks_wlan_private *priv)
>
>   priv->aplist.size = 0;
>   for (i = 0; i < LOCAL_APLIST_MAX; i++)
> - memset(&(priv->aplist.ap[i]), 0, sizeof(struct local_ap_t));
> + memset(>aplist.ap[i], 0, sizeof(struct local_ap_t));
>   priv->infra_status = 0;
>   priv->current_rate = 4;
>   priv->connect_status = DISCONNECT_STATUS;
> @@ -2675,12 +2675,12 @@ int hostif_init(struct ks_wlan_private *priv)
>   INIT_WORK(>ks_wlan_wakeup_task, ks_wlan_hw_wakeup_task);
>
>   /* WPA */
> - memset(&(priv->wpa), 0, sizeof(priv->wpa));
> + memset(>wpa, 0, sizeof(priv->wpa));
>   priv->wpa.rsn_enabled = 0;
>   priv->wpa.mic_failure.failure = 0;
>   priv->wpa.mic_failure.last_failure_time = 0;
>   priv->wpa.mic_failure.stop = 0;
> - memset(&(priv->pmklist), 0, sizeof(priv->pmklist));
> +

Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

2017-02-21 Thread Julia Lawall



On Tue, 21 Feb 2017, Arushi Singhal wrote:

> Unnecessary parentheses are removed as reported by checkpatch.pl
> to make coder nicer and to improve readability.
> Also coding style is improved.For example:-
> It's often nicer to read if &(foo[0]) is converted to foo like:
>  memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
>  memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);


Should this be a v2, or some larger number?

julia

>
> Signed-off-by: Arushi Singhal 
> ---
>  drivers/staging/ks7010/ks_hostif.c   | 20 ++--
>  drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
>  2 files changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_hostif.c 
> b/drivers/staging/ks7010/ks_hostif.c
> index b643a37fb943..6e36aa2aea99 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -239,19 +239,19 @@ int get_ap_information(struct ks_wlan_private *priv, 
> struct ap_info_t *ap_info,
>   *(bp + 1));
>   ap->ssid.size = SSID_MAX_SIZE;
>   }
> - memcpy(&(ap->ssid.body[0]), bp + 2, ap->ssid.size);
> + memcpy(ap->ssid.body, bp + 2, ap->ssid.size);
>   break;
>   case 1: /* rate */
>   case 50:/* ext rate */
>   if ((*(bp + 1) + ap->rate_set.size) <=
>   RATE_SET_MAX_SIZE) {
> - memcpy(&(ap->rate_set.body[ap->rate_set.size]),
> + memcpy(>rate_set.body[ap->rate_set.size],
>  bp + 2, *(bp + 1));
>   ap->rate_set.size += *(bp + 1);
>   } else {
>   DPRINTK(1, "size over :: rate size=%d\n",
>   (*(bp + 1) + ap->rate_set.size));
> - memcpy(&(ap->rate_set.body[ap->rate_set.size]),
> + memcpy(>rate_set.body[ap->rate_set.size],
>  bp + 2,
>  RATE_SET_MAX_SIZE - ap->rate_set.size);
>   ap->rate_set.size +=
> @@ -269,7 +269,7 @@ int get_ap_information(struct ks_wlan_private *priv, 
> struct ap_info_t *ap_info,
>   *(bp + 1));
>   ap->rsn_ie.size = RSN_IE_BODY_MAX;
>   }
> - memcpy(&(ap->rsn_ie.body[0]), bp + 2, ap->rsn_ie.size);
> + memcpy(ap->rsn_ie.body, bp + 2, ap->rsn_ie.size);
>   break;
>   case 221:   /* WPA */
>   if (!memcmp(bp + 2, "\x00\x50\xf2\x01", 4)) {   /* WPA 
> OUI check */
> @@ -282,7 +282,7 @@ int get_ap_information(struct ks_wlan_private *priv, 
> struct ap_info_t *ap_info,
>   *(bp + 1));
>   ap->wpa_ie.size = RSN_IE_BODY_MAX;
>   }
> - memcpy(&(ap->wpa_ie.body[0]), bp + 2,
> + memcpy(ap->wpa_ie.body, bp + 2,
>  ap->wpa_ie.size);
>   }
>   break;
> @@ -832,8 +832,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
>   if (priv->scan_ind_count != 0) {
>   for (i = 0; i < priv->aplist.size; i++) {   /* bssid check 
> */
>   if (!memcmp
> - (&(ap_info->bssid[0]),
> -  &(priv->aplist.ap[i].bssid[0]), ETH_ALEN)) {
> + (ap_info->bssid,
> +  >aplist.ap[i].bssid[0], ETH_ALEN)) {
>   if (ap_info->frame_type ==
>   FRAME_TYPE_PROBE_RESP)
>   get_ap_information(priv, ap_info,
> @@ -2652,7 +2652,7 @@ int hostif_init(struct ks_wlan_private *priv)
>
>   priv->aplist.size = 0;
>   for (i = 0; i < LOCAL_APLIST_MAX; i++)
> - memset(&(priv->aplist.ap[i]), 0, sizeof(struct local_ap_t));
> + memset(>aplist.ap[i], 0, sizeof(struct local_ap_t));
>   priv->infra_status = 0;
>   priv->current_rate = 4;
>   priv->connect_status = DISCONNECT_STATUS;
> @@ -2675,12 +2675,12 @@ int hostif_init(struct ks_wlan_private *priv)
>   INIT_WORK(>ks_wlan_wakeup_task, ks_wlan_hw_wakeup_task);
>
>   /* WPA */
> - memset(&(priv->wpa), 0, sizeof(priv->wpa));
> + memset(>wpa, 0, sizeof(priv->wpa));
>   priv->wpa.rsn_enabled = 0;
>   priv->wpa.mic_failure.failure = 0;
>   priv->wpa.mic_failure.last_failure_time = 0;
>   priv->wpa.mic_failure.stop = 0;
> - memset(&(priv->pmklist), 0, sizeof(priv->pmklist));
> + memset(>pmklist, 0,

[PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

2017-02-21 Thread Arushi Singhal

Unnecessary parentheses are removed as reported by checkpatch.pl
to make coder nicer and to improve readability.
Also coding style is improved.For example:-
It's often nicer to read if &(foo[0]) is converted to foo like:
 memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
 memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);

Signed-off-by: Arushi Singhal 
---
 drivers/staging/ks7010/ks_hostif.c   | 20 ++--
 drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c 
b/drivers/staging/ks7010/ks_hostif.c
index b643a37fb943..6e36aa2aea99 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -239,19 +239,19 @@ int get_ap_information(struct ks_wlan_private *priv, 
struct ap_info_t *ap_info,
*(bp + 1));
ap->ssid.size = SSID_MAX_SIZE;
}
-   memcpy(&(ap->ssid.body[0]), bp + 2, ap->ssid.size);
+   memcpy(ap->ssid.body, bp + 2, ap->ssid.size);
break;
case 1: /* rate */
case 50:/* ext rate */
if ((*(bp + 1) + ap->rate_set.size) <=
RATE_SET_MAX_SIZE) {
-   memcpy(&(ap->rate_set.body[ap->rate_set.size]),
+   memcpy(>rate_set.body[ap->rate_set.size],
   bp + 2, *(bp + 1));
ap->rate_set.size += *(bp + 1);
} else {
DPRINTK(1, "size over :: rate size=%d\n",
(*(bp + 1) + ap->rate_set.size));
-   memcpy(&(ap->rate_set.body[ap->rate_set.size]),
+   memcpy(>rate_set.body[ap->rate_set.size],
   bp + 2,
   RATE_SET_MAX_SIZE - ap->rate_set.size);
ap->rate_set.size +=
@@ -269,7 +269,7 @@ int get_ap_information(struct ks_wlan_private *priv, struct 
ap_info_t *ap_info,
*(bp + 1));
ap->rsn_ie.size = RSN_IE_BODY_MAX;
}
-   memcpy(&(ap->rsn_ie.body[0]), bp + 2, ap->rsn_ie.size);
+   memcpy(ap->rsn_ie.body, bp + 2, ap->rsn_ie.size);
break;
case 221:   /* WPA */
if (!memcmp(bp + 2, "\x00\x50\xf2\x01", 4)) {   /* WPA 
OUI check */
@@ -282,7 +282,7 @@ int get_ap_information(struct ks_wlan_private *priv, struct 
ap_info_t *ap_info,
*(bp + 1));
ap->wpa_ie.size = RSN_IE_BODY_MAX;
}
-   memcpy(&(ap->wpa_ie.body[0]), bp + 2,
+   memcpy(ap->wpa_ie.body, bp + 2,
   ap->wpa_ie.size);
}
break;
@@ -832,8 +832,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
if (priv->scan_ind_count != 0) {
for (i = 0; i < priv->aplist.size; i++) {   /* bssid check 
*/
if (!memcmp
-   (&(ap_info->bssid[0]),
-&(priv->aplist.ap[i].bssid[0]), ETH_ALEN)) {
+   (ap_info->bssid,
+>aplist.ap[i].bssid[0], ETH_ALEN)) {
if (ap_info->frame_type ==
FRAME_TYPE_PROBE_RESP)
get_ap_information(priv, ap_info,
@@ -2652,7 +2652,7 @@ int hostif_init(struct ks_wlan_private *priv)
 
priv->aplist.size = 0;
for (i = 0; i < LOCAL_APLIST_MAX; i++)
-   memset(&(priv->aplist.ap[i]), 0, sizeof(struct local_ap_t));
+   memset(>aplist.ap[i], 0, sizeof(struct local_ap_t));
priv->infra_status = 0;
priv->current_rate = 4;
priv->connect_status = DISCONNECT_STATUS;
@@ -2675,12 +2675,12 @@ int hostif_init(struct ks_wlan_private *priv)
INIT_WORK(>ks_wlan_wakeup_task, ks_wlan_hw_wakeup_task);
 
/* WPA */
-   memset(&(priv->wpa), 0, sizeof(priv->wpa));
+   memset(>wpa, 0, sizeof(priv->wpa));
priv->wpa.rsn_enabled = 0;
priv->wpa.mic_failure.failure = 0;
priv->wpa.mic_failure.last_failure_time = 0;
priv->wpa.mic_failure.stop = 0;
-   memset(&(priv->pmklist), 0, sizeof(priv->pmklist));
+   memset(>pmklist, 0, sizeof(priv->pmklist));
INIT_LIST_HEAD(>pmklist.head);
for (i = 0; i < PMK_LIST_MAX; i++)

[PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

2017-02-21 Thread Arushi Singhal

Unnecessary parentheses are removed as reported by checkpatch.pl
to make coder nicer and to improve readability.
Also coding style is improved.For example:-
It's often nicer to read if &(foo[0]) is converted to foo like:
 memcpy(&(ap->bssid[0]), &(ap_info->bssid[0]), ETH_ALEN);
 memcpy(ap->bssid, ap_info->bssid, ETH_ALEN);

Signed-off-by: Arushi Singhal 
---
 drivers/staging/ks7010/ks_hostif.c   | 20 ++--
 drivers/staging/ks7010/ks_wlan_net.c | 20 ++--
 2 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/drivers/staging/ks7010/ks_hostif.c 
b/drivers/staging/ks7010/ks_hostif.c
index b643a37fb943..6e36aa2aea99 100644
--- a/drivers/staging/ks7010/ks_hostif.c
+++ b/drivers/staging/ks7010/ks_hostif.c
@@ -239,19 +239,19 @@ int get_ap_information(struct ks_wlan_private *priv, 
struct ap_info_t *ap_info,
*(bp + 1));
ap->ssid.size = SSID_MAX_SIZE;
}
-   memcpy(&(ap->ssid.body[0]), bp + 2, ap->ssid.size);
+   memcpy(ap->ssid.body, bp + 2, ap->ssid.size);
break;
case 1: /* rate */
case 50:/* ext rate */
if ((*(bp + 1) + ap->rate_set.size) <=
RATE_SET_MAX_SIZE) {
-   memcpy(&(ap->rate_set.body[ap->rate_set.size]),
+   memcpy(>rate_set.body[ap->rate_set.size],
   bp + 2, *(bp + 1));
ap->rate_set.size += *(bp + 1);
} else {
DPRINTK(1, "size over :: rate size=%d\n",
(*(bp + 1) + ap->rate_set.size));
-   memcpy(&(ap->rate_set.body[ap->rate_set.size]),
+   memcpy(>rate_set.body[ap->rate_set.size],
   bp + 2,
   RATE_SET_MAX_SIZE - ap->rate_set.size);
ap->rate_set.size +=
@@ -269,7 +269,7 @@ int get_ap_information(struct ks_wlan_private *priv, struct 
ap_info_t *ap_info,
*(bp + 1));
ap->rsn_ie.size = RSN_IE_BODY_MAX;
}
-   memcpy(&(ap->rsn_ie.body[0]), bp + 2, ap->rsn_ie.size);
+   memcpy(ap->rsn_ie.body, bp + 2, ap->rsn_ie.size);
break;
case 221:   /* WPA */
if (!memcmp(bp + 2, "\x00\x50\xf2\x01", 4)) {   /* WPA 
OUI check */
@@ -282,7 +282,7 @@ int get_ap_information(struct ks_wlan_private *priv, struct 
ap_info_t *ap_info,
*(bp + 1));
ap->wpa_ie.size = RSN_IE_BODY_MAX;
}
-   memcpy(&(ap->wpa_ie.body[0]), bp + 2,
+   memcpy(ap->wpa_ie.body, bp + 2,
   ap->wpa_ie.size);
}
break;
@@ -832,8 +832,8 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
if (priv->scan_ind_count != 0) {
for (i = 0; i < priv->aplist.size; i++) {   /* bssid check 
*/
if (!memcmp
-   (&(ap_info->bssid[0]),
-&(priv->aplist.ap[i].bssid[0]), ETH_ALEN)) {
+   (ap_info->bssid,
+>aplist.ap[i].bssid[0], ETH_ALEN)) {
if (ap_info->frame_type ==
FRAME_TYPE_PROBE_RESP)
get_ap_information(priv, ap_info,
@@ -2652,7 +2652,7 @@ int hostif_init(struct ks_wlan_private *priv)
 
priv->aplist.size = 0;
for (i = 0; i < LOCAL_APLIST_MAX; i++)
-   memset(&(priv->aplist.ap[i]), 0, sizeof(struct local_ap_t));
+   memset(>aplist.ap[i], 0, sizeof(struct local_ap_t));
priv->infra_status = 0;
priv->current_rate = 4;
priv->connect_status = DISCONNECT_STATUS;
@@ -2675,12 +2675,12 @@ int hostif_init(struct ks_wlan_private *priv)
INIT_WORK(>ks_wlan_wakeup_task, ks_wlan_hw_wakeup_task);
 
/* WPA */
-   memset(&(priv->wpa), 0, sizeof(priv->wpa));
+   memset(>wpa, 0, sizeof(priv->wpa));
priv->wpa.rsn_enabled = 0;
priv->wpa.mic_failure.failure = 0;
priv->wpa.mic_failure.last_failure_time = 0;
priv->wpa.mic_failure.stop = 0;
-   memset(&(priv->pmklist), 0, sizeof(priv->pmklist));
+   memset(>pmklist, 0, sizeof(priv->pmklist));
INIT_LIST_HEAD(>pmklist.head);
for (i = 0; i < PMK_LIST_MAX; i++)
INIT_LIST_HEAD(>pmklist.pmk[i].list);
diff

Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

Re: [Outreachy kernel] [PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

[PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

[PATCH 2/2] staging: ks7010: Unnecessary parentheses are removed and also improved coding style.

4 matches

Site Navigation

Mail list logo

Footer information