Re: [PATCH 2/2] staging: slicoss: slicoss.c: fix different address space sparse warnings

[kbuild test robot]

Hi Peng,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20160913]
[cannot apply to v4.8-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for 
convenience) to record what (public, well-known) commit your patch series was 
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:
https://github.com/0day-ci/linux/commits/Peng-Sun/staging-slicoss-fix-sparse-warnings/20160913-190805
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from drivers/staging/slicoss/slicoss.c:97:0:
   drivers/staging/slicoss/slicoss.c: In function 'slic_upr_request_complete':
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
>> drivers/staging/slicoss/slicoss.c:1020:5: note: in expansion of macro 
>> 'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_tcp_segs),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1024:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_tcp_bytes),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1028:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_tcp_segs),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1032:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_tcp_bytes),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1036:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_bytes),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1040:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_unicasts),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1044:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_bytes),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   

Re: [PATCH 2/2] staging: slicoss: slicoss.c: fix different address space sparse warnings

[kbuild test robot]

Hi Peng,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20160913]
[cannot apply to v4.8-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for 
convenience) to record what (public, well-known) commit your patch series was 
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:
https://github.com/0day-ci/linux/commits/Peng-Sun/staging-slicoss-fix-sparse-warnings/20160913-190805
config: i386-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   In file included from drivers/staging/slicoss/slicoss.c:97:0:
   drivers/staging/slicoss/slicoss.c: In function 'slic_upr_request_complete':
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
>> drivers/staging/slicoss/slicoss.c:1020:5: note: in expansion of macro 
>> 'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_tcp_segs),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1024:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_tcp_bytes),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1028:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_tcp_segs),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1032:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_tcp_bytes),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1036:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_bytes),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1040:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_unicasts),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1044:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_bytes),
^
>> drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   

Re: [PATCH 2/2] staging: slicoss: slicoss.c: fix different address space sparse warnings

[kbuild test robot]

Hi Peng,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20160913]
[cannot apply to v4.8-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for 
convenience) to record what (public, well-known) commit your patch series was 
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:
https://github.com/0day-ci/linux/commits/Peng-Sun/staging-slicoss-fix-sparse-warnings/20160913-190805
config: i386-randconfig-h1-09132219 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1032:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_tcp_bytes),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1036:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_bytes),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1040:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_unicasts),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1044:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_bytes),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1048:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_unicasts),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1052:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_collisions),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1056:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats,
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
   

Re: [PATCH 2/2] staging: slicoss: slicoss.c: fix different address space sparse warnings

[kbuild test robot]

Hi Peng,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20160913]
[cannot apply to v4.8-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for 
convenience) to record what (public, well-known) commit your patch series was 
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:
https://github.com/0day-ci/linux/commits/Peng-Sun/staging-slicoss-fix-sparse-warnings/20160913-190805
config: i386-randconfig-h1-09132219 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1032:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_tcp_bytes),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1036:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_bytes),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1040:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_unicasts),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1044:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_bytes),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1048:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, rcv_unicasts),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1052:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats, xmit_collisions),
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
  ^~~
   drivers/staging/slicoss/slicoss.c:1056:5: note: in expansion of macro 
'IOMEM_GET_FIELD64'
IOMEM_GET_FIELD64(stats,
^
   drivers/staging/slicoss/slic.h:575:2: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
 u64 val = ((u64)ioread8(_base + 7)) << 56;   \
 ^
   drivers/staging/slicoss/slic.h:597:19: note: in definition of macro 
'UPDATE_STATS_GB'
 (largestat) += ((newstat) - (oldstat));  \
   

Re: [PATCH 2/2] staging: slicoss: slicoss.c: fix different address space sparse warnings

[kbuild test robot]

Hi Peng,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20160913]
[cannot apply to v4.8-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for 
convenience) to record what (public, well-known) commit your patch series was 
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:
https://github.com/0day-ci/linux/commits/Peng-Sun/staging-slicoss-fix-sparse-warnings/20160913-190805
config: i386-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/staging/slicoss/slicoss.c: In function 'slic_upr_request_complete':
>> drivers/staging/slicoss/slicoss.c:1019:128: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->tcp.xmit_tcp_segs,

   ^  
   drivers/staging/slicoss/slicoss.c:1023:130: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->tcp.xmit_tcp_bytes,

 ^  
   drivers/staging/slicoss/slicoss.c:1027:126: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->tcp.rcv_tcp_segs,

 ^  
   drivers/staging/slicoss/slicoss.c:1031:128: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->tcp.rcv_tcp_bytes,

   ^  
   drivers/staging/slicoss/slicoss.c:1035:123: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_bytes,

  ^  
   drivers/staging/slicoss/slicoss.c:1039:126: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_ucast,

 ^  
   drivers/staging/slicoss/slicoss.c:1043:122: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.rcv_bytes,

 ^  
   drivers/staging/slicoss/slicoss.c:1047:125: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.rcv_ucast,

^  
   drivers/staging/slicoss/slicoss.c:1051:129: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_errors,

^  
   drivers/staging/slicoss/slicoss.c:1055:136: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_errors,

   ^  
   drivers/staging/slicoss/slicoss.c:1060:130: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_errors,

 ^  
   drivers/staging/slicoss/slicoss.c:1064:129: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.rcv_errors,

^  
   drivers/staging/slicoss/slicoss.c:1068:125: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.rcv_discards,

^  
   

Re: [PATCH 2/2] staging: slicoss: slicoss.c: fix different address space sparse warnings

[kbuild test robot]

Hi Peng,

[auto build test WARNING on staging/staging-testing]
[also build test WARNING on next-20160913]
[cannot apply to v4.8-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]
[Suggest to use git(>=2.9.0) format-patch --base= (or --base=auto for 
convenience) to record what (public, well-known) commit your patch series was 
built on]
[Check https://git-scm.com/docs/git-format-patch for more information]

url:
https://github.com/0day-ci/linux/commits/Peng-Sun/staging-slicoss-fix-sparse-warnings/20160913-190805
config: i386-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386 

All warnings (new ones prefixed by >>):

   drivers/staging/slicoss/slicoss.c: In function 'slic_upr_request_complete':
>> drivers/staging/slicoss/slicoss.c:1019:128: warning: ISO C90 forbids mixed 
>> declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->tcp.xmit_tcp_segs,

   ^  
   drivers/staging/slicoss/slicoss.c:1023:130: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->tcp.xmit_tcp_bytes,

 ^  
   drivers/staging/slicoss/slicoss.c:1027:126: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->tcp.rcv_tcp_segs,

 ^  
   drivers/staging/slicoss/slicoss.c:1031:128: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->tcp.rcv_tcp_bytes,

   ^  
   drivers/staging/slicoss/slicoss.c:1035:123: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_bytes,

  ^  
   drivers/staging/slicoss/slicoss.c:1039:126: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_ucast,

 ^  
   drivers/staging/slicoss/slicoss.c:1043:122: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.rcv_bytes,

 ^  
   drivers/staging/slicoss/slicoss.c:1047:125: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.rcv_ucast,

^  
   drivers/staging/slicoss/slicoss.c:1051:129: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_errors,

^  
   drivers/staging/slicoss/slicoss.c:1055:136: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_errors,

   ^  
   drivers/staging/slicoss/slicoss.c:1060:130: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.xmt_errors,

 ^  
   drivers/staging/slicoss/slicoss.c:1064:129: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.rcv_errors,

^  
   drivers/staging/slicoss/slicoss.c:1068:125: warning: ISO C90 forbids mixed 
declarations and code [-Wdeclaration-after-statement]
  UPDATE_STATS_GB(stst->iface.rcv_discards,

^  
   

[PATCH 2/2] staging: slicoss: slicoss.c: fix different address space sparse warnings

[Peng Sun]

Signed-off-by: Peng Sun 
---
 drivers/staging/slicoss/slicoss.c | 82 +++
 1 file changed, 49 insertions(+), 33 deletions(-)

diff --git a/drivers/staging/slicoss/slicoss.c 
b/drivers/staging/slicoss/slicoss.c
index 21280a3..abe7592 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -924,8 +924,8 @@ err_unlock_irq:
 static void slic_link_upr_complete(struct adapter *adapter, u32 isr)
 {
struct slic_shmemory *sm = >shmem;
-   struct slic_shmem_data *sm_data = sm->shmem_data;
-   u32 lst = sm_data->lnkstatus;
+   struct slic_shmem_data __iomem *sm_data = sm->shmem_data;
+   u32 lst = IOMEM_GET_FIELD32(sm_data, lnkstatus);
uint linkup;
unsigned char linkspeed;
unsigned char linkduplex;
@@ -1004,8 +1004,9 @@ static void slic_upr_request_complete(struct adapter 
*adapter, u32 isr)
switch (upr->upr_request) {
case SLIC_UPR_STATS: {
struct slic_shmemory *sm = >shmem;
-   struct slic_shmem_data *sm_data = sm->shmem_data;
-   struct slic_stats *stats = _data->stats;
+   struct slic_shmem_data __iomem *sm_data = sm->shmem_data;
+   struct slic_stats __iomem *stats =
+   IOMEM_GET_FIELDADDR(sm_data, stats);
struct slic_stats *old = >inicstats_prev;
struct slicnet_stats *stst = >slic_stats;
 
@@ -1015,48 +1016,62 @@ static void slic_upr_request_complete(struct adapter 
*adapter, u32 isr)
break;
}
 
-   UPDATE_STATS_GB(stst->tcp.xmit_tcp_segs, stats->xmit_tcp_segs,
+   UPDATE_STATS_GB(stst->tcp.xmit_tcp_segs,
+   IOMEM_GET_FIELD64(stats, xmit_tcp_segs),
old->xmit_tcp_segs);
 
-   UPDATE_STATS_GB(stst->tcp.xmit_tcp_bytes, stats->xmit_tcp_bytes,
+   UPDATE_STATS_GB(stst->tcp.xmit_tcp_bytes,
+   IOMEM_GET_FIELD64(stats, xmit_tcp_bytes),
old->xmit_tcp_bytes);
 
-   UPDATE_STATS_GB(stst->tcp.rcv_tcp_segs, stats->rcv_tcp_segs,
+   UPDATE_STATS_GB(stst->tcp.rcv_tcp_segs,
+   IOMEM_GET_FIELD64(stats, rcv_tcp_segs),
old->rcv_tcp_segs);
 
-   UPDATE_STATS_GB(stst->tcp.rcv_tcp_bytes, stats->rcv_tcp_bytes,
+   UPDATE_STATS_GB(stst->tcp.rcv_tcp_bytes,
+   IOMEM_GET_FIELD64(stats, rcv_tcp_bytes),
old->rcv_tcp_bytes);
 
-   UPDATE_STATS_GB(stst->iface.xmt_bytes, stats->xmit_bytes,
+   UPDATE_STATS_GB(stst->iface.xmt_bytes,
+   IOMEM_GET_FIELD64(stats, xmit_bytes),
old->xmit_bytes);
 
-   UPDATE_STATS_GB(stst->iface.xmt_ucast, stats->xmit_unicasts,
+   UPDATE_STATS_GB(stst->iface.xmt_ucast,
+   IOMEM_GET_FIELD64(stats, xmit_unicasts),
old->xmit_unicasts);
 
-   UPDATE_STATS_GB(stst->iface.rcv_bytes, stats->rcv_bytes,
+   UPDATE_STATS_GB(stst->iface.rcv_bytes,
+   IOMEM_GET_FIELD64(stats, rcv_bytes),
old->rcv_bytes);
 
-   UPDATE_STATS_GB(stst->iface.rcv_ucast, stats->rcv_unicasts,
+   UPDATE_STATS_GB(stst->iface.rcv_ucast,
+   IOMEM_GET_FIELD64(stats, rcv_unicasts),
old->rcv_unicasts);
 
-   UPDATE_STATS_GB(stst->iface.xmt_errors, stats->xmit_collisions,
+   UPDATE_STATS_GB(stst->iface.xmt_errors,
+   IOMEM_GET_FIELD64(stats, xmit_collisions),
old->xmit_collisions);
 
UPDATE_STATS_GB(stst->iface.xmt_errors,
-   stats->xmit_excess_collisions,
+   IOMEM_GET_FIELD64(stats,
+ xmit_excess_collisions),
old->xmit_excess_collisions);
 
-   UPDATE_STATS_GB(stst->iface.xmt_errors, stats->xmit_other_error,
+   UPDATE_STATS_GB(stst->iface.xmt_errors,
+   IOMEM_GET_FIELD64(stats, xmit_other_error),
old->xmit_other_error);
 
-   UPDATE_STATS_GB(stst->iface.rcv_errors, stats->rcv_other_error,
+   UPDATE_STATS_GB(stst->iface.rcv_errors,
+   IOMEM_GET_FIELD64(stats, rcv_other_error),
old->rcv_other_error);
 
-   UPDATE_STATS_GB(stst->iface.rcv_discards, stats->rcv_drops,
+   UPDATE_STATS_GB(stst->iface.rcv_discards,
+   

[PATCH 2/2] staging: slicoss: slicoss.c: fix different address space sparse warnings

[Peng Sun]

Signed-off-by: Peng Sun 
---
 drivers/staging/slicoss/slicoss.c | 82 +++
 1 file changed, 49 insertions(+), 33 deletions(-)

diff --git a/drivers/staging/slicoss/slicoss.c 
b/drivers/staging/slicoss/slicoss.c
index 21280a3..abe7592 100644
--- a/drivers/staging/slicoss/slicoss.c
+++ b/drivers/staging/slicoss/slicoss.c
@@ -924,8 +924,8 @@ err_unlock_irq:
 static void slic_link_upr_complete(struct adapter *adapter, u32 isr)
 {
struct slic_shmemory *sm = >shmem;
-   struct slic_shmem_data *sm_data = sm->shmem_data;
-   u32 lst = sm_data->lnkstatus;
+   struct slic_shmem_data __iomem *sm_data = sm->shmem_data;
+   u32 lst = IOMEM_GET_FIELD32(sm_data, lnkstatus);
uint linkup;
unsigned char linkspeed;
unsigned char linkduplex;
@@ -1004,8 +1004,9 @@ static void slic_upr_request_complete(struct adapter 
*adapter, u32 isr)
switch (upr->upr_request) {
case SLIC_UPR_STATS: {
struct slic_shmemory *sm = >shmem;
-   struct slic_shmem_data *sm_data = sm->shmem_data;
-   struct slic_stats *stats = _data->stats;
+   struct slic_shmem_data __iomem *sm_data = sm->shmem_data;
+   struct slic_stats __iomem *stats =
+   IOMEM_GET_FIELDADDR(sm_data, stats);
struct slic_stats *old = >inicstats_prev;
struct slicnet_stats *stst = >slic_stats;
 
@@ -1015,48 +1016,62 @@ static void slic_upr_request_complete(struct adapter 
*adapter, u32 isr)
break;
}
 
-   UPDATE_STATS_GB(stst->tcp.xmit_tcp_segs, stats->xmit_tcp_segs,
+   UPDATE_STATS_GB(stst->tcp.xmit_tcp_segs,
+   IOMEM_GET_FIELD64(stats, xmit_tcp_segs),
old->xmit_tcp_segs);
 
-   UPDATE_STATS_GB(stst->tcp.xmit_tcp_bytes, stats->xmit_tcp_bytes,
+   UPDATE_STATS_GB(stst->tcp.xmit_tcp_bytes,
+   IOMEM_GET_FIELD64(stats, xmit_tcp_bytes),
old->xmit_tcp_bytes);
 
-   UPDATE_STATS_GB(stst->tcp.rcv_tcp_segs, stats->rcv_tcp_segs,
+   UPDATE_STATS_GB(stst->tcp.rcv_tcp_segs,
+   IOMEM_GET_FIELD64(stats, rcv_tcp_segs),
old->rcv_tcp_segs);
 
-   UPDATE_STATS_GB(stst->tcp.rcv_tcp_bytes, stats->rcv_tcp_bytes,
+   UPDATE_STATS_GB(stst->tcp.rcv_tcp_bytes,
+   IOMEM_GET_FIELD64(stats, rcv_tcp_bytes),
old->rcv_tcp_bytes);
 
-   UPDATE_STATS_GB(stst->iface.xmt_bytes, stats->xmit_bytes,
+   UPDATE_STATS_GB(stst->iface.xmt_bytes,
+   IOMEM_GET_FIELD64(stats, xmit_bytes),
old->xmit_bytes);
 
-   UPDATE_STATS_GB(stst->iface.xmt_ucast, stats->xmit_unicasts,
+   UPDATE_STATS_GB(stst->iface.xmt_ucast,
+   IOMEM_GET_FIELD64(stats, xmit_unicasts),
old->xmit_unicasts);
 
-   UPDATE_STATS_GB(stst->iface.rcv_bytes, stats->rcv_bytes,
+   UPDATE_STATS_GB(stst->iface.rcv_bytes,
+   IOMEM_GET_FIELD64(stats, rcv_bytes),
old->rcv_bytes);
 
-   UPDATE_STATS_GB(stst->iface.rcv_ucast, stats->rcv_unicasts,
+   UPDATE_STATS_GB(stst->iface.rcv_ucast,
+   IOMEM_GET_FIELD64(stats, rcv_unicasts),
old->rcv_unicasts);
 
-   UPDATE_STATS_GB(stst->iface.xmt_errors, stats->xmit_collisions,
+   UPDATE_STATS_GB(stst->iface.xmt_errors,
+   IOMEM_GET_FIELD64(stats, xmit_collisions),
old->xmit_collisions);
 
UPDATE_STATS_GB(stst->iface.xmt_errors,
-   stats->xmit_excess_collisions,
+   IOMEM_GET_FIELD64(stats,
+ xmit_excess_collisions),
old->xmit_excess_collisions);
 
-   UPDATE_STATS_GB(stst->iface.xmt_errors, stats->xmit_other_error,
+   UPDATE_STATS_GB(stst->iface.xmt_errors,
+   IOMEM_GET_FIELD64(stats, xmit_other_error),
old->xmit_other_error);
 
-   UPDATE_STATS_GB(stst->iface.rcv_errors, stats->rcv_other_error,
+   UPDATE_STATS_GB(stst->iface.rcv_errors,
+   IOMEM_GET_FIELD64(stats, rcv_other_error),
old->rcv_other_error);
 
-   UPDATE_STATS_GB(stst->iface.rcv_discards, stats->rcv_drops,
+   UPDATE_STATS_GB(stst->iface.rcv_discards,
+   IOMEM_GET_FIELD64(stats,