Re: [PATCH 2/3] [v3] kselftest: add support for skipped tests

2021-02-12 Thread Petr Mladek
On Wed 2021-02-10 15:34:52, Timur Tabi wrote:
> Update the kselftest framework to allow client drivers to
> specify that some tests were skipped.
> 
> Signed-off-by: Timur Tabi 

Reviewed-by: Petr Mladek 
Tested-by: Petr Mladek 

Best Regards,
Petr


[PATCH 2/3] [v3] kselftest: add support for skipped tests

2021-02-10 Thread Timur Tabi
Update the kselftest framework to allow client drivers to
specify that some tests were skipped.

Signed-off-by: Timur Tabi 
---
 tools/testing/selftests/kselftest_module.h | 18 --
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/tools/testing/selftests/kselftest_module.h 
b/tools/testing/selftests/kselftest_module.h
index e8eafaf0941a..e2ea41de3f35 100644
--- a/tools/testing/selftests/kselftest_module.h
+++ b/tools/testing/selftests/kselftest_module.h
@@ -11,7 +11,8 @@
 
 #define KSTM_MODULE_GLOBALS()  \
 static unsigned int total_tests __initdata;\
-static unsigned int failed_tests __initdata
+static unsigned int failed_tests __initdata;   \
+static unsigned int skipped_tests __initdata
 
 #define KSTM_CHECK_ZERO(x) do {
\
total_tests++;  \
@@ -21,11 +22,16 @@ static unsigned int failed_tests __initdata
}   \
 } while (0)
 
-static inline int kstm_report(unsigned int total_tests, unsigned int 
failed_tests)
+static inline int kstm_report(unsigned int total_tests, unsigned int 
failed_tests,
+ unsigned int skipped_tests)
 {
-   if (failed_tests == 0)
-   pr_info("all %u tests passed\n", total_tests);
-   else
+   if (failed_tests == 0) {
+   if (skipped_tests) {
+   pr_info("skipped %u tests\n", skipped_tests);
+   pr_info("remaining %u tests passed\n", total_tests);
+   } else
+   pr_info("all %u tests passed\n", total_tests);
+   } else
pr_warn("failed %u out of %u tests\n", failed_tests, 
total_tests);
 
return failed_tests ? -EINVAL : 0;
@@ -36,7 +42,7 @@ static int __init __module##_init(void)   
\
 {  \
pr_info("loaded.\n");   \
selftest(); \
-   return kstm_report(total_tests, failed_tests);  \
+   return kstm_report(total_tests, failed_tests, skipped_tests);   \
 }  \
 static void __exit __module##_exit(void)   \
 {  \
-- 
2.25.1