Re: [PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names

[Lucas Stach]

Am Montag, den 21.10.2019, 21:04 -0700 schrieb Andrey Smirnov:
> According to Documentation/devicetree/bindings/iio/accel/mma8452.txt,
> the correct interrupt-names are "INT1" and "INT2", so fix them
> accordingly.
> 
> While at it, modify the node to only specify "INT2" since providing
> two interrupts is not necessary or useful (the driver will only use
> one).
> 
> Signed-off-by: Fabio Estevam 
> [andrew.smir...@gmail.com modified the patch to drop INT1]
> Signed-off-by: Andrey Smirnov 

Reviewed-by: Lucas Stach 

> Cc: Fabio Estevam 
> Cc: Chris Healy 
> Cc: Lucas Stach 
> Cc: Shawn Guo 
> Cc: linux-arm-ker...@lists.infradead.org,
> Cc: linux-kernel@vger.kernel.org
> ---
> 
> Original patch from Fabio can be seen here:
> 
> https://lore.kernel.org/linux-arm-kernel/20191010125300.2822-1-feste...@gmail.com/
> 
>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi 
> b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 8d46f7b2722b..a8c86e621b49 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -358,8 +358,8 @@
>   compatible = "fsl,mma8451";
>   reg = <0x1c>;
>   interrupt-parent = <>;
> - interrupt-names = "int1", "int2";
> - interrupts = <18 IRQ_TYPE_LEVEL_LOW>, <20 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "INT2";
> + interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
>   };
>  
>   hpa2: amp@60 {
> @@ -849,7 +849,6 @@
>   {
>   pinctrl_accel: accelgrp {
>   fsl,pins = <
> - MX6QDL_PAD_SD1_CMD__GPIO1_IO18  0x4001b000
>   MX6QDL_PAD_SD1_CLK__GPIO1_IO20  0x4001b000
>   >;
>   };

[PATCH 2/3] ARM: dts: imx6qdl-zii-rdu2: Fix accelerometer interrupt-names

[Andrey Smirnov]

According to Documentation/devicetree/bindings/iio/accel/mma8452.txt,
the correct interrupt-names are "INT1" and "INT2", so fix them
accordingly.

While at it, modify the node to only specify "INT2" since providing
two interrupts is not necessary or useful (the driver will only use
one).

Signed-off-by: Fabio Estevam 
[andrew.smir...@gmail.com modified the patch to drop INT1]
Signed-off-by: Andrey Smirnov 
Cc: Fabio Estevam 
Cc: Chris Healy 
Cc: Lucas Stach 
Cc: Shawn Guo 
Cc: linux-arm-ker...@lists.infradead.org,
Cc: linux-kernel@vger.kernel.org
---

Original patch from Fabio can be seen here:

https://lore.kernel.org/linux-arm-kernel/20191010125300.2822-1-feste...@gmail.com/

 arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi 
b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
index 8d46f7b2722b..a8c86e621b49 100644
--- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
@@ -358,8 +358,8 @@
compatible = "fsl,mma8451";
reg = <0x1c>;
interrupt-parent = <>;
-   interrupt-names = "int1", "int2";
-   interrupts = <18 IRQ_TYPE_LEVEL_LOW>, <20 IRQ_TYPE_LEVEL_LOW>;
+   interrupt-names = "INT2";
+   interrupts = <20 IRQ_TYPE_LEVEL_LOW>;
};
 
hpa2: amp@60 {
@@ -849,7 +849,6 @@
  {
pinctrl_accel: accelgrp {
fsl,pins = <
-   MX6QDL_PAD_SD1_CMD__GPIO1_IO18  0x4001b000
MX6QDL_PAD_SD1_CLK__GPIO1_IO20  0x4001b000
>;
};
-- 
2.21.0