Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses

[Michael S. Tsirkin]

On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski 
> 
> Signed-off-by: Maciej Fijalkowski 

This is not a complex value.

> ---
>  drivers/net/virtio_net.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index f20dfb8..6c8170c 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -2663,7 +2663,7 @@ static struct virtio_device_id id_table[] = {
>  };
>  
>  #define VIRTNET_FEATURES \
> - VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
> + (VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
>   VIRTIO_NET_F_MAC, \
>   VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_HOST_TSO6, \
>   VIRTIO_NET_F_HOST_ECN, VIRTIO_NET_F_GUEST_TSO4, 
> VIRTIO_NET_F_GUEST_TSO6, \
> @@ -2672,7 +2672,7 @@ static struct virtio_device_id id_table[] = {
>   VIRTIO_NET_F_CTRL_RX, VIRTIO_NET_F_CTRL_VLAN, \
>   VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, \
>   VIRTIO_NET_F_CTRL_MAC_ADDR, \
> - VIRTIO_NET_F_MTU
> + VIRTIO_NET_F_MTU)
>  
>  static unsigned int features[] = {
>   VIRTNET_FEATURES,
> -- 
> 2.4.11

Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses

[Andrew Lunn]

On Sun, May 14, 2017 at 07:51:29PM +0200, Maciek Fijalkowski wrote:
> From: Maciej Fijalkowski 

Hi Maciek

Please include some commit message, even if it is just the checkpatch
error you are fixing.

Please include the subsystem/driver you are patch in the subject line.
Also, your subject of Fix ERROR: makes it sound a lot worse than it
is. 

net: virtio: Fix checkpatch error Complex macros should use ()

Also, you should at least compile test your change. It is clearly
wrong, as shown by 0-day.

   Andrew

Re: [PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses

[kbuild test robot]

Hi Maciej,

[auto build test ERROR on net-next/master]
[also build test ERROR on v4.12-rc1 next-20170512]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:
https://github.com/0day-ci/linux/commits/Maciek-Fijalkowski/Fix-ERROR-trailing-statements-should-be-on-next-line/20170515-021304
config: x86_64-acpi-redef (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers//net/virtio_net.c:2647:20: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 (VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
   ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2647:45: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 (VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2648:18: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_MAC, \
 ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2649:24: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_HOST_TSO6, \
   ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2649:47: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_HOST_TSO6, \
  ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2649:71: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_HOST_TSO6, \
  ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2650:23: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_HOST_ECN, VIRTIO_NET_F_GUEST_TSO4, VIRTIO_NET_F_GUEST_TSO6, \
  ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2650:48: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_HOST_ECN, VIRTIO_NET_F_GUEST_TSO4, VIRTIO_NET_F_GUEST_TSO6, \
   ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2650:73: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_HOST_ECN, VIRTIO_NET_F_GUEST_TSO4, VIRTIO_NET_F_GUEST_TSO6, \
^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2651:24: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_GUEST_ECN, VIRTIO_NET_F_GUEST_UFO, \
   ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2651:48: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_GUEST_ECN, VIRTIO_NET_F_GUEST_UFO, \
   ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2652:24: warning: left-hand operand of comma 
expression has no effect [-Wunused-value]
 VIRTIO_NET_F_MRG_RXBUF, VIRTIO_NET_F_STATUS, VIRTIO_NET_F_CTRL_VQ, \
   ^
>> drivers//net/virtio_net.c:2659:2: note: in expansion of macro 
>> 'VIRTNET_FEATURES'
 VIRTNET_FEATURES,
 ^~~~
   drivers//net/virtio_net.c:2652:45: warning: left-hand operand of comma 
expression has no effect [-Wun

[PATCH 2/3] Fix ERROR: Macros with complex values should be enclosed in parentheses

[Maciek Fijalkowski]

From: Maciej Fijalkowski 

Signed-off-by: Maciej Fijalkowski 
---
 drivers/net/virtio_net.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index f20dfb8..6c8170c 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -2663,7 +2663,7 @@ static struct virtio_device_id id_table[] = {
 };
 
 #define VIRTNET_FEATURES \
-   VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
+   (VIRTIO_NET_F_CSUM, VIRTIO_NET_F_GUEST_CSUM, \
VIRTIO_NET_F_MAC, \
VIRTIO_NET_F_HOST_TSO4, VIRTIO_NET_F_HOST_UFO, VIRTIO_NET_F_HOST_TSO6, \
VIRTIO_NET_F_HOST_ECN, VIRTIO_NET_F_GUEST_TSO4, 
VIRTIO_NET_F_GUEST_TSO6, \
@@ -2672,7 +2672,7 @@ static struct virtio_device_id id_table[] = {
VIRTIO_NET_F_CTRL_RX, VIRTIO_NET_F_CTRL_VLAN, \
VIRTIO_NET_F_GUEST_ANNOUNCE, VIRTIO_NET_F_MQ, \
VIRTIO_NET_F_CTRL_MAC_ADDR, \
-   VIRTIO_NET_F_MTU
+   VIRTIO_NET_F_MTU)
 
 static unsigned int features[] = {
VIRTNET_FEATURES,
-- 
2.4.11