Re: [PATCH 2/3] perf jevents: Fix period for Intel fixed counters

[Arnaldo Carvalho de Melo]

Em Fri, Sep 27, 2019 at 04:35:45PM -0700, Andi Kleen escreveu:
> From: Andi Kleen 
> 
> The Intel fixed counters use a special table to override the JSON
> information. During this override the period information from
> the JSON file got dropped, which results in inst_retired.any
> and similar running with frequency mode instead of a period.
> Just specify the expected period in the table.

Thanks, applied.

- Arnaldo
 
> Signed-off-by: Andi Kleen 
> ---
>  tools/perf/pmu-events/jevents.c | 12 ++--
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
> index d413761621b0..fa85e33762f7 100644
> --- a/tools/perf/pmu-events/jevents.c
> +++ b/tools/perf/pmu-events/jevents.c
> @@ -449,12 +449,12 @@ static struct fixed {
>   const char *name;
>   const char *event;
>  } fixed[] = {
> - { "inst_retired.any", "event=0xc0" },
> - { "inst_retired.any_p", "event=0xc0" },
> - { "cpu_clk_unhalted.ref", "event=0x0,umask=0x03" },
> - { "cpu_clk_unhalted.thread", "event=0x3c" },
> - { "cpu_clk_unhalted.core", "event=0x3c" },
> - { "cpu_clk_unhalted.thread_any", "event=0x3c,any=1" },
> + { "inst_retired.any", "event=0xc0,period=203" },
> + { "inst_retired.any_p", "event=0xc0,period=203" },
> + { "cpu_clk_unhalted.ref", "event=0x0,umask=0x03,period=203" },
> + { "cpu_clk_unhalted.thread", "event=0x3c,period=203" },
> + { "cpu_clk_unhalted.core", "event=0x3c,period=203" },
> + { "cpu_clk_unhalted.thread_any", "event=0x3c,any=1,period=203" },
>   { NULL, NULL},
>  };
>  
> -- 
> 2.21.0

-- 

- Arnaldo

[PATCH 2/3] perf jevents: Fix period for Intel fixed counters

[Andi Kleen]

From: Andi Kleen 

The Intel fixed counters use a special table to override the JSON
information. During this override the period information from
the JSON file got dropped, which results in inst_retired.any
and similar running with frequency mode instead of a period.
Just specify the expected period in the table.

Signed-off-by: Andi Kleen 
---
 tools/perf/pmu-events/jevents.c | 12 ++--
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c
index d413761621b0..fa85e33762f7 100644
--- a/tools/perf/pmu-events/jevents.c
+++ b/tools/perf/pmu-events/jevents.c
@@ -449,12 +449,12 @@ static struct fixed {
const char *name;
const char *event;
 } fixed[] = {
-   { "inst_retired.any", "event=0xc0" },
-   { "inst_retired.any_p", "event=0xc0" },
-   { "cpu_clk_unhalted.ref", "event=0x0,umask=0x03" },
-   { "cpu_clk_unhalted.thread", "event=0x3c" },
-   { "cpu_clk_unhalted.core", "event=0x3c" },
-   { "cpu_clk_unhalted.thread_any", "event=0x3c,any=1" },
+   { "inst_retired.any", "event=0xc0,period=203" },
+   { "inst_retired.any_p", "event=0xc0,period=203" },
+   { "cpu_clk_unhalted.ref", "event=0x0,umask=0x03,period=203" },
+   { "cpu_clk_unhalted.thread", "event=0x3c,period=203" },
+   { "cpu_clk_unhalted.core", "event=0x3c,period=203" },
+   { "cpu_clk_unhalted.thread_any", "event=0x3c,any=1,period=203" },
{ NULL, NULL},
 };
 
-- 
2.21.0