Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag
> "Sitsofe" == Sitsofe Wheeler writes: >> Last time around we identified this as a problem with Microsoft's >> interpretation of the T10 SBC spec. And they promised that they are >> going to fix that. Sitsofe> OK but if we were happy to wait for Microsoft to fix the Sitsofe> problem on the host why were the (broken and incomplete) Sitsofe> BLIST_SKIP_VPD_PAGES patches committed to 3.17 rather than Sitsofe> withdrawn? What's going to be done about those patches now? There are two orthogonal problems. One being that the driver advertised conformance to an old SCSI spec. That's being addressed with the separate SPC-3 patch. The other issue is that thin provisioning is being incorrectly advertised. Because that's being addressed by Microsoft and is an isolated use case I'm hesitant to add quirk for it. Whereas I know several other devices that will benefit from the TRY_VPD_PAGES blacklist option. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag
Sitsofe == Sitsofe Wheeler sits...@gmail.com writes: Last time around we identified this as a problem with Microsoft's interpretation of the T10 SBC spec. And they promised that they are going to fix that. Sitsofe OK but if we were happy to wait for Microsoft to fix the Sitsofe problem on the host why were the (broken and incomplete) Sitsofe BLIST_SKIP_VPD_PAGES patches committed to 3.17 rather than Sitsofe withdrawn? What's going to be done about those patches now? There are two orthogonal problems. One being that the driver advertised conformance to an old SCSI spec. That's being addressed with the separate SPC-3 patch. The other issue is that thin provisioning is being incorrectly advertised. Because that's being addressed by Microsoft and is an isolated use case I'm hesitant to add quirk for it. Whereas I know several other devices that will benefit from the TRY_VPD_PAGES blacklist option. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag
On Tue, Oct 14, 2014 at 09:08:28PM -0400, Martin K. Petersen wrote: > > "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> Microsoft Hyper-V virtual disks currently only claim SPC-2 > Sitsofe> compliance causing the kernel skip checks for features such as > Sitsofe> thin provisioning even though the virtual disk advertises them. > > Last time around we identified this as a problem with Microsoft's > interpretation of the T10 SBC spec. And they promised that they are > going to fix that. OK but if we were happy to wait for Microsoft to fix the problem on the host why were the (broken and incomplete) BLIST_SKIP_VPD_PAGES patches committed to 3.17 rather than withdrawn? What's going to be done about those patches now? -- Sitsofe | http://sucs.org/~sits/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag
On Tue, Oct 14, 2014 at 09:08:28PM -0400, Martin K. Petersen wrote: Sitsofe == Sitsofe Wheeler sits...@gmail.com writes: Sitsofe Microsoft Hyper-V virtual disks currently only claim SPC-2 Sitsofe compliance causing the kernel skip checks for features such as Sitsofe thin provisioning even though the virtual disk advertises them. Last time around we identified this as a problem with Microsoft's interpretation of the T10 SBC spec. And they promised that they are going to fix that. OK but if we were happy to wait for Microsoft to fix the problem on the host why were the (broken and incomplete) BLIST_SKIP_VPD_PAGES patches committed to 3.17 rather than withdrawn? What's going to be done about those patches now? -- Sitsofe | http://sucs.org/~sits/ -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/3] scsi: add try_rc16 blacklist flag
> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Tuesday, October 14, 2014 6:08 PM > To: Sitsofe Wheeler > Cc: KY Srinivasan; Haiyang Zhang; Christoph Hellwig; Hannes Reinecke; linux- > s...@vger.kernel.org; linux-kernel@vger.kernel.org; > de...@linuxdriverproject.org; James E.J. Bottomley > Subject: Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag > > >>>>> "Sitsofe" == Sitsofe Wheeler writes: > > Sitsofe> Microsoft Hyper-V virtual disks currently only claim SPC-2 > Sitsofe> compliance causing the kernel skip checks for features such as > Sitsofe> thin provisioning even though the virtual disk advertises them. > > Last time around we identified this as a problem with Microsoft's > interpretation of the T10 SBC spec. And they promised that they are going to > fix that. It has been fixed in windows 10 and a bug has been opened for earlier hosts. K. Y > > -- > Martin K. PetersenOracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag
> "Sitsofe" == Sitsofe Wheeler writes: Sitsofe> Microsoft Hyper-V virtual disks currently only claim SPC-2 Sitsofe> compliance causing the kernel skip checks for features such as Sitsofe> thin provisioning even though the virtual disk advertises them. Last time around we identified this as a problem with Microsoft's interpretation of the T10 SBC spec. And they promised that they are going to fix that. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag
Sitsofe == Sitsofe Wheeler sits...@gmail.com writes: Sitsofe Microsoft Hyper-V virtual disks currently only claim SPC-2 Sitsofe compliance causing the kernel skip checks for features such as Sitsofe thin provisioning even though the virtual disk advertises them. Last time around we identified this as a problem with Microsoft's interpretation of the T10 SBC spec. And they promised that they are going to fix that. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 2/3] scsi: add try_rc16 blacklist flag
-Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Tuesday, October 14, 2014 6:08 PM To: Sitsofe Wheeler Cc: KY Srinivasan; Haiyang Zhang; Christoph Hellwig; Hannes Reinecke; linux- s...@vger.kernel.org; linux-kernel@vger.kernel.org; de...@linuxdriverproject.org; James E.J. Bottomley Subject: Re: [PATCH 2/3] scsi: add try_rc16 blacklist flag Sitsofe == Sitsofe Wheeler sits...@gmail.com writes: Sitsofe Microsoft Hyper-V virtual disks currently only claim SPC-2 Sitsofe compliance causing the kernel skip checks for features such as Sitsofe thin provisioning even though the virtual disk advertises them. Last time around we identified this as a problem with Microsoft's interpretation of the T10 SBC spec. And they promised that they are going to fix that. It has been fixed in windows 10 and a bug has been opened for earlier hosts. K. Y -- Martin K. PetersenOracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/3] scsi: add try_rc16 blacklist flag
Microsoft Hyper-V virtual disks currently only claim SPC-2 compliance causing
the kernel skip checks for features such as thin provisioning even though the
virtual disk advertises them.
Add a blacklist flag that can allow such devices to quirk past READ
CAPACITY(16) guards.
Signed-off-by: Sitsofe Wheeler
---
drivers/scsi/scsi_scan.c| 3 +++
drivers/scsi/sd.c | 3 +++
include/scsi/scsi_device.h | 1 +
include/scsi/scsi_devinfo.h | 1 +
4 files changed, 8 insertions(+)
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index ba3f1e8..d3f6267 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -962,6 +962,9 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned
char *inq_result,
else if (*bflags & BLIST_SKIP_VPD_PAGES)
sdev->skip_vpd_pages = 1;
+ if (*bflags & BLIST_TRY_RC16)
+ sdev->try_rc16 = 1;
+
transport_configure_device(>sdev_gendev);
if (sdev->host->hostt->slave_configure) {
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 0cb5c9f..0ccf372 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2143,6 +2143,9 @@ static int sd_try_rc16_first(struct scsi_device *sdp)
return 0;
if (sdp->scsi_level > SCSI_SPC_2)
return 1;
+ if (sdp->try_rc16) {
+ return 1;
+ }
if (scsi_device_protection(sdp))
return 1;
return 0;
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 27ecee7..d6e2bd8 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -155,6 +155,7 @@ struct scsi_device {
unsigned skip_ms_page_3f:1; /* do not use MODE SENSE page 0x3f */
unsigned skip_vpd_pages:1; /* do not read VPD pages */
unsigned try_vpd_pages:1; /* attempt to read VPD pages */
+ unsigned try_rc16:1;/* attempt READ CAPACITY(16) */
unsigned use_192_bytes_for_3f:1; /* ask for 192 bytes from page 0x3f */
unsigned no_start_on_add:1; /* do not issue start on add */
unsigned allow_restart:1; /* issue START_UNIT in error handler */
diff --git a/include/scsi/scsi_devinfo.h b/include/scsi/scsi_devinfo.h
index 183eaab..9431f5e 100644
--- a/include/scsi/scsi_devinfo.h
+++ b/include/scsi/scsi_devinfo.h
@@ -36,5 +36,6 @@
for sequential scan */
#define BLIST_TRY_VPD_PAGES0x1000 /* Attempt to read VPD pages */
#define BLIST_NO_RSOC 0x2000 /* don't try to issue RSOC */
+#define BLIST_TRY_RC16 0x4000 /* Attempt READ CAPACITY(16) */
#endif
--
1.9.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/3] scsi: add try_rc16 blacklist flag
Microsoft Hyper-V virtual disks currently only claim SPC-2 compliance causing
the kernel skip checks for features such as thin provisioning even though the
virtual disk advertises them.
Add a blacklist flag that can allow such devices to quirk past READ
CAPACITY(16) guards.
Signed-off-by: Sitsofe Wheeler sits...@yahoo.com
---
drivers/scsi/scsi_scan.c| 3 +++
drivers/scsi/sd.c | 3 +++
include/scsi/scsi_device.h | 1 +
include/scsi/scsi_devinfo.h | 1 +
4 files changed, 8 insertions(+)
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index ba3f1e8..d3f6267 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -962,6 +962,9 @@ static int scsi_add_lun(struct scsi_device *sdev, unsigned
char *inq_result,
else if (*bflags BLIST_SKIP_VPD_PAGES)
sdev-skip_vpd_pages = 1;
+ if (*bflags BLIST_TRY_RC16)
+ sdev-try_rc16 = 1;
+
transport_configure_device(sdev-sdev_gendev);
if (sdev-host-hostt-slave_configure) {
diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
index 0cb5c9f..0ccf372 100644
--- a/drivers/scsi/sd.c
+++ b/drivers/scsi/sd.c
@@ -2143,6 +2143,9 @@ static int sd_try_rc16_first(struct scsi_device *sdp)
return 0;
if (sdp-scsi_level SCSI_SPC_2)
return 1;
+ if (sdp-try_rc16) {
+ return 1;
+ }
if (scsi_device_protection(sdp))
return 1;
return 0;
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 27ecee7..d6e2bd8 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -155,6 +155,7 @@ struct scsi_device {
unsigned skip_ms_page_3f:1; /* do not use MODE SENSE page 0x3f */
unsigned skip_vpd_pages:1; /* do not read VPD pages */
unsigned try_vpd_pages:1; /* attempt to read VPD pages */
+ unsigned try_rc16:1;/* attempt READ CAPACITY(16) */
unsigned use_192_bytes_for_3f:1; /* ask for 192 bytes from page 0x3f */
unsigned no_start_on_add:1; /* do not issue start on add */
unsigned allow_restart:1; /* issue START_UNIT in error handler */
diff --git a/include/scsi/scsi_devinfo.h b/include/scsi/scsi_devinfo.h
index 183eaab..9431f5e 100644
--- a/include/scsi/scsi_devinfo.h
+++ b/include/scsi/scsi_devinfo.h
@@ -36,5 +36,6 @@
for sequential scan */
#define BLIST_TRY_VPD_PAGES0x1000 /* Attempt to read VPD pages */
#define BLIST_NO_RSOC 0x2000 /* don't try to issue RSOC */
+#define BLIST_TRY_RC16 0x4000 /* Attempt READ CAPACITY(16) */
#endif
--
1.9.3
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
