Re: [PATCH 2/3] toshiba_acpi: Fix typos in pr_* messages from USB Fleep Functions

2015-03-29 Thread Azael Avalos 
Hi Darren,

2015-03-27 20:58 GMT-06:00 Darren Hart :
> On Fri, Mar 27, 2015 at 03:09:25PM -0600, Azael Avalos wrote:
>> This patch fixes typos in the pr_* messages from the USB Sleep
>> Functions.
>>
>> Signed-off-by: Azael Avalos 
>> ---
>>  drivers/platform/x86/toshiba_acpi.c | 16 
>>  1 file changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/platform/x86/toshiba_acpi.c 
>> b/drivers/platform/x86/toshiba_acpi.c
>> index 595f12c..3bb456c 100644
>> --- a/drivers/platform/x86/toshiba_acpi.c
>> +++ b/drivers/platform/x86/toshiba_acpi.c
>> @@ -955,11 +955,11 @@ static int toshiba_usb_rapid_charge_get(struct 
>> toshiba_acpi_dev *dev,
>>   status = tci_raw(dev, in, out);
>>   sci_close(dev);
>>   if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) {
>> - pr_err("ACPI call to get USB S battery level failed\n");
>> + pr_err("ACPI call to get USB Rapid Charge failed\n");
>>   return -EIO;
>>   } else if (out[0] == TOS_NOT_SUPPORTED ||
>>  out[0] == TOS_INPUT_DATA_ERROR) {
>> - pr_info("USB Sleep and Charge not supported\n");
>> + pr_info("USB Rapid Charge not supported\n");
>
> This is a name change, not a typo fix. You added a comment in 1/3 using Sleep
> and Charge, should this patch perhaps come first?
>
> Or... hrm... this is using the correct name for each state, and 1/3 added 
> Sleep
> and Charge to the correct one... right, probably just need a better commit
> message. Not a type, but fixing the messages reporting the wrong states.

Ok, will change in v2 and resend in a few minutes.

>
> --
> Darren Hart
> Intel Open Source Technology Center


Cheers
Azael


-- 
-- El mundo apesta y vosotros apestais tambien --
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/3] toshiba_acpi: Fix typos in pr_* messages from USB Fleep Functions

2015-03-29 Thread Azael Avalos 
Hi Darren,

2015-03-27 20:58 GMT-06:00 Darren Hart dvh...@infradead.org:
 On Fri, Mar 27, 2015 at 03:09:25PM -0600, Azael Avalos wrote:
 This patch fixes typos in the pr_* messages from the USB Sleep
 Functions.

 Signed-off-by: Azael Avalos coproscef...@gmail.com
 ---
  drivers/platform/x86/toshiba_acpi.c | 16 
  1 file changed, 8 insertions(+), 8 deletions(-)

 diff --git a/drivers/platform/x86/toshiba_acpi.c 
 b/drivers/platform/x86/toshiba_acpi.c
 index 595f12c..3bb456c 100644
 --- a/drivers/platform/x86/toshiba_acpi.c
 +++ b/drivers/platform/x86/toshiba_acpi.c
 @@ -955,11 +955,11 @@ static int toshiba_usb_rapid_charge_get(struct 
 toshiba_acpi_dev *dev,
   status = tci_raw(dev, in, out);
   sci_close(dev);
   if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) {
 - pr_err(ACPI call to get USB SC battery level failed\n);
 + pr_err(ACPI call to get USB Rapid Charge failed\n);
   return -EIO;
   } else if (out[0] == TOS_NOT_SUPPORTED ||
  out[0] == TOS_INPUT_DATA_ERROR) {
 - pr_info(USB Sleep and Charge not supported\n);
 + pr_info(USB Rapid Charge not supported\n);

 This is a name change, not a typo fix. You added a comment in 1/3 using Sleep
 and Charge, should this patch perhaps come first?

 Or... hrm... this is using the correct name for each state, and 1/3 added 
 Sleep
 and Charge to the correct one... right, probably just need a better commit
 message. Not a type, but fixing the messages reporting the wrong states.

Ok, will change in v2 and resend in a few minutes.


 --
 Darren Hart
 Intel Open Source Technology Center


Cheers
Azael


-- 
-- El mundo apesta y vosotros apestais tambien --
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/3] toshiba_acpi: Fix typos in pr_* messages from USB Fleep Functions

2015-03-27 Thread Darren Hart 
On Fri, Mar 27, 2015 at 03:09:25PM -0600, Azael Avalos wrote:
> This patch fixes typos in the pr_* messages from the USB Sleep
> Functions.
> 
> Signed-off-by: Azael Avalos 
> ---
>  drivers/platform/x86/toshiba_acpi.c | 16 
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/platform/x86/toshiba_acpi.c 
> b/drivers/platform/x86/toshiba_acpi.c
> index 595f12c..3bb456c 100644
> --- a/drivers/platform/x86/toshiba_acpi.c
> +++ b/drivers/platform/x86/toshiba_acpi.c
> @@ -955,11 +955,11 @@ static int toshiba_usb_rapid_charge_get(struct 
> toshiba_acpi_dev *dev,
>   status = tci_raw(dev, in, out);
>   sci_close(dev);
>   if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) {
> - pr_err("ACPI call to get USB S battery level failed\n");
> + pr_err("ACPI call to get USB Rapid Charge failed\n");
>   return -EIO;
>   } else if (out[0] == TOS_NOT_SUPPORTED ||
>  out[0] == TOS_INPUT_DATA_ERROR) {
> - pr_info("USB Sleep and Charge not supported\n");
> + pr_info("USB Rapid Charge not supported\n");

This is a name change, not a typo fix. You added a comment in 1/3 using Sleep
and Charge, should this patch perhaps come first?

Or... hrm... this is using the correct name for each state, and 1/3 added Sleep
and Charge to the correct one... right, probably just need a better commit
message. Not a type, but fixing the messages reporting the wrong states.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/3] toshiba_acpi: Fix typos in pr_* messages from USB Fleep Functions

2015-03-27 Thread Azael Avalos 
This patch fixes typos in the pr_* messages from the USB Sleep
Functions.

Signed-off-by: Azael Avalos 
---
 drivers/platform/x86/toshiba_acpi.c | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/platform/x86/toshiba_acpi.c 
b/drivers/platform/x86/toshiba_acpi.c
index 595f12c..3bb456c 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -955,11 +955,11 @@ static int toshiba_usb_rapid_charge_get(struct 
toshiba_acpi_dev *dev,
status = tci_raw(dev, in, out);
sci_close(dev);
if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) {
-   pr_err("ACPI call to get USB S battery level failed\n");
+   pr_err("ACPI call to get USB Rapid Charge failed\n");
return -EIO;
} else if (out[0] == TOS_NOT_SUPPORTED ||
   out[0] == TOS_INPUT_DATA_ERROR) {
-   pr_info("USB Sleep and Charge not supported\n");
+   pr_info("USB Rapid Charge not supported\n");
return -ENODEV;
}
 
@@ -983,10 +983,10 @@ static int toshiba_usb_rapid_charge_set(struct 
toshiba_acpi_dev *dev,
status = tci_raw(dev, in, out);
sci_close(dev);
if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) {
-   pr_err("ACPI call to set USB S battery level failed\n");
+   pr_err("ACPI call to set USB Rapid Charge failed\n");
return -EIO;
} else if (out[0] == TOS_NOT_SUPPORTED) {
-   pr_info("USB Sleep and Charge not supported\n");
+   pr_info("USB Rapid Charge not supported\n");
return -ENODEV;
} else if (out[0] == TOS_INPUT_DATA_ERROR) {
return -EIO;
@@ -1005,10 +1005,10 @@ static int toshiba_usb_sleep_music_get(struct 
toshiba_acpi_dev *dev, u32 *state)
result = sci_read(dev, SCI_USB_SLEEP_MUSIC, state);
sci_close(dev);
if (result == TOS_FAILURE) {
-   pr_err("ACPI call to set USB S mode failed\n");
+   pr_err("ACPI call to set Sleep and Music mode failed\n");
return -EIO;
} else if (result == TOS_NOT_SUPPORTED) {
-   pr_info("USB Sleep and Charge not supported\n");
+   pr_info("Sleep and Music not supported\n");
return -ENODEV;
} else if (result == TOS_INPUT_DATA_ERROR) {
return -EIO;
@@ -1027,10 +1027,10 @@ static int toshiba_usb_sleep_music_set(struct 
toshiba_acpi_dev *dev, u32 state)
result = sci_write(dev, SCI_USB_SLEEP_MUSIC, state);
sci_close(dev);
if (result == TOS_FAILURE) {
-   pr_err("ACPI call to set USB S mode failed\n");
+   pr_err("ACPI call to set Sleep and Music mode failed\n");
return -EIO;
} else if (result == TOS_NOT_SUPPORTED) {
-   pr_info("USB Sleep and Charge not supported\n");
+   pr_info("Sleep and Music not supported\n");
return -ENODEV;
} else if (result == TOS_INPUT_DATA_ERROR) {
return -EIO;
-- 
2.2.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2/3] toshiba_acpi: Fix typos in pr_* messages from USB Fleep Functions

2015-03-27 Thread Azael Avalos 
This patch fixes typos in the pr_* messages from the USB Sleep
Functions.

Signed-off-by: Azael Avalos coproscef...@gmail.com
---
 drivers/platform/x86/toshiba_acpi.c | 16 
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/platform/x86/toshiba_acpi.c 
b/drivers/platform/x86/toshiba_acpi.c
index 595f12c..3bb456c 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -955,11 +955,11 @@ static int toshiba_usb_rapid_charge_get(struct 
toshiba_acpi_dev *dev,
status = tci_raw(dev, in, out);
sci_close(dev);
if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) {
-   pr_err(ACPI call to get USB SC battery level failed\n);
+   pr_err(ACPI call to get USB Rapid Charge failed\n);
return -EIO;
} else if (out[0] == TOS_NOT_SUPPORTED ||
   out[0] == TOS_INPUT_DATA_ERROR) {
-   pr_info(USB Sleep and Charge not supported\n);
+   pr_info(USB Rapid Charge not supported\n);
return -ENODEV;
}
 
@@ -983,10 +983,10 @@ static int toshiba_usb_rapid_charge_set(struct 
toshiba_acpi_dev *dev,
status = tci_raw(dev, in, out);
sci_close(dev);
if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) {
-   pr_err(ACPI call to set USB SC battery level failed\n);
+   pr_err(ACPI call to set USB Rapid Charge failed\n);
return -EIO;
} else if (out[0] == TOS_NOT_SUPPORTED) {
-   pr_info(USB Sleep and Charge not supported\n);
+   pr_info(USB Rapid Charge not supported\n);
return -ENODEV;
} else if (out[0] == TOS_INPUT_DATA_ERROR) {
return -EIO;
@@ -1005,10 +1005,10 @@ static int toshiba_usb_sleep_music_get(struct 
toshiba_acpi_dev *dev, u32 *state)
result = sci_read(dev, SCI_USB_SLEEP_MUSIC, state);
sci_close(dev);
if (result == TOS_FAILURE) {
-   pr_err(ACPI call to set USB SC mode failed\n);
+   pr_err(ACPI call to set Sleep and Music mode failed\n);
return -EIO;
} else if (result == TOS_NOT_SUPPORTED) {
-   pr_info(USB Sleep and Charge not supported\n);
+   pr_info(Sleep and Music not supported\n);
return -ENODEV;
} else if (result == TOS_INPUT_DATA_ERROR) {
return -EIO;
@@ -1027,10 +1027,10 @@ static int toshiba_usb_sleep_music_set(struct 
toshiba_acpi_dev *dev, u32 state)
result = sci_write(dev, SCI_USB_SLEEP_MUSIC, state);
sci_close(dev);
if (result == TOS_FAILURE) {
-   pr_err(ACPI call to set USB SC mode failed\n);
+   pr_err(ACPI call to set Sleep and Music mode failed\n);
return -EIO;
} else if (result == TOS_NOT_SUPPORTED) {
-   pr_info(USB Sleep and Charge not supported\n);
+   pr_info(Sleep and Music not supported\n);
return -ENODEV;
} else if (result == TOS_INPUT_DATA_ERROR) {
return -EIO;
-- 
2.2.2

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2/3] toshiba_acpi: Fix typos in pr_* messages from USB Fleep Functions

2015-03-27 Thread Darren Hart 
On Fri, Mar 27, 2015 at 03:09:25PM -0600, Azael Avalos wrote:
 This patch fixes typos in the pr_* messages from the USB Sleep
 Functions.
 
 Signed-off-by: Azael Avalos coproscef...@gmail.com
 ---
  drivers/platform/x86/toshiba_acpi.c | 16 
  1 file changed, 8 insertions(+), 8 deletions(-)
 
 diff --git a/drivers/platform/x86/toshiba_acpi.c 
 b/drivers/platform/x86/toshiba_acpi.c
 index 595f12c..3bb456c 100644
 --- a/drivers/platform/x86/toshiba_acpi.c
 +++ b/drivers/platform/x86/toshiba_acpi.c
 @@ -955,11 +955,11 @@ static int toshiba_usb_rapid_charge_get(struct 
 toshiba_acpi_dev *dev,
   status = tci_raw(dev, in, out);
   sci_close(dev);
   if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) {
 - pr_err(ACPI call to get USB SC battery level failed\n);
 + pr_err(ACPI call to get USB Rapid Charge failed\n);
   return -EIO;
   } else if (out[0] == TOS_NOT_SUPPORTED ||
  out[0] == TOS_INPUT_DATA_ERROR) {
 - pr_info(USB Sleep and Charge not supported\n);
 + pr_info(USB Rapid Charge not supported\n);

This is a name change, not a typo fix. You added a comment in 1/3 using Sleep
and Charge, should this patch perhaps come first?

Or... hrm... this is using the correct name for each state, and 1/3 added Sleep
and Charge to the correct one... right, probably just need a better commit
message. Not a type, but fixing the messages reporting the wrong states.

-- 
Darren Hart
Intel Open Source Technology Center
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/