Re: [PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()

[David Hildenbrand]

On 07.09.19 23:47, Souptick Joarder wrote:
> __online_page_set_limits() is a dummy function and an extra call
> to this function can be avoided.
> 
> Signed-off-by: Souptick Joarder 
> ---
>  drivers/xen/balloon.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
> index 4e11de6..05b1f7e 100644
> --- a/drivers/xen/balloon.c
> +++ b/drivers/xen/balloon.c
> @@ -376,7 +376,6 @@ static void xen_online_page(struct page *page, unsigned 
> int order)
>   mutex_lock(_mutex);
>   for (i = 0; i < size; i++) {
>   p = pfn_to_page(start_pfn + i);
> - __online_page_set_limits(p);
>   __SetPageOffline(p);
>   __balloon_append(p);
>   }
> 

Reviewed-by: David Hildenbrand 

-- 

Thanks,

David / dhildenb

Re: [PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()

[Juergen Gross]

On 07.09.19 23:47, Souptick Joarder wrote:

__online_page_set_limits() is a dummy function and an extra call
to this function can be avoided.

Signed-off-by: Souptick Joarder 


Reviewed-by: Juergen Gross 


Juergen

[PATCH 2/3] xen/ballon: Avoid calling dummy function __online_page_set_limits()

[Souptick Joarder]

__online_page_set_limits() is a dummy function and an extra call
to this function can be avoided.

Signed-off-by: Souptick Joarder 
---
 drivers/xen/balloon.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
index 4e11de6..05b1f7e 100644
--- a/drivers/xen/balloon.c
+++ b/drivers/xen/balloon.c
@@ -376,7 +376,6 @@ static void xen_online_page(struct page *page, unsigned int 
order)
mutex_lock(_mutex);
for (i = 0; i < size; i++) {
p = pfn_to_page(start_pfn + i);
-   __online_page_set_limits(p);
__SetPageOffline(p);
__balloon_append(p);
}
-- 
1.9.1