Re: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver
On 11/06/2014 07:50 AM, Alexander Graf wrote: [cut] +++ b/drivers/bus/fsl-mc/Kconfig @@ -0,0 +1,13 @@ +# +# Freescale Management Complex (MC) bus drivers +# +# Copyright (C) 2014 Freescale Semiconductor, Inc. +# +# This file is released under the GPLv2 +# + +config FSL_MC_BUS + tristate "Freescale Management Complex (MC) bus driver" + help + Driver to enable the bus infrastructure for the Freescale + QorIQ Management Complex. Isn't this missing some scope limitations? Should we really have the driver enabled on x86 for example? I will add depends on OF && ARM64 I would also make this slightly more verbose. People don't necessarily know what the QorIQ Management Complex is. Give people some idea what they're dealing with and preferably tell them hints that guide them from "SoC name" to "should I enable this option?". Also, usually the help text gives some guidance on what to do with the option if you're not sure. In this case, I would say advise the user to say N. Will do. Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver
On 11/06/2014 07:50 AM, Alexander Graf wrote: [cut] +++ b/drivers/bus/fsl-mc/Kconfig @@ -0,0 +1,13 @@ +# +# Freescale Management Complex (MC) bus drivers +# +# Copyright (C) 2014 Freescale Semiconductor, Inc. +# +# This file is released under the GPLv2 +# + +config FSL_MC_BUS + tristate Freescale Management Complex (MC) bus driver + help + Driver to enable the bus infrastructure for the Freescale + QorIQ Management Complex. Isn't this missing some scope limitations? Should we really have the driver enabled on x86 for example? I will add depends on OF ARM64 I would also make this slightly more verbose. People don't necessarily know what the QorIQ Management Complex is. Give people some idea what they're dealing with and preferably tell them hints that guide them from SoC name to should I enable this option?. Also, usually the help text gives some guidance on what to do with the option if you're not sure. In this case, I would say advise the user to say N. Will do. Alex -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver
On 04.10.14 15:23, J. German Rivera wrote: > From: "J. German Rivera" > > Platform device driver that sets up the basic bus infrastructure > for the fsl-mc bus type, including support for adding/removing > fsl-mc devices, register/unregister of fsl-mc drivers, and bus > match support to bind devices to drivers. > > Signed-off-by: J. German Rivera > Signed-off-by: Stuart Yoder > --- > Changes in v3: > - Addressed changes from Kim Phillips: > * Renamed files: > drivers/bus/fsl-mc/fsl_mc_bus.c -> drivers/bus/fsl-mc/mc-bus.c > include/linux/fsl_mc.h -> include/linux/fsl/mc.h > include/linux/fsl_mc_private.h -> include/linux/fsl/mc-private.h > > - Addressed comments from Timur Tabi: > * Changed all functions that had goto out/error when no common cleanup > was done, to just have multiple return points. > * Replaced error cleanup boolean flags with multiple exit points. > > Changes in v2: > - Addressed comment from Joe Perches: > * Changed pr_debug to dev_dbg in fsl_mc_bus_match > > - Addressed comments from Kim Phillips and Alex Graf: > * Changed version check to allow the driver to run with MC > firmware that has major version number greater than or equal > to the driver's major version number. > * Removed minor version check > > - Removed unused variable parent_dev in fsl_mc_device_remove > > drivers/bus/Kconfig|3 + > drivers/bus/Makefile |3 + > drivers/bus/fsl-mc/Kconfig | 13 + > drivers/bus/fsl-mc/Makefile| 14 + > drivers/bus/fsl-mc/mc-bus.c| 566 > > include/linux/fsl/mc-private.h | 33 +++ > include/linux/fsl/mc.h | 137 ++ > 7 files changed, 769 insertions(+) > create mode 100644 drivers/bus/fsl-mc/Kconfig > create mode 100644 drivers/bus/fsl-mc/Makefile > create mode 100644 drivers/bus/fsl-mc/mc-bus.c > create mode 100644 include/linux/fsl/mc-private.h > create mode 100644 include/linux/fsl/mc.h > > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig > index 603eb1b..2fbb1fd 100644 > --- a/drivers/bus/Kconfig > +++ b/drivers/bus/Kconfig > @@ -67,4 +67,7 @@ config VEXPRESS_CONFIG > help > Platform configuration infrastructure for the ARM Ltd. > Versatile Express. > + > +source "drivers/bus/fsl-mc/Kconfig" > + > endmenu > diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile > index 2973c18..6abcab1 100644 > --- a/drivers/bus/Makefile > +++ b/drivers/bus/Makefile > @@ -15,3 +15,6 @@ obj-$(CONFIG_ARM_CCI) += arm-cci.o > obj-$(CONFIG_ARM_CCN)+= arm-ccn.o > > obj-$(CONFIG_VEXPRESS_CONFIG)+= vexpress-config.o > + > +# Freescale Management Complex (MC) bus drivers > +obj-$(CONFIG_FSL_MC_BUS) += fsl-mc/ > diff --git a/drivers/bus/fsl-mc/Kconfig b/drivers/bus/fsl-mc/Kconfig > new file mode 100644 > index 000..e3226f9 > --- /dev/null > +++ b/drivers/bus/fsl-mc/Kconfig > @@ -0,0 +1,13 @@ > +# > +# Freescale Management Complex (MC) bus drivers > +# > +# Copyright (C) 2014 Freescale Semiconductor, Inc. > +# > +# This file is released under the GPLv2 > +# > + > +config FSL_MC_BUS > + tristate "Freescale Management Complex (MC) bus driver" > + help > + Driver to enable the bus infrastructure for the Freescale > + QorIQ Management Complex. Isn't this missing some scope limitations? Should we really have the driver enabled on x86 for example? I would also make this slightly more verbose. People don't necessarily know what the QorIQ Management Complex is. Give people some idea what they're dealing with and preferably tell them hints that guide them from "SoC name" to "should I enable this option?". Also, usually the help text gives some guidance on what to do with the option if you're not sure. In this case, I would say advise the user to say N. Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver
On 04.10.14 15:23, J. German Rivera wrote: From: J. German Rivera german.riv...@freescale.com Platform device driver that sets up the basic bus infrastructure for the fsl-mc bus type, including support for adding/removing fsl-mc devices, register/unregister of fsl-mc drivers, and bus match support to bind devices to drivers. Signed-off-by: J. German Rivera german.riv...@freescale.com Signed-off-by: Stuart Yoder stuart.yo...@freescale.com --- Changes in v3: - Addressed changes from Kim Phillips: * Renamed files: drivers/bus/fsl-mc/fsl_mc_bus.c - drivers/bus/fsl-mc/mc-bus.c include/linux/fsl_mc.h - include/linux/fsl/mc.h include/linux/fsl_mc_private.h - include/linux/fsl/mc-private.h - Addressed comments from Timur Tabi: * Changed all functions that had goto out/error when no common cleanup was done, to just have multiple return points. * Replaced error cleanup boolean flags with multiple exit points. Changes in v2: - Addressed comment from Joe Perches: * Changed pr_debug to dev_dbg in fsl_mc_bus_match - Addressed comments from Kim Phillips and Alex Graf: * Changed version check to allow the driver to run with MC firmware that has major version number greater than or equal to the driver's major version number. * Removed minor version check - Removed unused variable parent_dev in fsl_mc_device_remove drivers/bus/Kconfig|3 + drivers/bus/Makefile |3 + drivers/bus/fsl-mc/Kconfig | 13 + drivers/bus/fsl-mc/Makefile| 14 + drivers/bus/fsl-mc/mc-bus.c| 566 include/linux/fsl/mc-private.h | 33 +++ include/linux/fsl/mc.h | 137 ++ 7 files changed, 769 insertions(+) create mode 100644 drivers/bus/fsl-mc/Kconfig create mode 100644 drivers/bus/fsl-mc/Makefile create mode 100644 drivers/bus/fsl-mc/mc-bus.c create mode 100644 include/linux/fsl/mc-private.h create mode 100644 include/linux/fsl/mc.h diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig index 603eb1b..2fbb1fd 100644 --- a/drivers/bus/Kconfig +++ b/drivers/bus/Kconfig @@ -67,4 +67,7 @@ config VEXPRESS_CONFIG help Platform configuration infrastructure for the ARM Ltd. Versatile Express. + +source drivers/bus/fsl-mc/Kconfig + endmenu diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile index 2973c18..6abcab1 100644 --- a/drivers/bus/Makefile +++ b/drivers/bus/Makefile @@ -15,3 +15,6 @@ obj-$(CONFIG_ARM_CCI) += arm-cci.o obj-$(CONFIG_ARM_CCN)+= arm-ccn.o obj-$(CONFIG_VEXPRESS_CONFIG)+= vexpress-config.o + +# Freescale Management Complex (MC) bus drivers +obj-$(CONFIG_FSL_MC_BUS) += fsl-mc/ diff --git a/drivers/bus/fsl-mc/Kconfig b/drivers/bus/fsl-mc/Kconfig new file mode 100644 index 000..e3226f9 --- /dev/null +++ b/drivers/bus/fsl-mc/Kconfig @@ -0,0 +1,13 @@ +# +# Freescale Management Complex (MC) bus drivers +# +# Copyright (C) 2014 Freescale Semiconductor, Inc. +# +# This file is released under the GPLv2 +# + +config FSL_MC_BUS + tristate Freescale Management Complex (MC) bus driver + help + Driver to enable the bus infrastructure for the Freescale + QorIQ Management Complex. Isn't this missing some scope limitations? Should we really have the driver enabled on x86 for example? I would also make this slightly more verbose. People don't necessarily know what the QorIQ Management Complex is. Give people some idea what they're dealing with and preferably tell them hints that guide them from SoC name to should I enable this option?. Also, usually the help text gives some guidance on what to do with the option if you're not sure. In this case, I would say advise the user to say N. Alex -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver
From: "J. German Rivera"
Platform device driver that sets up the basic bus infrastructure
for the fsl-mc bus type, including support for adding/removing
fsl-mc devices, register/unregister of fsl-mc drivers, and bus
match support to bind devices to drivers.
Signed-off-by: J. German Rivera
Signed-off-by: Stuart Yoder
---
Changes in v3:
- Addressed changes from Kim Phillips:
* Renamed files:
drivers/bus/fsl-mc/fsl_mc_bus.c -> drivers/bus/fsl-mc/mc-bus.c
include/linux/fsl_mc.h -> include/linux/fsl/mc.h
include/linux/fsl_mc_private.h -> include/linux/fsl/mc-private.h
- Addressed comments from Timur Tabi:
* Changed all functions that had goto out/error when no common cleanup
was done, to just have multiple return points.
* Replaced error cleanup boolean flags with multiple exit points.
Changes in v2:
- Addressed comment from Joe Perches:
* Changed pr_debug to dev_dbg in fsl_mc_bus_match
- Addressed comments from Kim Phillips and Alex Graf:
* Changed version check to allow the driver to run with MC
firmware that has major version number greater than or equal
to the driver's major version number.
* Removed minor version check
- Removed unused variable parent_dev in fsl_mc_device_remove
drivers/bus/Kconfig|3 +
drivers/bus/Makefile |3 +
drivers/bus/fsl-mc/Kconfig | 13 +
drivers/bus/fsl-mc/Makefile| 14 +
drivers/bus/fsl-mc/mc-bus.c| 566
include/linux/fsl/mc-private.h | 33 +++
include/linux/fsl/mc.h | 137 ++
7 files changed, 769 insertions(+)
create mode 100644 drivers/bus/fsl-mc/Kconfig
create mode 100644 drivers/bus/fsl-mc/Makefile
create mode 100644 drivers/bus/fsl-mc/mc-bus.c
create mode 100644 include/linux/fsl/mc-private.h
create mode 100644 include/linux/fsl/mc.h
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 603eb1b..2fbb1fd 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -67,4 +67,7 @@ config VEXPRESS_CONFIG
help
Platform configuration infrastructure for the ARM Ltd.
Versatile Express.
+
+source "drivers/bus/fsl-mc/Kconfig"
+
endmenu
diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
index 2973c18..6abcab1 100644
--- a/drivers/bus/Makefile
+++ b/drivers/bus/Makefile
@@ -15,3 +15,6 @@ obj-$(CONFIG_ARM_CCI) += arm-cci.o
obj-$(CONFIG_ARM_CCN) += arm-ccn.o
obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress-config.o
+
+# Freescale Management Complex (MC) bus drivers
+obj-$(CONFIG_FSL_MC_BUS) += fsl-mc/
diff --git a/drivers/bus/fsl-mc/Kconfig b/drivers/bus/fsl-mc/Kconfig
new file mode 100644
index 000..e3226f9
--- /dev/null
+++ b/drivers/bus/fsl-mc/Kconfig
@@ -0,0 +1,13 @@
+#
+# Freescale Management Complex (MC) bus drivers
+#
+# Copyright (C) 2014 Freescale Semiconductor, Inc.
+#
+# This file is released under the GPLv2
+#
+
+config FSL_MC_BUS
+ tristate "Freescale Management Complex (MC) bus driver"
+ help
+ Driver to enable the bus infrastructure for the Freescale
+ QorIQ Management Complex.
diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
new file mode 100644
index 000..decd339
--- /dev/null
+++ b/drivers/bus/fsl-mc/Makefile
@@ -0,0 +1,14 @@
+#
+# Freescale Management Complex (MC) bus drivers
+#
+# Copyright (C) 2014 Freescale Semiconductor, Inc.
+#
+# This file is released under the GPLv2
+#
+obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
+
+mc-bus-driver-objs := mc-bus.o \
+ mc-sys.o \
+ dprc.o \
+ dpmng.o
+
diff --git a/drivers/bus/fsl-mc/mc-bus.c b/drivers/bus/fsl-mc/mc-bus.c
new file mode 100644
index 000..d19fb18
--- /dev/null
+++ b/drivers/bus/fsl-mc/mc-bus.c
@@ -0,0 +1,566 @@
+/*
+ * Freescale Management Complex (MC) bus driver
+ *
+ * Copyright (C) 2014 Freescale Semiconductor, Inc.
+ * Author: German Rivera
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include "dprc-cmd.h"
+
+static struct kmem_cache *mc_dev_cache;
+
+/**
+ * fsl_mc_bus_match - device to driver matching callback
+ * @dev: the MC object device structure to match against
+ * @drv: the device driver to search for matching MC object device id
+ * structures
+ *
+ * Returns 1 on success, 0 otherwise.
+ */
+static int fsl_mc_bus_match(struct device *dev, struct device_driver *drv)
+{
+ const struct fsl_mc_device_match_id *id;
+ struct fsl_mc_device *mc_dev = to_fsl_mc_device(dev);
+ struct fsl_mc_driver *mc_drv = to_fsl_mc_driver(drv);
+ bool found = false;
+
+ if (mc_drv->match_id_table == NULL)
+ goto out;
+
+ /*
+* If the object is not 'plugged' don't
[PATCH 2/3 v3] drivers/bus: Freescale Management Complex (fsl-mc) bus driver
From: J. German Rivera german.riv...@freescale.com
Platform device driver that sets up the basic bus infrastructure
for the fsl-mc bus type, including support for adding/removing
fsl-mc devices, register/unregister of fsl-mc drivers, and bus
match support to bind devices to drivers.
Signed-off-by: J. German Rivera german.riv...@freescale.com
Signed-off-by: Stuart Yoder stuart.yo...@freescale.com
---
Changes in v3:
- Addressed changes from Kim Phillips:
* Renamed files:
drivers/bus/fsl-mc/fsl_mc_bus.c - drivers/bus/fsl-mc/mc-bus.c
include/linux/fsl_mc.h - include/linux/fsl/mc.h
include/linux/fsl_mc_private.h - include/linux/fsl/mc-private.h
- Addressed comments from Timur Tabi:
* Changed all functions that had goto out/error when no common cleanup
was done, to just have multiple return points.
* Replaced error cleanup boolean flags with multiple exit points.
Changes in v2:
- Addressed comment from Joe Perches:
* Changed pr_debug to dev_dbg in fsl_mc_bus_match
- Addressed comments from Kim Phillips and Alex Graf:
* Changed version check to allow the driver to run with MC
firmware that has major version number greater than or equal
to the driver's major version number.
* Removed minor version check
- Removed unused variable parent_dev in fsl_mc_device_remove
drivers/bus/Kconfig|3 +
drivers/bus/Makefile |3 +
drivers/bus/fsl-mc/Kconfig | 13 +
drivers/bus/fsl-mc/Makefile| 14 +
drivers/bus/fsl-mc/mc-bus.c| 566
include/linux/fsl/mc-private.h | 33 +++
include/linux/fsl/mc.h | 137 ++
7 files changed, 769 insertions(+)
create mode 100644 drivers/bus/fsl-mc/Kconfig
create mode 100644 drivers/bus/fsl-mc/Makefile
create mode 100644 drivers/bus/fsl-mc/mc-bus.c
create mode 100644 include/linux/fsl/mc-private.h
create mode 100644 include/linux/fsl/mc.h
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 603eb1b..2fbb1fd 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -67,4 +67,7 @@ config VEXPRESS_CONFIG
help
Platform configuration infrastructure for the ARM Ltd.
Versatile Express.
+
+source drivers/bus/fsl-mc/Kconfig
+
endmenu
diff --git a/drivers/bus/Makefile b/drivers/bus/Makefile
index 2973c18..6abcab1 100644
--- a/drivers/bus/Makefile
+++ b/drivers/bus/Makefile
@@ -15,3 +15,6 @@ obj-$(CONFIG_ARM_CCI) += arm-cci.o
obj-$(CONFIG_ARM_CCN) += arm-ccn.o
obj-$(CONFIG_VEXPRESS_CONFIG) += vexpress-config.o
+
+# Freescale Management Complex (MC) bus drivers
+obj-$(CONFIG_FSL_MC_BUS) += fsl-mc/
diff --git a/drivers/bus/fsl-mc/Kconfig b/drivers/bus/fsl-mc/Kconfig
new file mode 100644
index 000..e3226f9
--- /dev/null
+++ b/drivers/bus/fsl-mc/Kconfig
@@ -0,0 +1,13 @@
+#
+# Freescale Management Complex (MC) bus drivers
+#
+# Copyright (C) 2014 Freescale Semiconductor, Inc.
+#
+# This file is released under the GPLv2
+#
+
+config FSL_MC_BUS
+ tristate Freescale Management Complex (MC) bus driver
+ help
+ Driver to enable the bus infrastructure for the Freescale
+ QorIQ Management Complex.
diff --git a/drivers/bus/fsl-mc/Makefile b/drivers/bus/fsl-mc/Makefile
new file mode 100644
index 000..decd339
--- /dev/null
+++ b/drivers/bus/fsl-mc/Makefile
@@ -0,0 +1,14 @@
+#
+# Freescale Management Complex (MC) bus drivers
+#
+# Copyright (C) 2014 Freescale Semiconductor, Inc.
+#
+# This file is released under the GPLv2
+#
+obj-$(CONFIG_FSL_MC_BUS) += mc-bus-driver.o
+
+mc-bus-driver-objs := mc-bus.o \
+ mc-sys.o \
+ dprc.o \
+ dpmng.o
+
diff --git a/drivers/bus/fsl-mc/mc-bus.c b/drivers/bus/fsl-mc/mc-bus.c
new file mode 100644
index 000..d19fb18
--- /dev/null
+++ b/drivers/bus/fsl-mc/mc-bus.c
@@ -0,0 +1,566 @@
+/*
+ * Freescale Management Complex (MC) bus driver
+ *
+ * Copyright (C) 2014 Freescale Semiconductor, Inc.
+ * Author: German Rivera german.riv...@freescale.com
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed as is without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include linux/fsl/mc-private.h
+#include linux/module.h
+#include linux/of_device.h
+#include linux/of_address.h
+#include linux/ioport.h
+#include linux/slab.h
+#include linux/limits.h
+#include linux/fsl/dpmng.h
+#include linux/fsl/mc-sys.h
+#include dprc-cmd.h
+
+static struct kmem_cache *mc_dev_cache;
+
+/**
+ * fsl_mc_bus_match - device to driver matching callback
+ * @dev: the MC object device structure to match against
+ * @drv: the device driver to search for matching MC object device id
+ * structures
+ *
+ * Returns 1 on success, 0 otherwise.
+ */
+static int fsl_mc_bus_match(struct device *dev, struct device_driver *drv)
+{
+ const struct fsl_mc_device_match_id *id;
+ struct fsl_mc_device *mc_dev =
