Re: [PATCH 2/4] dt-bindings: Add bindings for aspeed pwm
Hi Rob,
Best Regards,
Billy Tsai
On 2021/4/12, 9:20 PM,Rob Herringwrote:
On Mon, 12 Apr 2021 17:54:55 +0800, Billy Tsai wrote:
>> This patch adds device bindings for aspeed pwm device which should be
>> the sub-node of aspeed,ast2600-pwm-tach.
>>
>> Signed-off-by: Billy Tsai
>> ---
>> .../bindings/pwm/aspeed,ast2600-pwm.yaml | 47 +++
>> 1 file changed, 47 insertions(+)
>> create mode 100644
Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
>>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
> yamllint warnings/errors:
> dtschema/dtc warnings/errors:
>
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml:
Additional properties are not allowed ('pwm-cells' was unexpected)
>
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml:
Additional properties are not allowed ('pwm-cells' was unexpected)
>
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml:
ignoring, error in schema:
> warning: no schema found in file:
./Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
>
Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.example.dt.yaml:0:0:
/example-0/pwm_tach@1e61: failed to match any schema with compatible:
['aspeed,ast2600-pwm-tach', 'simple-mfd', 'syscon']
>
Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.example.dt.yaml:0:0:
/example-0/pwm_tach@1e61/pwm@0: failed to match any schema with compatible:
['aspeed,ast2600-pwm']
The yaml file have dependencies with the first patch in these series. I will
squash them.
> See https://patchwork.ozlabs.org/patch/1465116
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
> pip3 install dtschema --upgrade
> Please check and re-submit.
Re: [PATCH 2/4] dt-bindings: Add bindings for aspeed pwm
On Mon, 12 Apr 2021 17:54:55 +0800, Billy Tsai wrote:
> This patch adds device bindings for aspeed pwm device which should be
> the sub-node of aspeed,ast2600-pwm-tach.
>
> Signed-off-by: Billy Tsai
> ---
> .../bindings/pwm/aspeed,ast2600-pwm.yaml | 47 +++
> 1 file changed, 47 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml:
Additional properties are not allowed ('pwm-cells' was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml:
Additional properties are not allowed ('pwm-cells' was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml:
ignoring, error in schema:
warning: no schema found in file:
./Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.example.dt.yaml:0:0:
/example-0/pwm_tach@1e61: failed to match any schema with compatible:
['aspeed,ast2600-pwm-tach', 'simple-mfd', 'syscon']
Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.example.dt.yaml:0:0:
/example-0/pwm_tach@1e61/pwm@0: failed to match any schema with compatible:
['aspeed,ast2600-pwm']
See https://patchwork.ozlabs.org/patch/1465116
This check can fail if there are any dependencies. The base for a patch
series is generally the most recent rc1.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
[PATCH 2/4] dt-bindings: Add bindings for aspeed pwm
This patch adds device bindings for aspeed pwm device which should be
the sub-node of aspeed,ast2600-pwm-tach.
Signed-off-by: Billy Tsai
---
.../bindings/pwm/aspeed,ast2600-pwm.yaml | 47 +++
1 file changed, 47 insertions(+)
create mode 100644
Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
diff --git a/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
new file mode 100644
index ..7a7ff0260d27
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/aspeed,ast2600-pwm.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+# Copyright (C) 2021 ASPEED, Inc.
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/aspeed,ast2600-pwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ASPEED AST2600 PWM controller
+
+maintainers:
+ - Billy Tsai
+
+description: |
+ The ASPEED PWM controller can support upto 16 PWM outputs.
+
+properties:
+ compatible:
+enum:
+ - aspeed,ast2600-pwm
+
+ "#pwm-cells":
+const: 3
+
+pwm-cells:
+ - channel
+# period in terms of nanoseconds
+ - period
+# PWM_POLARITY_INVERTED
+ - flag
+
+additionalProperties: false
+
+examples:
+ - |
+// The PWM should be a subnode of a "aspeed,ast2600-pwn-tach" compatible
node.
+pwm_tach@1e61 {
+ compatible = "aspeed,ast2600-pwm-tach", "simple-mfd", "syscon";
+ #address-cells = <1>;
+ #size-cells = <1>;
+ reg = <0x1e61 0x100>;
+ ranges = <0 0x1e61 0x100>;
+ pwm: pwm@0 {
+compatible = "aspeed,ast2600-pwm";
+#pwm-cells = <3>;
+reg = <0x0 0x100>;
+ };
+};
--
2.25.1
