Re: [PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning
Mark F. Haigh wrote: Apologies. Patch now -p1-able. [Apolgies yet again, description included now] Noticed that in drivers/scsi/sym53c8xx.c: sym53c8xx.c:13185: warning: integer constant is too large for "long" type Since we're not dealing with C99 (yet), this 64 bit integer constant needs to be suffixed with ULL. Patch included. Mark F. Haigh [EMAIL PROTECTED] Signed-off-by: Mark F. Haigh <[EMAIL PROTECTED]> --- linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c.orig 2005-02-07 19:53:05.0 -0800 +++ linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c 2005-02-07 19:53:36.0 -0800 @@ -13182,7 +13182,7 @@ ** descriptors. */ if (chip && (chip->features & FE_DAC)) { - if (pci_set_dma_mask(pdev, (u64) 0xff)) + if (pci_set_dma_mask(pdev, (u64) 0xffULL)) chip->features &= ~FE_DAC_IN_USE; else chip->features |= FE_DAC_IN_USE;
Re: [PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning
Mark F. Haigh wrote: --- drivers/scsi/sym53c8xx.c.orig 2005-02-07 19:53:05.741527608 -0800 +++ drivers/scsi/sym53c8xx.c2005-02-07 19:53:36.782808616 -0800 Apologies. Patch now -p1-able. Mark F. Haigh [EMAIL PROTECTED] Signed-off-by: Mark F. Haigh <[EMAIL PROTECTED]> --- linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c.orig 2005-02-07 19:53:05.0 -0800 +++ linux-2.4.29-bk8/drivers/scsi/sym53c8xx.c 2005-02-07 19:53:36.0 -0800 @@ -13182,7 +13182,7 @@ ** descriptors. */ if (chip && (chip->features & FE_DAC)) { - if (pci_set_dma_mask(pdev, (u64) 0xff)) + if (pci_set_dma_mask(pdev, (u64) 0xffULL)) chip->features &= ~FE_DAC_IN_USE; else chip->features |= FE_DAC_IN_USE;
[PATCH 2.4.29-bk8] Resend: sym53c8xx.c: Add ULL suffix to fix warning
Same patch, now against 2.4.29-bk8: Noticed that in drivers/scsi/sym53c8xx.c: sym53c8xx.c:13185: warning: integer constant is too large for "long" type Since we're not dealing with C99 (yet), this 64 bit integer constant needs to be suffixed with ULL. Patch included. Mark F. Haigh [EMAIL PROTECTED] --- drivers/scsi/sym53c8xx.c.orig 2005-02-07 19:53:05.741527608 -0800 +++ drivers/scsi/sym53c8xx.c2005-02-07 19:53:36.782808616 -0800 @@ -13182,7 +13182,7 @@ ** descriptors. */ if (chip && (chip->features & FE_DAC)) { - if (pci_set_dma_mask(pdev, (u64) 0xff)) + if (pci_set_dma_mask(pdev, (u64) 0xffULL)) chip->features &= ~FE_DAC_IN_USE; else chip->features |= FE_DAC_IN_USE;