Re: [PATCH 2.6.12.5]error condition fix in usbnet

[David Brownell]

You noticed that too, eh?  It's already fixed in the patches
I may yet send out tonight, splitting "usbnet" and its
minidrivers into separate files ...

- Dave

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 2.6.12.5]error condition fix in usbnet

[David Brownell]

You noticed that too, eh?  It's already fixed in the patches
I may yet send out tonight, splitting usbnet and its
minidrivers into separate files ...

- Dave

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2.6.12.5]error condition fix in usbnet

[lepton]

Hi!

I thinks this condition is strange, it could be a type error.
See the following patch.

Signed-off-by: Wu Tao <[EMAIL PROTECTED]>

diff -pru linux-2.6-curr/drivers/usb/net/usbnet.c 
linux-2.6-curr-lepton/drivers/usb/net/usbnet.c
--- linux-2.6-curr/drivers/usb/net/usbnet.c 2005-06-30 07:00:53.0 
+0800
+++ linux-2.6-curr-lepton/drivers/usb/net/usbnet.c  2005-08-24 
11:26:49.0 +0800
@@ -3807,7 +3807,7 @@ usbnet_probe (struct usb_interface *udev
if ((dev->driver_info->flags & FLAG_ETHER) != 0
&& (net->dev_addr [0] & 0x02) == 0)
strcpy (net->name, "eth%d");
-   } else if (!info->in || info->out)
+   } else if (!info->in || !info->out)
status = get_endpoints (dev, udev);
else {
dev->in = usb_rcvbulkpipe (xdev, info->in);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 2.6.12.5]error condition fix in usbnet

[lepton]

Hi!

I thinks this condition is strange, it could be a type error.
See the following patch.

Signed-off-by: Wu Tao [EMAIL PROTECTED]

diff -pru linux-2.6-curr/drivers/usb/net/usbnet.c 
linux-2.6-curr-lepton/drivers/usb/net/usbnet.c
--- linux-2.6-curr/drivers/usb/net/usbnet.c 2005-06-30 07:00:53.0 
+0800
+++ linux-2.6-curr-lepton/drivers/usb/net/usbnet.c  2005-08-24 
11:26:49.0 +0800
@@ -3807,7 +3807,7 @@ usbnet_probe (struct usb_interface *udev
if ((dev-driver_info-flags  FLAG_ETHER) != 0
 (net-dev_addr [0]  0x02) == 0)
strcpy (net-name, eth%d);
-   } else if (!info-in || info-out)
+   } else if (!info-in || !info-out)
status = get_endpoints (dev, udev);
else {
dev-in = usb_rcvbulkpipe (xdev, info-in);
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/