Re: [PATCH 21/24] ARM64:ILP32: The native siginfo is used instead of the compat siginfo.

2014-05-24 Thread H. Peter Anvin 
On 05/24/2014 12:02 AM, Andrew Pinski wrote:
>  
> +/* ILP32 uses the native siginfo and not the compat struct */
> +#define COMPAT_USE_NATIVE_SIGINFO!is_a32_compat_task()
> +

 Probably want parens around that expression? 

-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 21/24] ARM64:ILP32: The native siginfo is used instead of the compat siginfo.

2014-05-24 Thread Andrew Pinski 
Set COMPAT_USE_NATIVE_SIGINFO to be true for non AARCH32 tasks.  The same 
reasoning why we check AARCH32 as we did for COMPAT_USE_64BIT_TIME_T.

Thanks,
Andrew Pinski

Signed-off-by: Andrew Pinski 
---
 arch/arm64/include/asm/compat.h |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arm64/include/asm/compat.h b/arch/arm64/include/asm/compat.h
index c77fc0f..aef8cd3 100644
--- a/arch/arm64/include/asm/compat.h
+++ b/arch/arm64/include/asm/compat.h
@@ -211,6 +211,9 @@ typedef struct compat_siginfo {
} _sifields;
 } compat_siginfo_t;
 
+/* ILP32 uses the native siginfo and not the compat struct */
+#define COMPAT_USE_NATIVE_SIGINFO  !is_a32_compat_task()
+
 #define COMPAT_OFF_T_MAX   0x7fff
 #define COMPAT_LOFF_T_MAX  0x7fffL
 
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 21/24] ARM64:ILP32: The native siginfo is used instead of the compat siginfo.

2014-05-24 Thread Andrew Pinski 
Set COMPAT_USE_NATIVE_SIGINFO to be true for non AARCH32 tasks.  The same 
reasoning why we check AARCH32 as we did for COMPAT_USE_64BIT_TIME_T.

Thanks,
Andrew Pinski

Signed-off-by: Andrew Pinski apin...@cavium.com
---
 arch/arm64/include/asm/compat.h |3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arm64/include/asm/compat.h b/arch/arm64/include/asm/compat.h
index c77fc0f..aef8cd3 100644
--- a/arch/arm64/include/asm/compat.h
+++ b/arch/arm64/include/asm/compat.h
@@ -211,6 +211,9 @@ typedef struct compat_siginfo {
} _sifields;
 } compat_siginfo_t;
 
+/* ILP32 uses the native siginfo and not the compat struct */
+#define COMPAT_USE_NATIVE_SIGINFO  !is_a32_compat_task()
+
 #define COMPAT_OFF_T_MAX   0x7fff
 #define COMPAT_LOFF_T_MAX  0x7fffL
 
-- 
1.7.2.5

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 21/24] ARM64:ILP32: The native siginfo is used instead of the compat siginfo.

2014-05-24 Thread H. Peter Anvin 
On 05/24/2014 12:02 AM, Andrew Pinski wrote:
  
 +/* ILP32 uses the native siginfo and not the compat struct */
 +#define COMPAT_USE_NATIVE_SIGINFO!is_a32_compat_task()
 +

nitpick Probably want parens around that expression? /nitpick

-hpa

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/