Re: [PATCH 25] drivers/usb/misc/ftdi-elan.c: kmalloc + memset conversion to kzalloc

[Christoph Lameter]

On Tue, 31 Jul 2007, Mariusz Kozlowski wrote:

> @@ -2777,12 +2777,14 @@ static int ftdi_elan_probe(struct usb_in
>  size_t buffer_size;
>  int i;
>  int retval = -ENOMEM;
> -struct usb_ftdi *ftdi = kmalloc(sizeof(struct usb_ftdi), GFP_KERNEL);
> -if (ftdi == NULL) {
> +struct usb_ftdi *ftdi;
> +
> + ftdi = kzalloc(sizeof(struct usb_ftdi), GFP_KERNEL);
> + if (!ftdi) {

Whitespace damage soewhere?

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 25] drivers/usb/misc/ftdi-elan.c: kmalloc + memset conversion to kzalloc

[Mariusz Kozlowski]

Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>

 drivers/usb/misc/ftdi-elan.c | 121253 -> 121196 (-57 bytes)
 drivers/usb/misc/ftdi-elan.o | 209425 -> 209265 (-160 bytes)

 drivers/usb/misc/ftdi-elan.c |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

--- linux-2.6.23-rc1-mm1-a/drivers/usb/misc/ftdi-elan.c 2007-07-26 
13:07:41.0 +0200
+++ linux-2.6.23-rc1-mm1-b/drivers/usb/misc/ftdi-elan.c 2007-07-31 
14:47:59.0 +0200
@@ -2777,12 +2777,14 @@ static int ftdi_elan_probe(struct usb_in
 size_t buffer_size;
 int i;
 int retval = -ENOMEM;
-struct usb_ftdi *ftdi = kmalloc(sizeof(struct usb_ftdi), GFP_KERNEL);
-if (ftdi == NULL) {
+struct usb_ftdi *ftdi;
+
+   ftdi = kzalloc(sizeof(struct usb_ftdi), GFP_KERNEL);
+   if (!ftdi) {
 printk(KERN_ERR "Out of memory\n");
 return -ENOMEM;
 }
-memset(ftdi, 0x00, sizeof(struct usb_ftdi));
+
 mutex_lock(_module_lock);
 list_add_tail(>ftdi_list, _static_list);
 ftdi->sequence_num = ++ftdi_instances;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 25] drivers/usb/misc/ftdi-elan.c: kmalloc + memset conversion to kzalloc

[Mariusz Kozlowski]

Signed-off-by: Mariusz Kozlowski [EMAIL PROTECTED]

 drivers/usb/misc/ftdi-elan.c | 121253 - 121196 (-57 bytes)
 drivers/usb/misc/ftdi-elan.o | 209425 - 209265 (-160 bytes)

 drivers/usb/misc/ftdi-elan.c |8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

--- linux-2.6.23-rc1-mm1-a/drivers/usb/misc/ftdi-elan.c 2007-07-26 
13:07:41.0 +0200
+++ linux-2.6.23-rc1-mm1-b/drivers/usb/misc/ftdi-elan.c 2007-07-31 
14:47:59.0 +0200
@@ -2777,12 +2777,14 @@ static int ftdi_elan_probe(struct usb_in
 size_t buffer_size;
 int i;
 int retval = -ENOMEM;
-struct usb_ftdi *ftdi = kmalloc(sizeof(struct usb_ftdi), GFP_KERNEL);
-if (ftdi == NULL) {
+struct usb_ftdi *ftdi;
+
+   ftdi = kzalloc(sizeof(struct usb_ftdi), GFP_KERNEL);
+   if (!ftdi) {
 printk(KERN_ERR Out of memory\n);
 return -ENOMEM;
 }
-memset(ftdi, 0x00, sizeof(struct usb_ftdi));
+
 mutex_lock(ftdi_module_lock);
 list_add_tail(ftdi-ftdi_list, ftdi_static_list);
 ftdi-sequence_num = ++ftdi_instances;
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 25] drivers/usb/misc/ftdi-elan.c: kmalloc + memset conversion to kzalloc

[Christoph Lameter]

On Tue, 31 Jul 2007, Mariusz Kozlowski wrote:

 @@ -2777,12 +2777,14 @@ static int ftdi_elan_probe(struct usb_in
  size_t buffer_size;
  int i;
  int retval = -ENOMEM;
 -struct usb_ftdi *ftdi = kmalloc(sizeof(struct usb_ftdi), GFP_KERNEL);
 -if (ftdi == NULL) {
 +struct usb_ftdi *ftdi;
 +
 + ftdi = kzalloc(sizeof(struct usb_ftdi), GFP_KERNEL);
 + if (!ftdi) {

Whitespace damage soewhere?

-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/