Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef"
On 20/09/2013 20:42, Jonathan Cameron : On 09/20/13 19:36, Jonathan Cameron wrote: On 09/20/13 08:26, Nicolas Ferre wrote: On 19/09/2013 23:42, Thomas Meyer : sizeof when applied to a pointer typed expression gives the size of the pointer. Found by coccinelle spatch "misc/noderef.cocci" Signed-off-by: Thomas Meyer Acked-by: Nicolas Ferre Applied to the fixes-togreg branch of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Actually, change of plan. Applied to the togreg branch of that tree. Whilst technically more correct to have it as you say, we are dealing with the size of a struct iio_trig ** vs a struct iio_trig * so it isn't actually a bug, just a less than ideal bit of code ;) Absolutely. It was so obviously a fix I didn't initially check if it was a 'real' bug or not. oops. Yes, I took this path myself as well ;-) Bye, --- diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct int i, ret; st->trig = devm_kzalloc(>dev, -st->trigger_number * sizeof(st->trig), +st->trigger_number * sizeof(*st->trig), GFP_KERNEL); if (st->trig == NULL) { -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/10] iio: at91_adc: Cocci spatch noderef
On 20/09/2013 20:42, Jonathan Cameron : On 09/20/13 19:36, Jonathan Cameron wrote: On 09/20/13 08:26, Nicolas Ferre wrote: On 19/09/2013 23:42, Thomas Meyer : sizeof when applied to a pointer typed expression gives the size of the pointer. Found by coccinelle spatch misc/noderef.cocci Signed-off-by: Thomas Meyer tho...@m3y3r.de Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Applied to the fixes-togreg branch of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Actually, change of plan. Applied to the togreg branch of that tree. Whilst technically more correct to have it as you say, we are dealing with the size of a struct iio_trig ** vs a struct iio_trig * so it isn't actually a bug, just a less than ideal bit of code ;) Absolutely. It was so obviously a fix I didn't initially check if it was a 'real' bug or not. oops. Yes, I took this path myself as well ;-) Bye, --- diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct int i, ret; st-trig = devm_kzalloc(idev-dev, -st-trigger_number * sizeof(st-trig), +st-trigger_number * sizeof(*st-trig), GFP_KERNEL); if (st-trig == NULL) { -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef"
On 09/20/13 19:36, Jonathan Cameron wrote: > On 09/20/13 08:26, Nicolas Ferre wrote: >> On 19/09/2013 23:42, Thomas Meyer : >>> sizeof when applied to a pointer typed expression gives the size of the >>> pointer. >>> Found by coccinelle spatch "misc/noderef.cocci" >>> >>> Signed-off-by: Thomas Meyer >> >> Acked-by: Nicolas Ferre > Applied to the fixes-togreg branch of > git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Actually, change of plan. Applied to the togreg branch of that tree. Whilst technically more correct to have it as you say, we are dealing with the size of a struct iio_trig ** vs a struct iio_trig * so it isn't actually a bug, just a less than ideal bit of code ;) It was so obviously a fix I didn't initially check if it was a 'real' bug or not. oops. Jonathan > > Thanks, >> >>> --- >>> >>> diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c >>> --- a/drivers/iio/adc/at91_adc.c >>> +++ b/drivers/iio/adc/at91_adc.c >>> @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct >>> int i, ret; >>> >>> st->trig = devm_kzalloc(>dev, >>> -st->trigger_number * sizeof(st->trig), >>> +st->trigger_number * sizeof(*st->trig), >>> GFP_KERNEL); >>> >>> if (st->trig == NULL) { >>> -- >>> To unsubscribe from this list: send the line "unsubscribe devicetree" in >>> the body of a message to majord...@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> >> >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef"
On 09/20/13 08:26, Nicolas Ferre wrote: > On 19/09/2013 23:42, Thomas Meyer : >> sizeof when applied to a pointer typed expression gives the size of the >> pointer. >> Found by coccinelle spatch "misc/noderef.cocci" >> >> Signed-off-by: Thomas Meyer > > Acked-by: Nicolas Ferre Applied to the fixes-togreg branch of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Thanks, > >> --- >> >> diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c >> --- a/drivers/iio/adc/at91_adc.c >> +++ b/drivers/iio/adc/at91_adc.c >> @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct >> int i, ret; >> >> st->trig = devm_kzalloc(>dev, >> -st->trigger_number * sizeof(st->trig), >> +st->trigger_number * sizeof(*st->trig), >> GFP_KERNEL); >> >> if (st->trig == NULL) { >> -- >> To unsubscribe from this list: send the line "unsubscribe devicetree" in >> the body of a message to majord...@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/10] iio: at91_adc: Cocci spatch "noderef"
On 19/09/2013 23:42, Thomas Meyer : sizeof when applied to a pointer typed expression gives the size of the pointer. Found by coccinelle spatch "misc/noderef.cocci" Signed-off-by: Thomas Meyer Acked-by: Nicolas Ferre --- diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct int i, ret; st->trig = devm_kzalloc(>dev, - st->trigger_number * sizeof(st->trig), + st->trigger_number * sizeof(*st->trig), GFP_KERNEL); if (st->trig == NULL) { -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/10] iio: at91_adc: Cocci spatch noderef
On 19/09/2013 23:42, Thomas Meyer : sizeof when applied to a pointer typed expression gives the size of the pointer. Found by coccinelle spatch misc/noderef.cocci Signed-off-by: Thomas Meyer tho...@m3y3r.de Acked-by: Nicolas Ferre nicolas.fe...@atmel.com --- diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct int i, ret; st-trig = devm_kzalloc(idev-dev, - st-trigger_number * sizeof(st-trig), + st-trigger_number * sizeof(*st-trig), GFP_KERNEL); if (st-trig == NULL) { -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Nicolas Ferre -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/10] iio: at91_adc: Cocci spatch noderef
On 09/20/13 08:26, Nicolas Ferre wrote: On 19/09/2013 23:42, Thomas Meyer : sizeof when applied to a pointer typed expression gives the size of the pointer. Found by coccinelle spatch misc/noderef.cocci Signed-off-by: Thomas Meyer tho...@m3y3r.de Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Applied to the fixes-togreg branch of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Thanks, --- diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct int i, ret; st-trig = devm_kzalloc(idev-dev, -st-trigger_number * sizeof(st-trig), +st-trigger_number * sizeof(*st-trig), GFP_KERNEL); if (st-trig == NULL) { -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/10] iio: at91_adc: Cocci spatch noderef
On 09/20/13 19:36, Jonathan Cameron wrote: On 09/20/13 08:26, Nicolas Ferre wrote: On 19/09/2013 23:42, Thomas Meyer : sizeof when applied to a pointer typed expression gives the size of the pointer. Found by coccinelle spatch misc/noderef.cocci Signed-off-by: Thomas Meyer tho...@m3y3r.de Acked-by: Nicolas Ferre nicolas.fe...@atmel.com Applied to the fixes-togreg branch of git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git Actually, change of plan. Applied to the togreg branch of that tree. Whilst technically more correct to have it as you say, we are dealing with the size of a struct iio_trig ** vs a struct iio_trig * so it isn't actually a bug, just a less than ideal bit of code ;) It was so obviously a fix I didn't initially check if it was a 'real' bug or not. oops. Jonathan Thanks, --- diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct int i, ret; st-trig = devm_kzalloc(idev-dev, -st-trigger_number * sizeof(st-trig), +st-trigger_number * sizeof(*st-trig), GFP_KERNEL); if (st-trig == NULL) { -- To unsubscribe from this list: send the line unsubscribe devicetree in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/10] iio: at91_adc: Cocci spatch "noderef"
sizeof when applied to a pointer typed expression gives the size of the pointer. Found by coccinelle spatch "misc/noderef.cocci" Signed-off-by: Thomas Meyer --- diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct int i, ret; st->trig = devm_kzalloc(>dev, - st->trigger_number * sizeof(st->trig), + st->trigger_number * sizeof(*st->trig), GFP_KERNEL); if (st->trig == NULL) { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/10] iio: at91_adc: Cocci spatch noderef
sizeof when applied to a pointer typed expression gives the size of the pointer. Found by coccinelle spatch misc/noderef.cocci Signed-off-by: Thomas Meyer tho...@m3y3r.de --- diff -u -p a/drivers/iio/adc/at91_adc.c b/drivers/iio/adc/at91_adc.c --- a/drivers/iio/adc/at91_adc.c +++ b/drivers/iio/adc/at91_adc.c @@ -279,7 +279,7 @@ static int at91_adc_trigger_init(struct int i, ret; st-trig = devm_kzalloc(idev-dev, - st-trigger_number * sizeof(st-trig), + st-trigger_number * sizeof(*st-trig), GFP_KERNEL); if (st-trig == NULL) { -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/