Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio
On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote: > Card detect for sdhci on Cubox is connected to the wrong pin > (sdio1_cd instead of sdio0_cd). With support for cd-gpios and > pinctrl add the corresponding properties to DT for Cubox. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Sebastian Hesselbarth > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/dove-cubox.dts | 14 -- > 1 file changed, 12 insertions(+), 2 deletions(-) Applied to mvebu/fixes thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio
On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote: Card detect for sdhci on Cubox is connected to the wrong pin (sdio1_cd instead of sdio0_cd). With support for cd-gpios and pinctrl add the corresponding properties to DT for Cubox. Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com --- Cc: Russell King li...@arm.linux.org.uk Cc: Jason Cooper ja...@lakedaemon.net Cc: Andrew Lunn and...@lunn.ch Cc: Sebastian Hesselbarth sebastian.hesselba...@gmail.com Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- arch/arm/boot/dts/dove-cubox.dts | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) Applied to mvebu/fixes thx, Jason. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio
On Tue, Dec 18, 2012 at 01:50:12AM +0100, Sebastian Hesselbarth wrote:
> On 12/18/2012 01:38 AM, Jason Cooper wrote:
> > On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote:
> >> Card detect for sdhci on Cubox is connected to the wrong pin
> >> (sdio1_cd instead of sdio0_cd). With support for cd-gpios and
> >> pinctrl add the corresponding properties to DT for Cubox.
> >>
> >> Signed-off-by: Sebastian Hesselbarth
> >> ...
> >> + {
> >> + status = "okay";
> >> + /* sdio0 card detect is connected to wrong pin on CuBox */
> >> + cd-gpios =< 12 1>;
> >
> > this looks like a fix that should be merged into v3.8, I'll cue it up
> > for v3.8-rc2.
>
> Jason,
>
> it is more a feature than a fix, as gpio-cd support for sdhci-dove
> moved in lately. You want me to split this patch from the other two
> (that I'll reorder as requested)?
I was referring to the code more than the physical feature itself. You
appear to remove the default , and replace it with a working
version. Looked like a fix to me ;-)
No need to send it separate, I'll apply it as is once v3.8-rc1 drops.
thx,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio
On 12/18/2012 01:38 AM, Jason Cooper wrote:
> On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote:
>> Card detect for sdhci on Cubox is connected to the wrong pin
>> (sdio1_cd instead of sdio0_cd). With support for cd-gpios and
>> pinctrl add the corresponding properties to DT for Cubox.
>>
>> Signed-off-by: Sebastian Hesselbarth
>> ...
>> + {
>> + status = "okay";
>> + /* sdio0 card detect is connected to wrong pin on CuBox */
>> + cd-gpios =< 12 1>;
>
> this looks like a fix that should be merged into v3.8, I'll cue it up
> for v3.8-rc2.
Jason,
it is more a feature than a fix, as gpio-cd support for sdhci-dove
moved in lately. You want me to split this patch from the other two
(that I'll reorder as requested)?
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio
Sebastian,
On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote:
> Card detect for sdhci on Cubox is connected to the wrong pin
> (sdio1_cd instead of sdio0_cd). With support for cd-gpios and
> pinctrl add the corresponding properties to DT for Cubox.
>
> Signed-off-by: Sebastian Hesselbarth
> ---
> Cc: Russell King
> Cc: Jason Cooper
> Cc: Andrew Lunn
> Cc: Sebastian Hesselbarth
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> ---
> arch/arm/boot/dts/dove-cubox.dts | 14 --
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/dove-cubox.dts
> b/arch/arm/boot/dts/dove-cubox.dts
> index fed7d3f..cdee96f 100644
> --- a/arch/arm/boot/dts/dove-cubox.dts
> +++ b/arch/arm/boot/dts/dove-cubox.dts
> @@ -26,10 +26,15 @@
> };
>
> { status = "okay"; };
> - { status = "okay"; };
> { status = "okay"; };
> { status = "okay"; };
>
> + {
> + status = "okay";
> + /* sdio0 card detect is connected to wrong pin on CuBox */
> + cd-gpios = < 12 1>;
this looks like a fix that should be merged into v3.8, I'll cue it up
for v3.8-rc2.
thx,
Jason.
> +};
> +
> {
> status = "okay";
>
> @@ -42,9 +47,14 @@
> };
>
> {
> - pinctrl-0 = <_gpio_18>;
> + pinctrl-0 = <_gpio_12 _gpio_18>;
> pinctrl-names = "default";
>
> + pmx_gpio_12: pmx-gpio-12 {
> + marvell,pins = "mpp12";
> + marvell,function = "gpio";
> + };
> +
> pmx_gpio_18: pmx-gpio-18 {
> marvell,pins = "mpp18";
> marvell,function = "gpio";
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio
Sebastian,
On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote:
Card detect for sdhci on Cubox is connected to the wrong pin
(sdio1_cd instead of sdio0_cd). With support for cd-gpios and
pinctrl add the corresponding properties to DT for Cubox.
Signed-off-by: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
---
Cc: Russell King li...@arm.linux.org.uk
Cc: Jason Cooper ja...@lakedaemon.net
Cc: Andrew Lunn and...@lunn.ch
Cc: Sebastian Hesselbarth sebastian.hesselba...@gmail.com
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
arch/arm/boot/dts/dove-cubox.dts | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/dove-cubox.dts
b/arch/arm/boot/dts/dove-cubox.dts
index fed7d3f..cdee96f 100644
--- a/arch/arm/boot/dts/dove-cubox.dts
+++ b/arch/arm/boot/dts/dove-cubox.dts
@@ -26,10 +26,15 @@
};
uart0 { status = okay; };
-sdio0 { status = okay; };
sata0 { status = okay; };
i2c0 { status = okay; };
+sdio0 {
+ status = okay;
+ /* sdio0 card detect is connected to wrong pin on CuBox */
+ cd-gpios = gpio0 12 1;
this looks like a fix that should be merged into v3.8, I'll cue it up
for v3.8-rc2.
thx,
Jason.
+};
+
spi0 {
status = okay;
@@ -42,9 +47,14 @@
};
pinctrl {
- pinctrl-0 = pmx_gpio_18;
+ pinctrl-0 = pmx_gpio_12 pmx_gpio_18;
pinctrl-names = default;
+ pmx_gpio_12: pmx-gpio-12 {
+ marvell,pins = mpp12;
+ marvell,function = gpio;
+ };
+
pmx_gpio_18: pmx-gpio-18 {
marvell,pins = mpp18;
marvell,function = gpio;
--
1.7.10.4
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio
On 12/18/2012 01:38 AM, Jason Cooper wrote:
On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote:
Card detect for sdhci on Cubox is connected to the wrong pin
(sdio1_cd instead of sdio0_cd). With support for cd-gpios and
pinctrl add the corresponding properties to DT for Cubox.
Signed-off-by: Sebastian Hesselbarthsebastian.hesselba...@gmail.com
...
+sdio0 {
+ status = okay;
+ /* sdio0 card detect is connected to wrong pin on CuBox */
+ cd-gpios =gpio0 12 1;
this looks like a fix that should be merged into v3.8, I'll cue it up
for v3.8-rc2.
Jason,
it is more a feature than a fix, as gpio-cd support for sdhci-dove
moved in lately. You want me to split this patch from the other two
(that I'll reorder as requested)?
Sebastian
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/3] ARM: Dove: add Cubox sdhci card detect gpio
On Tue, Dec 18, 2012 at 01:50:12AM +0100, Sebastian Hesselbarth wrote:
On 12/18/2012 01:38 AM, Jason Cooper wrote:
On Tue, Dec 18, 2012 at 01:24:29AM +0100, Sebastian Hesselbarth wrote:
Card detect for sdhci on Cubox is connected to the wrong pin
(sdio1_cd instead of sdio0_cd). With support for cd-gpios and
pinctrl add the corresponding properties to DT for Cubox.
Signed-off-by: Sebastian Hesselbarthsebastian.hesselba...@gmail.com
...
+sdio0 {
+ status = okay;
+ /* sdio0 card detect is connected to wrong pin on CuBox */
+ cd-gpios =gpio0 12 1;
this looks like a fix that should be merged into v3.8, I'll cue it up
for v3.8-rc2.
Jason,
it is more a feature than a fix, as gpio-cd support for sdhci-dove
moved in lately. You want me to split this patch from the other two
(that I'll reorder as requested)?
I was referring to the code more than the physical feature itself. You
appear to remove the default sdio0, and replace it with a working
version. Looked like a fix to me ;-)
No need to send it separate, I'll apply it as is once v3.8-rc1 drops.
thx,
Jason.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
