Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

2013-10-09 Thread Chanwoo Choi 
On 10/10/2013 01:05 PM, Chanwoo Choi wrote:
> On 10/10/2013 12:29 PM, Sachin Kamat wrote:
>> On 10 October 2013 06:00, Chanwoo Choi  wrote:
>>> This patch maudio/gps_alive power domain to exynos4x12.dtsi.
>>>
>>> Signed-off-by: Chanwoo Choi 
>>> Signed-off-by: Kyungmin Park 
>>> ---
>>>  arch/arm/boot/dts/exynos4x12.dtsi | 10 ++
>>>  1 file changed, 10 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi 
>>> b/arch/arm/boot/dts/exynos4x12.dtsi
>>> index ad531fe..c04418e 100644
>>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>>> @@ -35,6 +35,16 @@
>>> reg = <0x10023CA0 0x20>;
>>> };
>>>
>>> +   pd_maudio: maudio-power-domain@10023CC0 {
>>> +   compatible = "samsung,exynos4210-pd";
>>> +   reg = <0x10023CC0 0x20>;
>>> +   };
>>> +
>>> +   pd_gps_alive: gps-alive-power-domain@10023D04 {
>>> +   compatible = "samsung,exynos4210-pd";
>>> +   reg = <0x10023D00 0x20>;
>>
>> There is mismatch between node name and register value.
>>
>>
> What is exactly mismatch?
> 
> I checked the register address of 
> MAUDIO_CONFIGURATION/GPS_ALIVE_CONFIGURATION regsiter.
> - MAUDIO_CONFIGURATION 0x1002_3CC0
> - GPS_ALIVE_CONFIGURATION 0x1002_3D00

My mistake. I write wrong address about gps-alive-power-domain.

I will fix it.
- gps-alive-power-domain@10023D04 -> gps-alive-power-domain@10023D00

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

2013-10-09 Thread Chanwoo Choi 
On 10/10/2013 12:29 PM, Sachin Kamat wrote:
> On 10 October 2013 06:00, Chanwoo Choi  wrote:
>> This patch maudio/gps_alive power domain to exynos4x12.dtsi.
>>
>> Signed-off-by: Chanwoo Choi 
>> Signed-off-by: Kyungmin Park 
>> ---
>>  arch/arm/boot/dts/exynos4x12.dtsi | 10 ++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi 
>> b/arch/arm/boot/dts/exynos4x12.dtsi
>> index ad531fe..c04418e 100644
>> --- a/arch/arm/boot/dts/exynos4x12.dtsi
>> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
>> @@ -35,6 +35,16 @@
>> reg = <0x10023CA0 0x20>;
>> };
>>
>> +   pd_maudio: maudio-power-domain@10023CC0 {
>> +   compatible = "samsung,exynos4210-pd";
>> +   reg = <0x10023CC0 0x20>;
>> +   };
>> +
>> +   pd_gps_alive: gps-alive-power-domain@10023D04 {
>> +   compatible = "samsung,exynos4210-pd";
>> +   reg = <0x10023D00 0x20>;
> 
> There is mismatch between node name and register value.
> 
> 
What is exactly mismatch?

I checked the register address of MAUDIO_CONFIGURATION/GPS_ALIVE_CONFIGURATION 
regsiter.
- MAUDIO_CONFIGURATION 0x1002_3CC0
- GPS_ALIVE_CONFIGURATION 0x1002_3D00


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

2013-10-09 Thread Sachin Kamat 
On 10 October 2013 06:00, Chanwoo Choi  wrote:
> This patch maudio/gps_alive power domain to exynos4x12.dtsi.
>
> Signed-off-by: Chanwoo Choi 
> Signed-off-by: Kyungmin Park 
> ---
>  arch/arm/boot/dts/exynos4x12.dtsi | 10 ++
>  1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4x12.dtsi 
> b/arch/arm/boot/dts/exynos4x12.dtsi
> index ad531fe..c04418e 100644
> --- a/arch/arm/boot/dts/exynos4x12.dtsi
> +++ b/arch/arm/boot/dts/exynos4x12.dtsi
> @@ -35,6 +35,16 @@
> reg = <0x10023CA0 0x20>;
> };
>
> +   pd_maudio: maudio-power-domain@10023CC0 {
> +   compatible = "samsung,exynos4210-pd";
> +   reg = <0x10023CC0 0x20>;
> +   };
> +
> +   pd_gps_alive: gps-alive-power-domain@10023D04 {
> +   compatible = "samsung,exynos4210-pd";
> +   reg = <0x10023D00 0x20>;

There is mismatch between node name and register value.


-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

2013-10-09 Thread Chanwoo Choi 
This patch maudio/gps_alive power domain to exynos4x12.dtsi.

Signed-off-by: Chanwoo Choi 
Signed-off-by: Kyungmin Park 
---
 arch/arm/boot/dts/exynos4x12.dtsi | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4x12.dtsi 
b/arch/arm/boot/dts/exynos4x12.dtsi
index ad531fe..c04418e 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -35,6 +35,16 @@
reg = <0x10023CA0 0x20>;
};
 
+   pd_maudio: maudio-power-domain@10023CC0 {
+   compatible = "samsung,exynos4210-pd";
+   reg = <0x10023CC0 0x20>;
+   };
+
+   pd_gps_alive: gps-alive-power-domain@10023D04 {
+   compatible = "samsung,exynos4210-pd";
+   reg = <0x10023D00 0x20>;
+   };
+
clock: clock-controller@1003 {
compatible = "samsung,exynos4412-clock";
reg = <0x1003 0x2>;
-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

2013-10-09 Thread Chanwoo Choi 
This patch maudio/gps_alive power domain to exynos4x12.dtsi.

Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
---
 arch/arm/boot/dts/exynos4x12.dtsi | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4x12.dtsi 
b/arch/arm/boot/dts/exynos4x12.dtsi
index ad531fe..c04418e 100644
--- a/arch/arm/boot/dts/exynos4x12.dtsi
+++ b/arch/arm/boot/dts/exynos4x12.dtsi
@@ -35,6 +35,16 @@
reg = 0x10023CA0 0x20;
};
 
+   pd_maudio: maudio-power-domain@10023CC0 {
+   compatible = samsung,exynos4210-pd;
+   reg = 0x10023CC0 0x20;
+   };
+
+   pd_gps_alive: gps-alive-power-domain@10023D04 {
+   compatible = samsung,exynos4210-pd;
+   reg = 0x10023D00 0x20;
+   };
+
clock: clock-controller@1003 {
compatible = samsung,exynos4412-clock;
reg = 0x1003 0x2;
-- 
1.8.0

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

2013-10-09 Thread Sachin Kamat 
On 10 October 2013 06:00, Chanwoo Choi cw00.c...@samsung.com wrote:
 This patch maudio/gps_alive power domain to exynos4x12.dtsi.

 Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
  arch/arm/boot/dts/exynos4x12.dtsi | 10 ++
  1 file changed, 10 insertions(+)

 diff --git a/arch/arm/boot/dts/exynos4x12.dtsi 
 b/arch/arm/boot/dts/exynos4x12.dtsi
 index ad531fe..c04418e 100644
 --- a/arch/arm/boot/dts/exynos4x12.dtsi
 +++ b/arch/arm/boot/dts/exynos4x12.dtsi
 @@ -35,6 +35,16 @@
 reg = 0x10023CA0 0x20;
 };

 +   pd_maudio: maudio-power-domain@10023CC0 {
 +   compatible = samsung,exynos4210-pd;
 +   reg = 0x10023CC0 0x20;
 +   };
 +
 +   pd_gps_alive: gps-alive-power-domain@10023D04 {
 +   compatible = samsung,exynos4210-pd;
 +   reg = 0x10023D00 0x20;

There is mismatch between node name and register value.


-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

2013-10-09 Thread Chanwoo Choi 
On 10/10/2013 12:29 PM, Sachin Kamat wrote:
 On 10 October 2013 06:00, Chanwoo Choi cw00.c...@samsung.com wrote:
 This patch maudio/gps_alive power domain to exynos4x12.dtsi.

 Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
  arch/arm/boot/dts/exynos4x12.dtsi | 10 ++
  1 file changed, 10 insertions(+)

 diff --git a/arch/arm/boot/dts/exynos4x12.dtsi 
 b/arch/arm/boot/dts/exynos4x12.dtsi
 index ad531fe..c04418e 100644
 --- a/arch/arm/boot/dts/exynos4x12.dtsi
 +++ b/arch/arm/boot/dts/exynos4x12.dtsi
 @@ -35,6 +35,16 @@
 reg = 0x10023CA0 0x20;
 };

 +   pd_maudio: maudio-power-domain@10023CC0 {
 +   compatible = samsung,exynos4210-pd;
 +   reg = 0x10023CC0 0x20;
 +   };
 +
 +   pd_gps_alive: gps-alive-power-domain@10023D04 {
 +   compatible = samsung,exynos4210-pd;
 +   reg = 0x10023D00 0x20;
 
 There is mismatch between node name and register value.
 
 
What is exactly mismatch?

I checked the register address of MAUDIO_CONFIGURATION/GPS_ALIVE_CONFIGURATION 
regsiter.
- MAUDIO_CONFIGURATION 0x1002_3CC0
- GPS_ALIVE_CONFIGURATION 0x1002_3D00


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 3/3] ARM: dts: exynos4x12: Add maudio/gps_alive power domain for exynos4x12

2013-10-09 Thread Chanwoo Choi 
On 10/10/2013 01:05 PM, Chanwoo Choi wrote:
 On 10/10/2013 12:29 PM, Sachin Kamat wrote:
 On 10 October 2013 06:00, Chanwoo Choi cw00.c...@samsung.com wrote:
 This patch maudio/gps_alive power domain to exynos4x12.dtsi.

 Signed-off-by: Chanwoo Choi cw00.c...@samsung.com
 Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com
 ---
  arch/arm/boot/dts/exynos4x12.dtsi | 10 ++
  1 file changed, 10 insertions(+)

 diff --git a/arch/arm/boot/dts/exynos4x12.dtsi 
 b/arch/arm/boot/dts/exynos4x12.dtsi
 index ad531fe..c04418e 100644
 --- a/arch/arm/boot/dts/exynos4x12.dtsi
 +++ b/arch/arm/boot/dts/exynos4x12.dtsi
 @@ -35,6 +35,16 @@
 reg = 0x10023CA0 0x20;
 };

 +   pd_maudio: maudio-power-domain@10023CC0 {
 +   compatible = samsung,exynos4210-pd;
 +   reg = 0x10023CC0 0x20;
 +   };
 +
 +   pd_gps_alive: gps-alive-power-domain@10023D04 {
 +   compatible = samsung,exynos4210-pd;
 +   reg = 0x10023D00 0x20;

 There is mismatch between node name and register value.


 What is exactly mismatch?
 
 I checked the register address of 
 MAUDIO_CONFIGURATION/GPS_ALIVE_CONFIGURATION regsiter.
 - MAUDIO_CONFIGURATION 0x1002_3CC0
 - GPS_ALIVE_CONFIGURATION 0x1002_3D00

My mistake. I write wrong address about gps-alive-power-domain.

I will fix it.
- gps-alive-power-domain@10023D04 - gps-alive-power-domain@10023D00

Thanks,
Chanwoo Choi

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/