Re: [PATCH 3/3] ARM: dts: stm32: Fix DT dtc warnings for stm32f4

2018-08-07 Thread Alexandre Torgue 

Hi Patrice

On 08/07/2018 01:06 PM, patrice.chot...@st.com wrote:

From: Patrice Chotard 

Fix the following DT dtc warnings for stm32f429 and
stm32f469 boards:

Warning (node_name_chars_strict): /soc/pin-controller/usbotg_fs@0: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /soc/pin-controller/usbotg_fs@1: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /soc/pin-controller/usbotg_hs@0: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /soc/pin-controller/sdio_pins@0: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /soc/pin-controller/sdio_pins_od@0: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /gpio_keys: Character '_' not recommended in 
node name
Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but 
no unit name
Warning (unit_address_vs_reg): /soc/pin-controller: node has a reg or ranges 
property, but no unit name
Warning (unit_address_vs_reg): /soc/pin-controller/usart1@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/usart3@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/usbotg_fs@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/usbotg_fs@1: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/usbotg_hs@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/mii@0: node has a unit name, 
but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/adc@200: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/pwm@1: node has a unit name, 
but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/pwm@3: node has a unit name, 
but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/i2c1@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/ltdc@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/dcmi@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/sdio_pins@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/sdio_pins_od@0: node has a 
unit name, but no reg property
Warning (unit_address_vs_reg): /gpio_keys/button@0: node has a unit name, but 
no reg property
Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary #address-cells/#size-cells without 
"ranges" or child "reg" property

Signed-off-by: Patrice Chotard 



Same remarks than fot other patches of this series

thx
Alex



---
  arch/arm/boot/dts/stm32429i-eval.dts | 11 +++--
  arch/arm/boot/dts/stm32f4-pinctrl.dtsi   | 30 ++---
  arch/arm/boot/dts/stm32f429-disco.dts|  7 ++-
  arch/arm/boot/dts/stm32f429-pinctrl.dtsi | 74 +++
  arch/arm/boot/dts/stm32f429.dtsi |  8 ++--
  arch/arm/boot/dts/stm32f469-disco.dts| 11 +++--
  arch/arm/boot/dts/stm32f469-pinctrl.dtsi | 76 +++-
  7 files changed, 102 insertions(+), 115 deletions(-)

diff --git a/arch/arm/boot/dts/stm32429i-eval.dts 
b/arch/arm/boot/dts/stm32429i-eval.dts
index 7eb786a2d624..b5af6feb95a4 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -60,7 +60,7 @@
stdout-path = "serial0:115200n8";
};
  
-	memory {

+   memory@0 {
reg = <0x 0x200>;
};
  
@@ -111,17 +111,16 @@

};
};
  
-	gpio_keys {

+   gpio-keys {
compatible = "gpio-keys";
-   #address-cells = <1>;
#size-cells = <0>;
autorepeat;
-   button@0 {
+   button0 {
label = "Wake up";
linux,code = ;
gpios = <&gpioa 0 0>;
};
-   button@1 {
+   button1 {
label = "Tamper";
linux,code = ;
gpios = <&gpioc 13 0>;
@@ -145,7 +144,7 @@
};
};
  
-	mmc_vcard: mmc_vcard {

+   mmc_vcard: mmc-vcard {
compatible = "regulator-fixed";
regulator-name = "mmc_vcard";
regulator-min-microvolt = <330>;
diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi 
b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 35202896c093..73061fee60f6 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -45,7 +45,7 @@
  
  / {

soc {
-   pinctrl: pin-controller {
+   pinctrl: pin-controller@4002 {
#address-cells = <1>;
#size-cells = <1>;

[PATCH 3/3] ARM: dts: stm32: Fix DT dtc warnings for stm32f4

2018-08-07 Thread patrice.chotard 
From: Patrice Chotard 

Fix the following DT dtc warnings for stm32f429 and
stm32f469 boards:

Warning (node_name_chars_strict): /soc/pin-controller/usbotg_fs@0: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /soc/pin-controller/usbotg_fs@1: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /soc/pin-controller/usbotg_hs@0: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /soc/pin-controller/sdio_pins@0: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /soc/pin-controller/sdio_pins_od@0: Character 
'_' not recommended in node name
Warning (node_name_chars_strict): /gpio_keys: Character '_' not recommended in 
node name
Warning (unit_address_vs_reg): /memory: node has a reg or ranges property, but 
no unit name
Warning (unit_address_vs_reg): /soc/pin-controller: node has a reg or ranges 
property, but no unit name
Warning (unit_address_vs_reg): /soc/pin-controller/usart1@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/usart3@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/usbotg_fs@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/usbotg_fs@1: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/usbotg_hs@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/mii@0: node has a unit name, 
but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/adc@200: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/pwm@1: node has a unit name, 
but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/pwm@3: node has a unit name, 
but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/i2c1@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/ltdc@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/dcmi@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/sdio_pins@0: node has a unit 
name, but no reg property
Warning (unit_address_vs_reg): /soc/pin-controller/sdio_pins_od@0: node has a 
unit name, but no reg property
Warning (unit_address_vs_reg): /gpio_keys/button@0: node has a unit name, but 
no reg property
Warning (avoid_unnecessary_addr_size): /gpio_keys: unnecessary 
#address-cells/#size-cells without "ranges" or child "reg" property

Signed-off-by: Patrice Chotard 
---
 arch/arm/boot/dts/stm32429i-eval.dts | 11 +++--
 arch/arm/boot/dts/stm32f4-pinctrl.dtsi   | 30 ++---
 arch/arm/boot/dts/stm32f429-disco.dts|  7 ++-
 arch/arm/boot/dts/stm32f429-pinctrl.dtsi | 74 +++
 arch/arm/boot/dts/stm32f429.dtsi |  8 ++--
 arch/arm/boot/dts/stm32f469-disco.dts| 11 +++--
 arch/arm/boot/dts/stm32f469-pinctrl.dtsi | 76 +++-
 7 files changed, 102 insertions(+), 115 deletions(-)

diff --git a/arch/arm/boot/dts/stm32429i-eval.dts 
b/arch/arm/boot/dts/stm32429i-eval.dts
index 7eb786a2d624..b5af6feb95a4 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -60,7 +60,7 @@
stdout-path = "serial0:115200n8";
};
 
-   memory {
+   memory@0 {
reg = <0x 0x200>;
};
 
@@ -111,17 +111,16 @@
};
};
 
-   gpio_keys {
+   gpio-keys {
compatible = "gpio-keys";
-   #address-cells = <1>;
#size-cells = <0>;
autorepeat;
-   button@0 {
+   button0 {
label = "Wake up";
linux,code = ;
gpios = <&gpioa 0 0>;
};
-   button@1 {
+   button1 {
label = "Tamper";
linux,code = ;
gpios = <&gpioc 13 0>;
@@ -145,7 +144,7 @@
};
};
 
-   mmc_vcard: mmc_vcard {
+   mmc_vcard: mmc-vcard {
compatible = "regulator-fixed";
regulator-name = "mmc_vcard";
regulator-min-microvolt = <330>;
diff --git a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi 
b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
index 35202896c093..73061fee60f6 100644
--- a/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stm32f4-pinctrl.dtsi
@@ -45,7 +45,7 @@
 
 / {
soc {
-   pinctrl: pin-controller {
+   pinctrl: pin-controller@4002 {
#address-cells = <1>;
#size-cells = <1>;
ranges = <0 0x4002 0x3000>;
@@ -163,7 +163,7 @@
st,bank-name = "GPIOK";