Re: [PATCH 3/4] arm64: dts: meson: axg: add clk measure support

[Jerome Brunet]

On Thu, 2019-01-17 at 20:57 +0100, Martin Blumenstingl wrote:
> Hi Jerome,
> 
> On Thu, Jan 17, 2019 at 5:48 PM Jerome Brunet  wrote:
> > Add the clock measure device to the axg SoC family
> > 
> > Signed-off-by: Jerome Brunet 
> > ---
> >  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 5 +
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> > b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> > index 0e0abb1a03e2..94ea36a2417a 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> > +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> > @@ -1611,6 +1611,11 @@
> > status = "disabled";
> > };
> > 
> > +   clk_msr: clock-sensor@18000 {
> in the dt-bindings specify "clock-measure@..."

That's the exemple, not a specification, AFAIK.
I'm not sure I see the problem ?

> this also applies to patch 4/4 from this series


Anyway, The node was not placed correctly in g12, I might as well rename it. I
don't really care

> 
> 
> [0] 
> https://elixir.bootlin.com/linux/v5.0-rc1/source/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt

Re: [PATCH 3/4] arm64: dts: meson: axg: add clk measure support

[Martin Blumenstingl]

Hi Jerome,

On Thu, Jan 17, 2019 at 5:48 PM Jerome Brunet  wrote:
>
> Add the clock measure device to the axg SoC family
>
> Signed-off-by: Jerome Brunet 
> ---
>  arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 5 +
>  1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi 
> b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 0e0abb1a03e2..94ea36a2417a 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -1611,6 +1611,11 @@
> status = "disabled";
> };
>
> +   clk_msr: clock-sensor@18000 {
in the dt-bindings specify "clock-measure@..."
this also applies to patch 4/4 from this series


[0] 
https://elixir.bootlin.com/linux/v5.0-rc1/source/Documentation/devicetree/bindings/soc/amlogic/clk-measure.txt

[PATCH 3/4] arm64: dts: meson: axg: add clk measure support

[Jerome Brunet]

Add the clock measure device to the axg SoC family

Signed-off-by: Jerome Brunet 
---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 5 +
 1 file changed, 5 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi 
b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 0e0abb1a03e2..94ea36a2417a 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -1611,6 +1611,11 @@
status = "disabled";
};
 
+   clk_msr: clock-sensor@18000 {
+   compatible = "amlogic,meson-axg-clk-measure";
+   reg = <0x0 0x18000 0x0 0x10>;
+   };
+
i2c3: i2c@1c000 {
compatible = "amlogic,meson-axg-i2c";
reg = <0x0 0x1c000 0x0 0x20>;
-- 
2.20.1