Re: [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy
On Wed, Apr 14, 2021 at 1:49 AM Aswath Govindraju wrote: > > Hi Rob, > > On 12/04/21 11:21 pm, Rob Herring wrote: > > On Fri, Apr 09, 2021 at 07:10:53PM +0530, Aswath Govindraju wrote: > >> From: Faiz Abbas > >> > >> Some transceivers need a configuration step (for example, pulling the > >> standby or enable lines) for them to start sending messages. The > >> transceiver can be implemented as a phy with the configuration done in the > >> phy driver. The bit rate limitation can the be obtained by the driver using > >> the phy node. > >> > >> Document the above implementation in the bosch mcan bindings > >> > >> Signed-off-by: Faiz Abbas > >> Signed-off-by: Aswath Govindraju > >> --- > >> Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 6 ++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > >> b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > >> index 798fa5fb7bb2..2c01899b1a3e 100644 > >> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > >> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > >> @@ -109,6 +109,12 @@ properties: > >>can-transceiver: > >> $ref: can-transceiver.yaml# > >> > >> + phys: > >> +minItems: 1 > > > > maxItems: 1 > > Will add this in the respin. > > > > >> + > >> + phy-names: > >> +const: can_transceiver > > > > Kind of a pointless name. You don't really need a name if there's a > > single entry. > > > > This name used by devm_phy_optional_get() in m_can driver to get the phy > data structure. With no name, you'll get the 1st one. Looks like the phy subsystem warns on this. That's wrong, so please fix that. Rob
Re: [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy
Hi Rob, On 12/04/21 11:21 pm, Rob Herring wrote: > On Fri, Apr 09, 2021 at 07:10:53PM +0530, Aswath Govindraju wrote: >> From: Faiz Abbas >> >> Some transceivers need a configuration step (for example, pulling the >> standby or enable lines) for them to start sending messages. The >> transceiver can be implemented as a phy with the configuration done in the >> phy driver. The bit rate limitation can the be obtained by the driver using >> the phy node. >> >> Document the above implementation in the bosch mcan bindings >> >> Signed-off-by: Faiz Abbas >> Signed-off-by: Aswath Govindraju >> --- >> Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 6 ++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml >> b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml >> index 798fa5fb7bb2..2c01899b1a3e 100644 >> --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml >> +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml >> @@ -109,6 +109,12 @@ properties: >>can-transceiver: >> $ref: can-transceiver.yaml# >> >> + phys: >> +minItems: 1 > > maxItems: 1 Will add this in the respin. > >> + >> + phy-names: >> +const: can_transceiver > > Kind of a pointless name. You don't really need a name if there's a > single entry. > This name used by devm_phy_optional_get() in m_can driver to get the phy data structure. Thank you for the review. Regards, Aswath >> + >> required: >>- compatible >>- reg >> -- >> 2.17.1 >>
Re: [PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy
On Fri, Apr 09, 2021 at 07:10:53PM +0530, Aswath Govindraju wrote: > From: Faiz Abbas > > Some transceivers need a configuration step (for example, pulling the > standby or enable lines) for them to start sending messages. The > transceiver can be implemented as a phy with the configuration done in the > phy driver. The bit rate limitation can the be obtained by the driver using > the phy node. > > Document the above implementation in the bosch mcan bindings > > Signed-off-by: Faiz Abbas > Signed-off-by: Aswath Govindraju > --- > Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > index 798fa5fb7bb2..2c01899b1a3e 100644 > --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml > @@ -109,6 +109,12 @@ properties: >can-transceiver: > $ref: can-transceiver.yaml# > > + phys: > +minItems: 1 maxItems: 1 > + > + phy-names: > +const: can_transceiver Kind of a pointless name. You don't really need a name if there's a single entry. > + > required: >- compatible >- reg > -- > 2.17.1 >
[PATCH 3/4] dt-bindings: net: can: Document transceiver implementation as phy
From: Faiz Abbas Some transceivers need a configuration step (for example, pulling the standby or enable lines) for them to start sending messages. The transceiver can be implemented as a phy with the configuration done in the phy driver. The bit rate limitation can the be obtained by the driver using the phy node. Document the above implementation in the bosch mcan bindings Signed-off-by: Faiz Abbas Signed-off-by: Aswath Govindraju --- Documentation/devicetree/bindings/net/can/bosch,m_can.yaml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml index 798fa5fb7bb2..2c01899b1a3e 100644 --- a/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml +++ b/Documentation/devicetree/bindings/net/can/bosch,m_can.yaml @@ -109,6 +109,12 @@ properties: can-transceiver: $ref: can-transceiver.yaml# + phys: +minItems: 1 + + phy-names: +const: can_transceiver + required: - compatible - reg -- 2.17.1
