[PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range

[Nicholas Piggin]

iounmap will remove ptes.

Cc: "Cédric Le Goater" 
Cc: linuxppc-...@lists.ozlabs.org
Signed-off-by: Nicholas Piggin 
---
 arch/powerpc/sysdev/xive/common.c | 4 
 1 file changed, 4 deletions(-)

diff --git a/arch/powerpc/sysdev/xive/common.c 
b/arch/powerpc/sysdev/xive/common.c
index 595310e056f4..d6c2069cc828 100644
--- a/arch/powerpc/sysdev/xive/common.c
+++ b/arch/powerpc/sysdev/xive/common.c
@@ -959,16 +959,12 @@ EXPORT_SYMBOL_GPL(is_xive_irq);
 void xive_cleanup_irq_data(struct xive_irq_data *xd)
 {
if (xd->eoi_mmio) {
-   unmap_kernel_range((unsigned long)xd->eoi_mmio,
-  1u << xd->esb_shift);
iounmap(xd->eoi_mmio);
if (xd->eoi_mmio == xd->trig_mmio)
xd->trig_mmio = NULL;
xd->eoi_mmio = NULL;
}
if (xd->trig_mmio) {
-   unmap_kernel_range((unsigned long)xd->trig_mmio,
-  1u << xd->esb_shift);
iounmap(xd->trig_mmio);
xd->trig_mmio = NULL;
}
-- 
2.23.0

Re: [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range

[Christoph Hellwig]

On Tue, Jan 26, 2021 at 02:54:02PM +1000, Nicholas Piggin wrote:
> iounmap will remove ptes.

Looks good,

Reviewed-by: Christoph Hellwig 

Re: [PATCH 3/5] powerpc/xive: remove unnecessary unmap_kernel_range

[Cédric Le Goater]

On 1/26/21 5:54 AM, Nicholas Piggin wrote:
> iounmap will remove ptes.
> 
> Cc: "Cédric Le Goater" 
> Cc: linuxppc-...@lists.ozlabs.org
> Signed-off-by: Nicholas Piggin 

Looks good. 

Acked-by: Cédric Le Goater 

Thanks,

C. 

> ---
>  arch/powerpc/sysdev/xive/common.c | 4 
>  1 file changed, 4 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/xive/common.c 
> b/arch/powerpc/sysdev/xive/common.c
> index 595310e056f4..d6c2069cc828 100644
> --- a/arch/powerpc/sysdev/xive/common.c
> +++ b/arch/powerpc/sysdev/xive/common.c
> @@ -959,16 +959,12 @@ EXPORT_SYMBOL_GPL(is_xive_irq);
>  void xive_cleanup_irq_data(struct xive_irq_data *xd)
>  {
>   if (xd->eoi_mmio) {
> - unmap_kernel_range((unsigned long)xd->eoi_mmio,
> -1u << xd->esb_shift);
>   iounmap(xd->eoi_mmio);
>   if (xd->eoi_mmio == xd->trig_mmio)
>   xd->trig_mmio = NULL;
>   xd->eoi_mmio = NULL;
>   }
>   if (xd->trig_mmio) {
> - unmap_kernel_range((unsigned long)xd->trig_mmio,
> -1u << xd->esb_shift);
>   iounmap(xd->trig_mmio);
>   xd->trig_mmio = NULL;
>   }
>