Re: [PATCH 3/6] arm64: dts: imx8mq: Add interconnect for lcdif

2020-12-01 Thread Lucas Stach
Am Dienstag, den 01.12.2020, 11:01 +0100 schrieb Martin Kepplinger:
> Add interconnect ports for lcdif to set bus capabilities.
> 
> Signed-off-by: Martin Kepplinger 
> ---
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi 
> b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 244e28e54b35..7384a69ed36c 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -11,6 +11,7 @@
>  #include "dt-bindings/input/input.h"
>  #include 
>  #include 
> +#include 
>  #include "imx8mq-pinfunc.h"
>  
> 
> 
> 
>  / {
> @@ -522,6 +523,8 @@
>     <&clk IMX8MQ_VIDEO_PLL1>,
>     <&clk IMX8MQ_VIDEO_PLL1_OUT>;
>   assigned-clock-rates = <0>, <0>, <0>, 
> <59400>;
> + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc 
> IMX8MQ_ICS_DRAM>;
> + interconnect-names = "lcdif-dram";

This needs to be documented in the binding. Also I would argue that you
can drop the lcdif prefix in the name, as it's part of the lcdif DT
node.

Regards,
Lucas

>   status = "disabled";
>  
> 
> 
> 
>   port@0 {




[PATCH 3/6] arm64: dts: imx8mq: Add interconnect for lcdif

2020-12-01 Thread Martin Kepplinger
Add interconnect ports for lcdif to set bus capabilities.

Signed-off-by: Martin Kepplinger 
---
 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi 
b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 244e28e54b35..7384a69ed36c 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -11,6 +11,7 @@
 #include "dt-bindings/input/input.h"
 #include 
 #include 
+#include 
 #include "imx8mq-pinfunc.h"
 
 / {
@@ -522,6 +523,8 @@
  <&clk IMX8MQ_VIDEO_PLL1>,
  <&clk IMX8MQ_VIDEO_PLL1_OUT>;
assigned-clock-rates = <0>, <0>, <0>, 
<59400>;
+   interconnects = <&noc IMX8MQ_ICM_LCDIF &noc 
IMX8MQ_ICS_DRAM>;
+   interconnect-names = "lcdif-dram";
status = "disabled";
 
port@0 {
-- 
2.20.1