Re: [PATCH 3/8] arm64: dts: qcom: sdm630: Add tsens node

2020-06-24 Thread Amit Kucheria 
On Wed, Jun 24, 2020 at 8:32 PM Konrad Dybcio  wrote:
>
> Interesting, the downstream DTS only mentions the 0x010AD one..
> Are you sure you're not looking at 636/660?
>

I looked a bit closer. So there are two instances of the controller
but the platform doesn't have as many sensors. So using just one
controller is fine. I suspect the other controller might be disabled
in firmware.

Regards,
Amit

Re: [PATCH 3/8] arm64: dts: qcom: sdm630: Add tsens node

2020-06-24 Thread Konrad Dybcio 
Interesting, the downstream DTS only mentions the 0x010AD one..
Are you sure you're not looking at 636/660?

Regards
Konrad

Re: [PATCH 3/8] arm64: dts: qcom: sdm630: Add tsens node

2020-06-24 Thread Amit Kucheria 
On Tue, Jun 23, 2020 at 11:39 PM Konrad Dybcio  wrote:
>
> Enable tsens on this SoC using tsens-v2 driver.
>
> Signed-off-by: Konrad Dybcio 
> ---
>  .../devicetree/bindings/thermal/qcom-tsens.yaml   |  1 +
>  arch/arm64/boot/dts/qcom/sdm630.dtsi  | 11 +++
>  2 files changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml 
> b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> index d7be931b42d2..d89d5acd6e2a 100644
> --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
> @@ -39,6 +39,7 @@ properties:
>- qcom,msm8996-tsens
>- qcom,msm8998-tsens
>- qcom,sc7180-tsens
> +  - qcom,sdm630-tsens
>- qcom,sdm845-tsens
>- const: qcom,tsens-v2
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi 
> b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index ea85f28032d2..92bf4ae6a590 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -566,6 +566,17 @@ anoc2_smmu: iommu@16c {
> ;
> };
>
> +   tsens: thermal-sensor@10ae000 {
> +   compatible = "qcom,sdm630-tsens", "qcom,tsens-v2";
> +   reg = <0x010ae000 0x1000>, /* TM */
> + <0x010ad000 0x1000>; /* SROT */
> +   #qcom,sensors = <12>;
> +   interrupts = ,
> +;
> +   interrupt-names = "uplow", "critical";
> +   #thermal-sensor-cells = <1>;
> +   };
> +

There should be 2 tsens controllers on this platform, the first at
0x010AA000, the other at 0x010AD000.

> tcsr_mutex_regs: syscon@1f4 {
> compatible = "syscon";
> reg = <0x01f4 0x2>;
> --
> 2.27.0
>

[PATCH 3/8] arm64: dts: qcom: sdm630: Add tsens node

2020-06-23 Thread Konrad Dybcio 
Enable tsens on this SoC using tsens-v2 driver.

Signed-off-by: Konrad Dybcio 
---
 .../devicetree/bindings/thermal/qcom-tsens.yaml   |  1 +
 arch/arm64/boot/dts/qcom/sdm630.dtsi  | 11 +++
 2 files changed, 12 insertions(+)

diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml 
b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
index d7be931b42d2..d89d5acd6e2a 100644
--- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
+++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml
@@ -39,6 +39,7 @@ properties:
   - qcom,msm8996-tsens
   - qcom,msm8998-tsens
   - qcom,sc7180-tsens
+  - qcom,sdm630-tsens
   - qcom,sdm845-tsens
   - const: qcom,tsens-v2
 
diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi 
b/arch/arm64/boot/dts/qcom/sdm630.dtsi
index ea85f28032d2..92bf4ae6a590 100644
--- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
@@ -566,6 +566,17 @@ anoc2_smmu: iommu@16c {
;
};
 
+   tsens: thermal-sensor@10ae000 {
+   compatible = "qcom,sdm630-tsens", "qcom,tsens-v2";
+   reg = <0x010ae000 0x1000>, /* TM */
+ <0x010ad000 0x1000>; /* SROT */
+   #qcom,sensors = <12>;
+   interrupts = ,
+;
+   interrupt-names = "uplow", "critical";
+   #thermal-sensor-cells = <1>;
+   };
+
tcsr_mutex_regs: syscon@1f4 {
compatible = "syscon";
reg = <0x01f4 0x2>;
-- 
2.27.0