Re: [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis
On Wed, Aug 26, 2015 at 11:52:12AM +0800, Peng Sun wrote: > Signed-off-by: Peng Sun Please always add a changelog message. Also, you need to fix the subject. The convention is to use something like: "a: b: ..." So in this case it should be something like: "staging: android: ..." You can look at `git log drivers/staging/android` for inspiration. This applies to all of your other patches as well. Finally, I don't think there is a point in using deep threading in this case. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis
On Wed, Aug 26, 2015 at 11:52:12AM +0800, Peng Sun wrote: Signed-off-by: Peng Sun sironhide0n...@gmail.com Please always add a changelog message. Also, you need to fix the subject. The convention is to use something like: a: b: ... So in this case it should be something like: staging: android: ... You can look at `git log drivers/staging/android` for inspiration. This applies to all of your other patches as well. Finally, I don't think there is a point in using deep threading in this case. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis
Signed-off-by: Peng Sun --- drivers/staging/android/ashmem.c | 8 drivers/staging/android/lowmemorykiller.c | 4 ++-- drivers/staging/android/sync.c| 4 ++-- drivers/staging/android/sync.h| 2 +- drivers/staging/android/timed_gpio.c | 12 +++- 5 files changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index 1312600..d786ec1 100644 --- a/drivers/staging/android/ashmem.c +++ b/drivers/staging/android/ashmem.c @@ -834,16 +834,16 @@ static int __init ashmem_init(void) int ret; ashmem_area_cachep = kmem_cache_create("ashmem_area_cache", - sizeof(struct ashmem_area), - 0, 0, NULL); + sizeof(struct ashmem_area), + 0, 0, NULL); if (unlikely(!ashmem_area_cachep)) { pr_err("failed to create slab cache\n"); return -ENOMEM; } ashmem_range_cachep = kmem_cache_create("ashmem_range_cache", - sizeof(struct ashmem_range), - 0, 0, NULL); + sizeof(struct ashmem_range), + 0, 0, NULL); if (unlikely(!ashmem_range_cachep)) { pr_err("failed to create slab cache\n"); return -ENOMEM; diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c index 872bd60..61937ab 100644 --- a/drivers/staging/android/lowmemorykiller.c +++ b/drivers/staging/android/lowmemorykiller.c @@ -104,8 +104,8 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc) } lowmem_print(3, "lowmem_scan %lu, %x, ofree %d %d, ma %hd\n", - sc->nr_to_scan, sc->gfp_mask, other_free, - other_file, min_score_adj); +sc->nr_to_scan, sc->gfp_mask, other_free, +other_file, min_score_adj); if (min_score_adj == OOM_SCORE_ADJ_MAX + 1) { lowmem_print(5, "lowmem_scan %lu, %x, return 0\n", diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index f83e00c..9a67d23 100644 --- a/drivers/staging/android/sync.c +++ b/drivers/staging/android/sync.c @@ -313,7 +313,7 @@ struct sync_fence *sync_fence_merge(const char *name, EXPORT_SYMBOL(sync_fence_merge); int sync_fence_wake_up_wq(wait_queue_t *curr, unsigned mode, -int wake_flags, void *key) + int wake_flags, void *key) { struct sync_fence_waiter *wait; @@ -353,7 +353,7 @@ int sync_fence_wait_async(struct sync_fence *fence, EXPORT_SYMBOL(sync_fence_wait_async); int sync_fence_cancel_async(struct sync_fence *fence, -struct sync_fence_waiter *waiter) + struct sync_fence_waiter *waiter) { unsigned long flags; int ret = 0; diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h index 61f8a3a..18a94ed 100644 --- a/drivers/staging/android/sync.h +++ b/drivers/staging/android/sync.h @@ -351,6 +351,6 @@ void sync_dump(void); # define sync_dump() #endif int sync_fence_wake_up_wq(wait_queue_t *curr, unsigned mode, -int wake_flags, void *key); + int wake_flags, void *key); #endif /* _LINUX_SYNC_H */ diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c index ce11726..5407257 100644 --- a/drivers/staging/android/timed_gpio.c +++ b/drivers/staging/android/timed_gpio.c @@ -76,8 +76,9 @@ static void gpio_enable(struct timed_output_dev *dev, int value) value = data->max_timeout; hrtimer_start(>timer, - ktime_set(value / 1000, (value % 1000) * 100), - HRTIMER_MODE_REL); + ktime_set(value / 1000, (value % 1000) * + 100), + HRTIMER_MODE_REL); } spin_unlock_irqrestore(>lock, flags); @@ -94,8 +95,9 @@ static int timed_gpio_probe(struct platform_device *pdev) return -EBUSY; gpio_data = devm_kzalloc(>dev, - sizeof(struct timed_gpio_data) * pdata->num_gpios, - GFP_KERNEL); +sizeof(struct timed_gpio_data) * +pdata->num_gpios, +GFP_KERNEL); if (!gpio_data) return -ENOMEM; @@ -104,7 +106,7 @@ static int timed_gpio_probe(struct platform_device *pdev) gpio_dat = _data[i];
[PATCH 3/8] fix staging:android style issue:Alignment should match open parenthesis
Signed-off-by: Peng Sun sironhide0n...@gmail.com --- drivers/staging/android/ashmem.c | 8 drivers/staging/android/lowmemorykiller.c | 4 ++-- drivers/staging/android/sync.c| 4 ++-- drivers/staging/android/sync.h| 2 +- drivers/staging/android/timed_gpio.c | 12 +++- 5 files changed, 16 insertions(+), 14 deletions(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index 1312600..d786ec1 100644 --- a/drivers/staging/android/ashmem.c +++ b/drivers/staging/android/ashmem.c @@ -834,16 +834,16 @@ static int __init ashmem_init(void) int ret; ashmem_area_cachep = kmem_cache_create(ashmem_area_cache, - sizeof(struct ashmem_area), - 0, 0, NULL); + sizeof(struct ashmem_area), + 0, 0, NULL); if (unlikely(!ashmem_area_cachep)) { pr_err(failed to create slab cache\n); return -ENOMEM; } ashmem_range_cachep = kmem_cache_create(ashmem_range_cache, - sizeof(struct ashmem_range), - 0, 0, NULL); + sizeof(struct ashmem_range), + 0, 0, NULL); if (unlikely(!ashmem_range_cachep)) { pr_err(failed to create slab cache\n); return -ENOMEM; diff --git a/drivers/staging/android/lowmemorykiller.c b/drivers/staging/android/lowmemorykiller.c index 872bd60..61937ab 100644 --- a/drivers/staging/android/lowmemorykiller.c +++ b/drivers/staging/android/lowmemorykiller.c @@ -104,8 +104,8 @@ static unsigned long lowmem_scan(struct shrinker *s, struct shrink_control *sc) } lowmem_print(3, lowmem_scan %lu, %x, ofree %d %d, ma %hd\n, - sc-nr_to_scan, sc-gfp_mask, other_free, - other_file, min_score_adj); +sc-nr_to_scan, sc-gfp_mask, other_free, +other_file, min_score_adj); if (min_score_adj == OOM_SCORE_ADJ_MAX + 1) { lowmem_print(5, lowmem_scan %lu, %x, return 0\n, diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index f83e00c..9a67d23 100644 --- a/drivers/staging/android/sync.c +++ b/drivers/staging/android/sync.c @@ -313,7 +313,7 @@ struct sync_fence *sync_fence_merge(const char *name, EXPORT_SYMBOL(sync_fence_merge); int sync_fence_wake_up_wq(wait_queue_t *curr, unsigned mode, -int wake_flags, void *key) + int wake_flags, void *key) { struct sync_fence_waiter *wait; @@ -353,7 +353,7 @@ int sync_fence_wait_async(struct sync_fence *fence, EXPORT_SYMBOL(sync_fence_wait_async); int sync_fence_cancel_async(struct sync_fence *fence, -struct sync_fence_waiter *waiter) + struct sync_fence_waiter *waiter) { unsigned long flags; int ret = 0; diff --git a/drivers/staging/android/sync.h b/drivers/staging/android/sync.h index 61f8a3a..18a94ed 100644 --- a/drivers/staging/android/sync.h +++ b/drivers/staging/android/sync.h @@ -351,6 +351,6 @@ void sync_dump(void); # define sync_dump() #endif int sync_fence_wake_up_wq(wait_queue_t *curr, unsigned mode, -int wake_flags, void *key); + int wake_flags, void *key); #endif /* _LINUX_SYNC_H */ diff --git a/drivers/staging/android/timed_gpio.c b/drivers/staging/android/timed_gpio.c index ce11726..5407257 100644 --- a/drivers/staging/android/timed_gpio.c +++ b/drivers/staging/android/timed_gpio.c @@ -76,8 +76,9 @@ static void gpio_enable(struct timed_output_dev *dev, int value) value = data-max_timeout; hrtimer_start(data-timer, - ktime_set(value / 1000, (value % 1000) * 100), - HRTIMER_MODE_REL); + ktime_set(value / 1000, (value % 1000) * + 100), + HRTIMER_MODE_REL); } spin_unlock_irqrestore(data-lock, flags); @@ -94,8 +95,9 @@ static int timed_gpio_probe(struct platform_device *pdev) return -EBUSY; gpio_data = devm_kzalloc(pdev-dev, - sizeof(struct timed_gpio_data) * pdata-num_gpios, - GFP_KERNEL); +sizeof(struct timed_gpio_data) * +pdata-num_gpios, +GFP_KERNEL); if (!gpio_data) return -ENOMEM; @@ -104,7 +106,7 @@ static int timed_gpio_probe(struct platform_device *pdev) gpio_dat = gpio_data[i];