[PATCH 3.14 36/73] TPM: Add new TPMs to the tail of the list to prevent inadvertent change of dev
3.14-stable review patch. If anyone has any objections, please let me know. -- From: David Howells commit 398a1e71dc827b994b7f2f56c7c2186fea7f8d75 upstream. Add newly registered TPMs to the tail of the list, not the beginning, so that things that are specifying TPM_ANY_NUM don't find that the device they're using has inadvertently changed. Adding a second device would break IMA, for instance. Signed-off-by: David Howells Reviewed-by: Jason Gunthorpe Signed-off-by: Peter Huewe Signed-off-by: Greg Kroah-Hartman --- drivers/char/tpm/tpm-interface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/char/tpm/tpm-interface.c +++ b/drivers/char/tpm/tpm-interface.c @@ -1122,7 +1122,7 @@ struct tpm_chip *tpm_register_hardware(s /* Make chip available */ spin_lock(_lock); - list_add_rcu(>list, _chip_list); + list_add_tail_rcu(>list, _chip_list); spin_unlock(_lock); return chip; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3.14 36/73] TPM: Add new TPMs to the tail of the list to prevent inadvertent change of dev
3.14-stable review patch. If anyone has any objections, please let me know. -- From: David Howells dhowe...@redhat.com commit 398a1e71dc827b994b7f2f56c7c2186fea7f8d75 upstream. Add newly registered TPMs to the tail of the list, not the beginning, so that things that are specifying TPM_ANY_NUM don't find that the device they're using has inadvertently changed. Adding a second device would break IMA, for instance. Signed-off-by: David Howells dhowe...@redhat.com Reviewed-by: Jason Gunthorpe jguntho...@obsidianresearch.com Signed-off-by: Peter Huewe peterhu...@gmx.de Signed-off-by: Greg Kroah-Hartman gre...@linuxfoundation.org --- drivers/char/tpm/tpm-interface.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/char/tpm/tpm-interface.c +++ b/drivers/char/tpm/tpm-interface.c @@ -1122,7 +1122,7 @@ struct tpm_chip *tpm_register_hardware(s /* Make chip available */ spin_lock(driver_lock); - list_add_rcu(chip-list, tpm_chip_list); + list_add_tail_rcu(chip-list, tpm_chip_list); spin_unlock(driver_lock); return chip; -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
