[PATCH 3.16.y-ckt 007/165] flowcache: Fix kernel panic in flow_cache_flush_task

2015-03-25 Thread Luis Henriques
3.16.7-ckt9 -stable review patch.  If anyone has any objections, please let me 
know.

--

From: Miroslav Urbanek 

commit 233c96fc077d310772375d47522fb444ff546905 upstream.

flow_cache_flush_task references a structure member flow_cache_gc_work
where it should reference flow_cache_flush_task instead.

Kernel panic occurs on kernels using IPsec during XFRM garbage
collection. The garbage collection interval can be shortened using the
following sysctl settings:

net.ipv4.xfrm4_gc_thresh=4
net.ipv6.xfrm6_gc_thresh=4

With the default settings, our productions servers crash approximately
once a week. With the settings above, they crash immediately.

Fixes: ca925cf1534e ("flowcache: Make flow cache name space aware")
Reported-by: Tomáš Charvát 
Tested-by: Jan Hejl 
Signed-off-by: Miroslav Urbanek 
Acked-by: Eric Dumazet 
Signed-off-by: David S. Miller 
Signed-off-by: Luis Henriques 
---
 net/core/flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/flow.c b/net/core/flow.c
index a0348fde1fdf..1033725be40b 100644
--- a/net/core/flow.c
+++ b/net/core/flow.c
@@ -379,7 +379,7 @@ done:
 static void flow_cache_flush_task(struct work_struct *work)
 {
struct netns_xfrm *xfrm = container_of(work, struct netns_xfrm,
-   flow_cache_gc_work);
+   flow_cache_flush_work);
struct net *net = container_of(xfrm, struct net, xfrm);
 
flow_cache_flush(net);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 3.16.y-ckt 007/165] flowcache: Fix kernel panic in flow_cache_flush_task

2015-03-25 Thread Luis Henriques
3.16.7-ckt9 -stable review patch.  If anyone has any objections, please let me 
know.

--

From: Miroslav Urbanek m...@miroslavurbanek.com

commit 233c96fc077d310772375d47522fb444ff546905 upstream.

flow_cache_flush_task references a structure member flow_cache_gc_work
where it should reference flow_cache_flush_task instead.

Kernel panic occurs on kernels using IPsec during XFRM garbage
collection. The garbage collection interval can be shortened using the
following sysctl settings:

net.ipv4.xfrm4_gc_thresh=4
net.ipv6.xfrm6_gc_thresh=4

With the default settings, our productions servers crash approximately
once a week. With the settings above, they crash immediately.

Fixes: ca925cf1534e (flowcache: Make flow cache name space aware)
Reported-by: Tomáš Charvát t...@excello.cz
Tested-by: Jan Hejl j...@excello.cz
Signed-off-by: Miroslav Urbanek m...@miroslavurbanek.com
Acked-by: Eric Dumazet eduma...@google.com
Signed-off-by: David S. Miller da...@davemloft.net
Signed-off-by: Luis Henriques luis.henriq...@canonical.com
---
 net/core/flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/flow.c b/net/core/flow.c
index a0348fde1fdf..1033725be40b 100644
--- a/net/core/flow.c
+++ b/net/core/flow.c
@@ -379,7 +379,7 @@ done:
 static void flow_cache_flush_task(struct work_struct *work)
 {
struct netns_xfrm *xfrm = container_of(work, struct netns_xfrm,
-   flow_cache_gc_work);
+   flow_cache_flush_work);
struct net *net = container_of(xfrm, struct net, xfrm);
 
flow_cache_flush(net);
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/