[PATCH 3.2 009/102] regmap: if format_write is used, declare all registers as "unreadable"
3.2.64-rc1 review patch. If anyone has any objections, please let me know. -- From: Wolfram Sang commit 4191f19792bf91267835eb090d970e9cd6277a65 upstream. Using .format_write means, we have a custom function to write to the chip, but not to read back. Also, mark registers as "not precious" and "not volatile" which is implicit because we cannot read them. Make those functions use 'regmap_readable' to reuse the checks done there. Signed-off-by: Wolfram Sang Signed-off-by: Mark Brown Signed-off-by: Ben Hutchings --- drivers/base/regmap/regmap.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -36,6 +36,9 @@ bool regmap_readable(struct regmap *map, if (map->max_register && reg > map->max_register) return false; + if (map->format.format_write) + return false; + if (map->readable_reg) return map->readable_reg(map->dev, reg); @@ -44,7 +47,7 @@ bool regmap_readable(struct regmap *map, bool regmap_volatile(struct regmap *map, unsigned int reg) { - if (map->max_register && reg > map->max_register) + if (!regmap_readable(map, reg)) return false; if (map->volatile_reg) @@ -55,7 +58,7 @@ bool regmap_volatile(struct regmap *map, bool regmap_precious(struct regmap *map, unsigned int reg) { - if (map->max_register && reg > map->max_register) + if (!regmap_readable(map, reg)) return false; if (map->precious_reg) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 3.2 009/102] regmap: if format_write is used, declare all registers as unreadable
3.2.64-rc1 review patch. If anyone has any objections, please let me know. -- From: Wolfram Sang w.s...@pengutronix.de commit 4191f19792bf91267835eb090d970e9cd6277a65 upstream. Using .format_write means, we have a custom function to write to the chip, but not to read back. Also, mark registers as not precious and not volatile which is implicit because we cannot read them. Make those functions use 'regmap_readable' to reuse the checks done there. Signed-off-by: Wolfram Sang w.s...@pengutronix.de Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/base/regmap/regmap.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -36,6 +36,9 @@ bool regmap_readable(struct regmap *map, if (map-max_register reg map-max_register) return false; + if (map-format.format_write) + return false; + if (map-readable_reg) return map-readable_reg(map-dev, reg); @@ -44,7 +47,7 @@ bool regmap_readable(struct regmap *map, bool regmap_volatile(struct regmap *map, unsigned int reg) { - if (map-max_register reg map-max_register) + if (!regmap_readable(map, reg)) return false; if (map-volatile_reg) @@ -55,7 +58,7 @@ bool regmap_volatile(struct regmap *map, bool regmap_precious(struct regmap *map, unsigned int reg) { - if (map-max_register reg map-max_register) + if (!regmap_readable(map, reg)) return false; if (map-precious_reg) -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/