Re: [PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header
On Fri, 16 Apr 2021, Krzysztof Kozlowski wrote: > On 16/04/2021 16:37, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype > > for shadow_protect_win(). Prototype was for fimd_shadow_protect_win() > > instead > > > > Cc: Inki Dae > > Cc: Joonyoung Shim > > Cc: Seung-Woo Kim > > Cc: Kyungmin Park > > Cc: David Airlie > > Cc: Daniel Vetter > > Cc: Krzysztof Kozlowski > > Cc: dri-de...@lists.freedesktop.org > > Cc: linux-arm-ker...@lists.infradead.org > > Cc: linux-samsung-...@vger.kernel.org > > Signed-off-by: Lee Jones > > --- > > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Hi Lee, > > I already sent a fix for this one on 5th of April: > https://lore.kernel.org/lkml/20210405181524.52426-1-krzysztof.kozlow...@canonical.com/ No problem. Thanks for letting me know. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header
On 16/04/2021 16:37, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype > for shadow_protect_win(). Prototype was for fimd_shadow_protect_win() instead > > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: David Airlie > Cc: Daniel Vetter > Cc: Krzysztof Kozlowski > Cc: dri-de...@lists.freedesktop.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-samsung-...@vger.kernel.org > Signed-off-by: Lee Jones > --- > drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Hi Lee, I already sent a fix for this one on 5th of April: https://lore.kernel.org/lkml/20210405181524.52426-1-krzysztof.kozlow...@canonical.com/ Best regards, Krzysztof > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > index 49a2e0c539187..ae576122873e0 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c > @@ -723,7 +723,7 @@ static void fimd_win_set_colkey(struct fimd_context *ctx, > unsigned int win) > } > > /** > - * shadow_protect_win() - disable updating values from shadow registers at > vsync > + * fimd_shadow_protect_win() - disable updating values from shadow registers > at vsync > * > * @ctx: local driver data > * @win: window to protect registers for >
[PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype for shadow_protect_win(). Prototype was for fimd_shadow_protect_win() instead Cc: Inki Dae Cc: Joonyoung Shim Cc: Seung-Woo Kim Cc: Kyungmin Park Cc: David Airlie Cc: Daniel Vetter Cc: Krzysztof Kozlowski Cc: dri-de...@lists.freedesktop.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index 49a2e0c539187..ae576122873e0 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -723,7 +723,7 @@ static void fimd_win_set_colkey(struct fimd_context *ctx, unsigned int win) } /** - * shadow_protect_win() - disable updating values from shadow registers at vsync + * fimd_shadow_protect_win() - disable updating values from shadow registers at vsync * * @ctx: local driver data * @win: window to protect registers for -- 2.27.0
