Re: [PATCH 4/4] USB: gadget: f_midi: setup SuperSpeed Plus descriptors

2020-11-27 Thread Greg Kroah-Hartman 
On Fri, Nov 27, 2020 at 12:06:50PM +, Peter Chen wrote:
> On 20-11-26 19:09:37, Greg Kroah-Hartman wrote:
> > From: Will McVicker 
> > 
> > Needed for SuperSpeed Plus support for f_midi.  This allows the
> > gadget to work properly without crashing at SuperSpeed rates.
> > 
> > Cc: Felipe Balbi 
> > Cc: stable 
> > Signed-off-by: Will McVicker 
> > Signed-off-by: Greg Kroah-Hartman 
> > ---
> >  drivers/usb/gadget/function/f_midi.c | 5 +
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/drivers/usb/gadget/function/f_midi.c 
> > b/drivers/usb/gadget/function/f_midi.c
> > index 85cb15734aa8..ceb67651de4f 100644
> > --- a/drivers/usb/gadget/function/f_midi.c
> > +++ b/drivers/usb/gadget/function/f_midi.c
> > @@ -1048,6 +1048,11 @@ static int f_midi_bind(struct usb_configuration *c, 
> > struct usb_function *f)
> > f->ss_descriptors = usb_copy_descriptors(midi_function);
> > if (!f->ss_descriptors)
> > goto fail_f_midi;
> 
> Add one blank line, otherwise:

Will add it, good idea.

> Reviewed-by: Peter Chen 

Thanks for reviewing all of these, much appreciated.

greg k-h

Re: [PATCH 4/4] USB: gadget: f_midi: setup SuperSpeed Plus descriptors

2020-11-27 Thread Peter Chen 
On 20-11-26 19:09:37, Greg Kroah-Hartman wrote:
> From: Will McVicker 
> 
> Needed for SuperSpeed Plus support for f_midi.  This allows the
> gadget to work properly without crashing at SuperSpeed rates.
> 
> Cc: Felipe Balbi 
> Cc: stable 
> Signed-off-by: Will McVicker 
> Signed-off-by: Greg Kroah-Hartman 
> ---
>  drivers/usb/gadget/function/f_midi.c | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/usb/gadget/function/f_midi.c 
> b/drivers/usb/gadget/function/f_midi.c
> index 85cb15734aa8..ceb67651de4f 100644
> --- a/drivers/usb/gadget/function/f_midi.c
> +++ b/drivers/usb/gadget/function/f_midi.c
> @@ -1048,6 +1048,11 @@ static int f_midi_bind(struct usb_configuration *c, 
> struct usb_function *f)
>   f->ss_descriptors = usb_copy_descriptors(midi_function);
>   if (!f->ss_descriptors)
>   goto fail_f_midi;

Add one blank line, otherwise:

Reviewed-by: Peter Chen 

Peter
> + if (gadget_is_superspeed_plus(c->cdev->gadget)) {
> + f->ssp_descriptors = 
> usb_copy_descriptors(midi_function);
> + if (!f->ssp_descriptors)
> + goto fail_f_midi;
> + }
>   }
>  
>   kfree(midi_function);
> -- 
> 2.29.2
> 

-- 

Thanks,
Peter Chen

[PATCH 4/4] USB: gadget: f_midi: setup SuperSpeed Plus descriptors

2020-11-26 Thread Greg Kroah-Hartman 
From: Will McVicker 

Needed for SuperSpeed Plus support for f_midi.  This allows the
gadget to work properly without crashing at SuperSpeed rates.

Cc: Felipe Balbi 
Cc: stable 
Signed-off-by: Will McVicker 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/usb/gadget/function/f_midi.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/gadget/function/f_midi.c 
b/drivers/usb/gadget/function/f_midi.c
index 85cb15734aa8..ceb67651de4f 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -1048,6 +1048,11 @@ static int f_midi_bind(struct usb_configuration *c, 
struct usb_function *f)
f->ss_descriptors = usb_copy_descriptors(midi_function);
if (!f->ss_descriptors)
goto fail_f_midi;
+   if (gadget_is_superspeed_plus(c->cdev->gadget)) {
+   f->ssp_descriptors = 
usb_copy_descriptors(midi_function);
+   if (!f->ssp_descriptors)
+   goto fail_f_midi;
+   }
}
 
kfree(midi_function);
-- 
2.29.2

[PATCH 4/4] USB: gadget: f_midi: setup SuperSpeed Plus descriptors

2020-11-26 Thread Greg Kroah-Hartman 
From: Will McVicker 

Needed for SuperSpeed Plus support for f_midi.  This allows the
gadget to work properly without crashing at SuperSpeed rates.

Cc: Felipe Balbi 
Cc: stable 
Signed-off-by: Will McVicker 
Signed-off-by: Greg Kroah-Hartman 
---
 drivers/usb/gadget/function/f_midi.c | 5 +
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/gadget/function/f_midi.c 
b/drivers/usb/gadget/function/f_midi.c
index 85cb15734aa8..ceb67651de4f 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -1048,6 +1048,11 @@ static int f_midi_bind(struct usb_configuration *c, 
struct usb_function *f)
f->ss_descriptors = usb_copy_descriptors(midi_function);
if (!f->ss_descriptors)
goto fail_f_midi;
+   if (gadget_is_superspeed_plus(c->cdev->gadget)) {
+   f->ssp_descriptors = 
usb_copy_descriptors(midi_function);
+   if (!f->ssp_descriptors)
+   goto fail_f_midi;
+   }
}
 
kfree(midi_function);
-- 
2.29.2