Re: [PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode()

2017-08-21 Thread Jan Kara 
On Sat 19-08-17 09:19:34, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sat, 19 Aug 2017 08:13:46 +0200
> 
> The local variable "bh" will be set to an appropriate pointer a bit later.
> Thus omit the explicit initialisation at the beginning.
> 
> Signed-off-by: Markus Elfring 

Applied to my tree. Thanks.

Honza
> ---
>  fs/isofs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index f6d6c2ca8723..3a33b3db712a 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -1298,7 +1298,7 @@ static int isofs_read_inode(struct inode *inode, int 
> relocated)
>   unsigned long bufsize = ISOFS_BUFFER_SIZE(inode);
>   unsigned long block;
>   int high_sierra = sbi->s_high_sierra;
> - struct buffer_head *bh = NULL;
> + struct buffer_head *bh;
>   struct iso_directory_record *de;
>   struct iso_directory_record *tmpde = NULL;
>   unsigned int de_len;
> -- 
> 2.14.0
> 
-- 
Jan Kara 
SUSE Labs, CR

Re: [PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode()

2017-08-21 Thread Jan Kara 
On Sat 19-08-17 09:19:34, SF Markus Elfring wrote:
> From: Markus Elfring 
> Date: Sat, 19 Aug 2017 08:13:46 +0200
> 
> The local variable "bh" will be set to an appropriate pointer a bit later.
> Thus omit the explicit initialisation at the beginning.
> 
> Signed-off-by: Markus Elfring 

Applied to my tree. Thanks.

Honza
> ---
>  fs/isofs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
> index f6d6c2ca8723..3a33b3db712a 100644
> --- a/fs/isofs/inode.c
> +++ b/fs/isofs/inode.c
> @@ -1298,7 +1298,7 @@ static int isofs_read_inode(struct inode *inode, int 
> relocated)
>   unsigned long bufsize = ISOFS_BUFFER_SIZE(inode);
>   unsigned long block;
>   int high_sierra = sbi->s_high_sierra;
> - struct buffer_head *bh = NULL;
> + struct buffer_head *bh;
>   struct iso_directory_record *de;
>   struct iso_directory_record *tmpde = NULL;
>   unsigned int de_len;
> -- 
> 2.14.0
> 
-- 
Jan Kara 
SUSE Labs, CR

[PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode()

2017-08-19 Thread SF Markus Elfring 
From: Markus Elfring 
Date: Sat, 19 Aug 2017 08:13:46 +0200

The local variable "bh" will be set to an appropriate pointer a bit later.
Thus omit the explicit initialisation at the beginning.

Signed-off-by: Markus Elfring 
---
 fs/isofs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
index f6d6c2ca8723..3a33b3db712a 100644
--- a/fs/isofs/inode.c
+++ b/fs/isofs/inode.c
@@ -1298,7 +1298,7 @@ static int isofs_read_inode(struct inode *inode, int 
relocated)
unsigned long bufsize = ISOFS_BUFFER_SIZE(inode);
unsigned long block;
int high_sierra = sbi->s_high_sierra;
-   struct buffer_head *bh = NULL;
+   struct buffer_head *bh;
struct iso_directory_record *de;
struct iso_directory_record *tmpde = NULL;
unsigned int de_len;
-- 
2.14.0

[PATCH 4/4] isofs: Delete an unnecessary variable initialisation in isofs_read_inode()

2017-08-19 Thread SF Markus Elfring 
From: Markus Elfring 
Date: Sat, 19 Aug 2017 08:13:46 +0200

The local variable "bh" will be set to an appropriate pointer a bit later.
Thus omit the explicit initialisation at the beginning.

Signed-off-by: Markus Elfring 
---
 fs/isofs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
index f6d6c2ca8723..3a33b3db712a 100644
--- a/fs/isofs/inode.c
+++ b/fs/isofs/inode.c
@@ -1298,7 +1298,7 @@ static int isofs_read_inode(struct inode *inode, int 
relocated)
unsigned long bufsize = ISOFS_BUFFER_SIZE(inode);
unsigned long block;
int high_sierra = sbi->s_high_sierra;
-   struct buffer_head *bh = NULL;
+   struct buffer_head *bh;
struct iso_directory_record *de;
struct iso_directory_record *tmpde = NULL;
unsigned int de_len;
-- 
2.14.0