Re: [PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments
On 19/11/18 4:46 PM, Faiz Abbas wrote: The sdhci_execute_tuning() function has assignment of private pointers multiple times. Remove the redundant assignment. Signed-off-by: Faiz Abbas Acked-by: Kishon Vijay Abraham I --- drivers/mmc/host/sdhci-omap.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index bf268b38ddc8..b3cb39d0db6f 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -295,10 +295,6 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) int ret = 0; u32 reg; - pltfm_host = sdhci_priv(host); - omap_host = sdhci_pltfm_priv(pltfm_host); - dev = omap_host->dev; - /* clock tuning is not needed for upto 52MHz */ if (ios->clock <= 5200) return 0;
Re: [PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments
On 19/11/18 4:46 PM, Faiz Abbas wrote: The sdhci_execute_tuning() function has assignment of private pointers multiple times. Remove the redundant assignment. Signed-off-by: Faiz Abbas Acked-by: Kishon Vijay Abraham I --- drivers/mmc/host/sdhci-omap.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index bf268b38ddc8..b3cb39d0db6f 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -295,10 +295,6 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) int ret = 0; u32 reg; - pltfm_host = sdhci_priv(host); - omap_host = sdhci_pltfm_priv(pltfm_host); - dev = omap_host->dev; - /* clock tuning is not needed for upto 52MHz */ if (ios->clock <= 5200) return 0;
[PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments
The sdhci_execute_tuning() function has assignment of private pointers multiple times. Remove the redundant assignment. Signed-off-by: Faiz Abbas --- drivers/mmc/host/sdhci-omap.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index bf268b38ddc8..b3cb39d0db6f 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -295,10 +295,6 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) int ret = 0; u32 reg; - pltfm_host = sdhci_priv(host); - omap_host = sdhci_pltfm_priv(pltfm_host); - dev = omap_host->dev; - /* clock tuning is not needed for upto 52MHz */ if (ios->clock <= 5200) return 0; -- 2.19.1
[PATCH 4/4] mmc: sdhci-omap: Remove redundant structure assignments
The sdhci_execute_tuning() function has assignment of private pointers multiple times. Remove the redundant assignment. Signed-off-by: Faiz Abbas --- drivers/mmc/host/sdhci-omap.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c index bf268b38ddc8..b3cb39d0db6f 100644 --- a/drivers/mmc/host/sdhci-omap.c +++ b/drivers/mmc/host/sdhci-omap.c @@ -295,10 +295,6 @@ static int sdhci_omap_execute_tuning(struct mmc_host *mmc, u32 opcode) int ret = 0; u32 reg; - pltfm_host = sdhci_priv(host); - omap_host = sdhci_pltfm_priv(pltfm_host); - dev = omap_host->dev; - /* clock tuning is not needed for upto 52MHz */ if (ios->clock <= 5200) return 0; -- 2.19.1
