Re: [PATCH 4/4] thermal: ti-soc-thermal: Use non-inverted define for omap4

2021-02-06 Thread Pavel Machek
Hi!

> When we set bit 10 high we use continuous mode and not single
> mode. Let's correct this to avoid confusion. No functional
> changes here, the code does the right thing with bit 10.

Seems okay to me. 1/4:

Acked-by: Pavel Machek 

Best regards,
Pavel

-- 
http://www.livejournal.com/~pavelmachek


signature.asc
Description: Digital signature


[PATCH 4/4] thermal: ti-soc-thermal: Use non-inverted define for omap4

2021-02-05 Thread Tony Lindgren
When we set bit 10 high we use continuous mode and not single
mode. Let's correct this to avoid confusion. No functional
changes here, the code does the right thing with bit 10.

Cc: Adam Ford 
Cc: Carl Philipp Klemm 
Cc: Eduardo Valentin 
Cc: H. Nikolaus Schaller 
Cc: Merlijn Wajer 
Cc: Pavel Machek 
Cc: Peter Ujfalusi 
Cc: Sebastian Reichel 
Signed-off-by: Tony Lindgren 
---
 drivers/thermal/ti-soc-thermal/omap4-thermal-data.c | 4 ++--
 drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/thermal/ti-soc-thermal/omap4-thermal-data.c 
b/drivers/thermal/ti-soc-thermal/omap4-thermal-data.c
--- a/drivers/thermal/ti-soc-thermal/omap4-thermal-data.c
+++ b/drivers/thermal/ti-soc-thermal/omap4-thermal-data.c
@@ -24,7 +24,7 @@ omap4430_mpu_temp_sensor_registers = {
.bgap_dtemp_mask = OMAP4430_BGAP_TEMP_SENSOR_DTEMP_MASK,
 
.bgap_mode_ctrl = OMAP4430_TEMP_SENSOR_CTRL_OFFSET,
-   .mode_ctrl_mask = OMAP4430_SINGLE_MODE_MASK,
+   .mode_ctrl_mask = OMAP4430_CONTINUOUS_MODE_MASK,
 
.bgap_efuse = OMAP4430_FUSE_OPP_BGAP,
 };
@@ -97,7 +97,7 @@ omap4460_mpu_temp_sensor_registers = {
.mask_cold_mask = OMAP4460_MASK_COLD_MASK,
 
.bgap_mode_ctrl = OMAP4460_BGAP_CTRL_OFFSET,
-   .mode_ctrl_mask = OMAP4460_SINGLE_MODE_MASK,
+   .mode_ctrl_mask = OMAP4460_CONTINUOUS_MODE_MASK,
 
.bgap_counter = OMAP4460_BGAP_COUNTER_OFFSET,
.counter_mask = OMAP4460_COUNTER_MASK,
diff --git a/drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h 
b/drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h
--- a/drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h
+++ b/drivers/thermal/ti-soc-thermal/omap4xxx-bandgap.h
@@ -40,7 +40,7 @@
 /* OMAP4430.TEMP_SENSOR bits */
 #define OMAP4430_BGAP_TEMPSOFF_MASKBIT(12)
 #define OMAP4430_BGAP_TSHUT_MASK   BIT(11)
-#define OMAP4430_SINGLE_MODE_MASK  BIT(10)
+#define OMAP4430_CONTINUOUS_MODE_MASK  BIT(10)
 #define OMAP4430_BGAP_TEMP_SENSOR_SOC_MASK BIT(9)
 #define OMAP4430_BGAP_TEMP_SENSOR_EOCZ_MASKBIT(8)
 #define OMAP4430_BGAP_TEMP_SENSOR_DTEMP_MASK   (0xff << 0)
@@ -113,7 +113,7 @@
 #define OMAP4460_BGAP_TEMP_SENSOR_DTEMP_MASK   (0x3ff << 0)
 
 /* OMAP4460.BANDGAP_CTRL bits */
-#define OMAP4460_SINGLE_MODE_MASK  BIT(31)
+#define OMAP4460_CONTINUOUS_MODE_MASK  BIT(31)
 #define OMAP4460_MASK_HOT_MASK BIT(1)
 #define OMAP4460_MASK_COLD_MASKBIT(0)
 
-- 
2.30.0