Re: [PATCH 4/5] ARM: berlin/dt: add cpupll and syspll support to BG2CD
On 03/21/2014 12:43 PM, Alexandre Belloni wrote: This also moves the clocks from the clocks container node to the root. Please leave a word on the original intention of the patch here, too. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/berlin2cd.dtsi | 56 1 file changed, 39 insertions(+), 17 deletions(-) diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi index 094968c27533..c84013c1597c 100644 --- a/arch/arm/boot/dts/berlin2cd.dtsi +++ b/arch/arm/boot/dts/berlin2cd.dtsi @@ -30,24 +30,46 @@ }; }; - clocks { - smclk: sysmgr-clock { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <2500>; - }; + smclk: sysmgr-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <2500>; + }; - cfgclk: cfg-clock { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <7500>; - }; + cfgclk: cfg-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <7500>; + }; - sysclk: system-clock { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <3>; - }; + syspll: syspll { syspll: pll@ea0014 and sort it in SoC nodes. + compatible = "marvell,berlin2-pll"; + clocks = <>; + #clock-cells = <0>; + reg = <0xf7ea0014 8>; + }; + + cpupll: cpupll { ditto. + compatible = "marvell,berlin2-pll"; + clocks = <>; + #clock-cells = <0>; + reg = <0xf7ea003c 8>; + }; + + cpuclk: cpu-clock { + compatible = "fixed-factor-clock"; + clocks = <>; + #clock-cells = <0>; + clock-div = <1>; + clock-mult = <1>; Same comment about cpuclk to cpupll relation. + }; + + twdclk: twdclk { + compatible = "fixed-factor-clock"; + #clock-cells = <0>; + clocks = <>; + clock-mult = <1>; + clock-div = <3>; }; soc { @@ -76,7 +98,7 @@ compatible = "arm,cortex-a9-twd-timer"; reg = <0xad0600 0x20>; interrupts = ; - clocks = <>; + clocks = <>; }; apb@e8 { -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 4/5] ARM: berlin/dt: add cpupll and syspll support to BG2CD
This also moves the clocks from the clocks container node to the root. Signed-off-by: Alexandre Belloni --- arch/arm/boot/dts/berlin2cd.dtsi | 56 1 file changed, 39 insertions(+), 17 deletions(-) diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi index 094968c27533..c84013c1597c 100644 --- a/arch/arm/boot/dts/berlin2cd.dtsi +++ b/arch/arm/boot/dts/berlin2cd.dtsi @@ -30,24 +30,46 @@ }; }; - clocks { - smclk: sysmgr-clock { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <2500>; - }; + smclk: sysmgr-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <2500>; + }; - cfgclk: cfg-clock { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <7500>; - }; + cfgclk: cfg-clock { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-frequency = <7500>; + }; - sysclk: system-clock { - compatible = "fixed-clock"; - #clock-cells = <0>; - clock-frequency = <3>; - }; + syspll: syspll { + compatible = "marvell,berlin2-pll"; + clocks = <>; + #clock-cells = <0>; + reg = <0xf7ea0014 8>; + }; + + cpupll: cpupll { + compatible = "marvell,berlin2-pll"; + clocks = <>; + #clock-cells = <0>; + reg = <0xf7ea003c 8>; + }; + + cpuclk: cpu-clock { + compatible = "fixed-factor-clock"; + clocks = <>; + #clock-cells = <0>; + clock-div = <1>; + clock-mult = <1>; + }; + + twdclk: twdclk { + compatible = "fixed-factor-clock"; + #clock-cells = <0>; + clocks = <>; + clock-mult = <1>; + clock-div = <3>; }; soc { @@ -76,7 +98,7 @@ compatible = "arm,cortex-a9-twd-timer"; reg = <0xad0600 0x20>; interrupts = ; - clocks = <>; + clocks = <>; }; apb@e8 { -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 4/5] ARM: berlin/dt: add cpupll and syspll support to BG2CD
This also moves the clocks from the clocks container node to the root. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- arch/arm/boot/dts/berlin2cd.dtsi | 56 1 file changed, 39 insertions(+), 17 deletions(-) diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi index 094968c27533..c84013c1597c 100644 --- a/arch/arm/boot/dts/berlin2cd.dtsi +++ b/arch/arm/boot/dts/berlin2cd.dtsi @@ -30,24 +30,46 @@ }; }; - clocks { - smclk: sysmgr-clock { - compatible = fixed-clock; - #clock-cells = 0; - clock-frequency = 2500; - }; + smclk: sysmgr-clock { + compatible = fixed-clock; + #clock-cells = 0; + clock-frequency = 2500; + }; - cfgclk: cfg-clock { - compatible = fixed-clock; - #clock-cells = 0; - clock-frequency = 7500; - }; + cfgclk: cfg-clock { + compatible = fixed-clock; + #clock-cells = 0; + clock-frequency = 7500; + }; - sysclk: system-clock { - compatible = fixed-clock; - #clock-cells = 0; - clock-frequency = 3; - }; + syspll: syspll { + compatible = marvell,berlin2-pll; + clocks = smclk; + #clock-cells = 0; + reg = 0xf7ea0014 8; + }; + + cpupll: cpupll { + compatible = marvell,berlin2-pll; + clocks = smclk; + #clock-cells = 0; + reg = 0xf7ea003c 8; + }; + + cpuclk: cpu-clock { + compatible = fixed-factor-clock; + clocks = cpupll; + #clock-cells = 0; + clock-div = 1; + clock-mult = 1; + }; + + twdclk: twdclk { + compatible = fixed-factor-clock; + #clock-cells = 0; + clocks = cpuclk; + clock-mult = 1; + clock-div = 3; }; soc { @@ -76,7 +98,7 @@ compatible = arm,cortex-a9-twd-timer; reg = 0xad0600 0x20; interrupts = GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH; - clocks = sysclk; + clocks = twdclk; }; apb@e8 { -- 1.8.3.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 4/5] ARM: berlin/dt: add cpupll and syspll support to BG2CD
On 03/21/2014 12:43 PM, Alexandre Belloni wrote: This also moves the clocks from the clocks container node to the root. Please leave a word on the original intention of the patch here, too. Signed-off-by: Alexandre Belloni alexandre.bell...@free-electrons.com --- arch/arm/boot/dts/berlin2cd.dtsi | 56 1 file changed, 39 insertions(+), 17 deletions(-) diff --git a/arch/arm/boot/dts/berlin2cd.dtsi b/arch/arm/boot/dts/berlin2cd.dtsi index 094968c27533..c84013c1597c 100644 --- a/arch/arm/boot/dts/berlin2cd.dtsi +++ b/arch/arm/boot/dts/berlin2cd.dtsi @@ -30,24 +30,46 @@ }; }; - clocks { - smclk: sysmgr-clock { - compatible = fixed-clock; - #clock-cells = 0; - clock-frequency = 2500; - }; + smclk: sysmgr-clock { + compatible = fixed-clock; + #clock-cells = 0; + clock-frequency = 2500; + }; - cfgclk: cfg-clock { - compatible = fixed-clock; - #clock-cells = 0; - clock-frequency = 7500; - }; + cfgclk: cfg-clock { + compatible = fixed-clock; + #clock-cells = 0; + clock-frequency = 7500; + }; - sysclk: system-clock { - compatible = fixed-clock; - #clock-cells = 0; - clock-frequency = 3; - }; + syspll: syspll { syspll: pll@ea0014 and sort it in SoC nodes. + compatible = marvell,berlin2-pll; + clocks = smclk; + #clock-cells = 0; + reg = 0xf7ea0014 8; + }; + + cpupll: cpupll { ditto. + compatible = marvell,berlin2-pll; + clocks = smclk; + #clock-cells = 0; + reg = 0xf7ea003c 8; + }; + + cpuclk: cpu-clock { + compatible = fixed-factor-clock; + clocks = cpupll; + #clock-cells = 0; + clock-div = 1; + clock-mult = 1; Same comment about cpuclk to cpupll relation. + }; + + twdclk: twdclk { + compatible = fixed-factor-clock; + #clock-cells = 0; + clocks = cpuclk; + clock-mult = 1; + clock-div = 3; }; soc { @@ -76,7 +98,7 @@ compatible = arm,cortex-a9-twd-timer; reg = 0xad0600 0x20; interrupts = GIC_PPI 13 IRQ_TYPE_LEVEL_HIGH; - clocks = sysclk; + clocks = twdclk; }; apb@e8 { -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/