Re: [PATCH 4/5] USB Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm

2008-01-05 Thread David Brownell

> --- 23.a/arch/arm/Kconfig
> +++ 23.b/arch/arm/Kconfig
> @@ -1049,6 +1049,8 @@ source "drivers/hid/Kconfig"
>  
>  source "drivers/usb/Kconfig"
>  
> +source "drivers/usb/gadget/Kconfig"
> +
>  source "drivers/mmc/Kconfig"
>  
>  source "drivers/rtc/Kconfig"
> 


Better IMO to include such updates with the patch that reorganizes
that part of the menu ... it's conceptually a single change, and
fragmenting it will cause bisection problems.

In fact, moving the gadget Kconfig in a separate step would make
your main changes more clear too.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 4/5] USB Kconfig: Source "drivers/usb/gadget/Kconfig" for ARCH=arm

2008-01-05 Thread Al Boldi

From: David Brownell <[EMAIL PROTECTED]>

Source "drivers/usb/gadget/Kconfig" for ARCH=arm.


Cc: David Brownell <[EMAIL PROTECTED]>
Cc: Greg KH <[EMAIL PROTECTED]>
Cc: Andrew Morton <[EMAIL PROTECTED]>
Signed-off-by: Al Boldi <[EMAIL PROTECTED]>

---

--- 23.a/arch/arm/Kconfig
+++ 23.b/arch/arm/Kconfig
@@ -1049,6 +1049,8 @@ source "drivers/hid/Kconfig"
 
 source "drivers/usb/Kconfig"
 
+source "drivers/usb/gadget/Kconfig"
+
 source "drivers/mmc/Kconfig"
 
 source "drivers/rtc/Kconfig"

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 4/5] USB Kconfig: Source drivers/usb/gadget/Kconfig for ARCH=arm

2008-01-05 Thread Al Boldi

From: David Brownell [EMAIL PROTECTED]

Source drivers/usb/gadget/Kconfig for ARCH=arm.


Cc: David Brownell [EMAIL PROTECTED]
Cc: Greg KH [EMAIL PROTECTED]
Cc: Andrew Morton [EMAIL PROTECTED]
Signed-off-by: Al Boldi [EMAIL PROTECTED]

---

--- 23.a/arch/arm/Kconfig
+++ 23.b/arch/arm/Kconfig
@@ -1049,6 +1049,8 @@ source drivers/hid/Kconfig
 
 source drivers/usb/Kconfig
 
+source drivers/usb/gadget/Kconfig
+
 source drivers/mmc/Kconfig
 
 source drivers/rtc/Kconfig

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 4/5] USB Kconfig: Source drivers/usb/gadget/Kconfig for ARCH=arm

2008-01-05 Thread David Brownell

 --- 23.a/arch/arm/Kconfig
 +++ 23.b/arch/arm/Kconfig
 @@ -1049,6 +1049,8 @@ source drivers/hid/Kconfig
  
  source drivers/usb/Kconfig
  
 +source drivers/usb/gadget/Kconfig
 +
  source drivers/mmc/Kconfig
  
  source drivers/rtc/Kconfig
 


Better IMO to include such updates with the patch that reorganizes
that part of the menu ... it's conceptually a single change, and
fragmenting it will cause bisection problems.

In fact, moving the gadget Kconfig in a separate step would make
your main changes more clear too.
 
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/