Re: [PATCH 4/6] dt-bindings: reset: pdc: Add PDC Global bindings
On 2021-03-14 03:07, Stephen Boyd wrote: Quoting Sibi Sankar (2021-03-08 21:51:49) Add PDC Global reset controller bindings for SC7280 SoCs. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml | 4 include/dt-bindings/reset/qcom,sdm845-pdc.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml b/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml index d7d8cec9419f..831ea8d5d83f 100644 --- a/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml @@ -21,6 +21,10 @@ properties: - const: "qcom,sc7180-pdc-global" - const: "qcom,sdm845-pdc-global" + - description: on SC7280 SoCs the following compatibles must be specified +items: + - const: "qcom,sc7280-pdc-global" Somehow this one can drop sdm845-pdc-global but aoss-cc can't? I missed replying to ^^. aoss-cc reset is identical to that found on SDM845 SoC but the pdc-reset differs in the number of resets and offset within the pdc register space. + - description: on SDM845 SoCs the following compatibles must be specified items: - const: "qcom,sdm845-pdc-global" -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
Re: [PATCH 4/6] dt-bindings: reset: pdc: Add PDC Global bindings
On Tue, 09 Mar 2021 11:21:49 +0530, Sibi Sankar wrote: > Add PDC Global reset controller bindings for SC7280 SoCs. > > Signed-off-by: Sibi Sankar > --- > Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml | 4 > include/dt-bindings/reset/qcom,sdm845-pdc.h | 2 ++ > 2 files changed, 6 insertions(+) > Acked-by: Rob Herring
Re: [PATCH 4/6] dt-bindings: reset: pdc: Add PDC Global bindings
Quoting Sibi Sankar (2021-03-08 21:51:49) > Add PDC Global reset controller bindings for SC7280 SoCs. > > Signed-off-by: Sibi Sankar > --- > Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml | 4 > include/dt-bindings/reset/qcom,sdm845-pdc.h | 2 ++ > 2 files changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml > b/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml > index d7d8cec9419f..831ea8d5d83f 100644 > --- a/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml > +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml > @@ -21,6 +21,10 @@ properties: >- const: "qcom,sc7180-pdc-global" >- const: "qcom,sdm845-pdc-global" > > + - description: on SC7280 SoCs the following compatibles must be > specified > +items: > + - const: "qcom,sc7280-pdc-global" Somehow this one can drop sdm845-pdc-global but aoss-cc can't? > + >- description: on SDM845 SoCs the following compatibles must be > specified > items: >- const: "qcom,sdm845-pdc-global"
[PATCH 4/6] dt-bindings: reset: pdc: Add PDC Global bindings
Add PDC Global reset controller bindings for SC7280 SoCs. Signed-off-by: Sibi Sankar --- Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml | 4 include/dt-bindings/reset/qcom,sdm845-pdc.h | 2 ++ 2 files changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml b/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml index d7d8cec9419f..831ea8d5d83f 100644 --- a/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml +++ b/Documentation/devicetree/bindings/reset/qcom,pdc-global.yaml @@ -21,6 +21,10 @@ properties: - const: "qcom,sc7180-pdc-global" - const: "qcom,sdm845-pdc-global" + - description: on SC7280 SoCs the following compatibles must be specified +items: + - const: "qcom,sc7280-pdc-global" + - description: on SDM845 SoCs the following compatibles must be specified items: - const: "qcom,sdm845-pdc-global" diff --git a/include/dt-bindings/reset/qcom,sdm845-pdc.h b/include/dt-bindings/reset/qcom,sdm845-pdc.h index 53c37f9c319a..03a0c0eb8147 100644 --- a/include/dt-bindings/reset/qcom,sdm845-pdc.h +++ b/include/dt-bindings/reset/qcom,sdm845-pdc.h @@ -16,5 +16,7 @@ #define PDC_DISPLAY_SYNC_RESET 7 #define PDC_COMPUTE_SYNC_RESET 8 #define PDC_MODEM_SYNC_RESET 9 +#define PDC_WLAN_RF_SYNC_RESET 10 +#define PDC_WPSS_SYNC_RESET11 #endif -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
