[PATCH 4.9 021/116] thermal: hwmon: Properly report critical temperature in sysfs
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Krzysztof Kozlowskicommit f37fabb8643eaf8e3b61a72f683770c85eca upstream. In the critical sysfs entry the thermal hwmon was returning wrong temperature to the user-space. It was reporting the temperature of the first trip point instead of the temperature of critical trip point. For example: /sys/class/hwmon/hwmon0/temp1_crit:5 /sys/class/thermal/thermal_zone0/trip_point_0_temp:5 /sys/class/thermal/thermal_zone0/trip_point_0_type:active /sys/class/thermal/thermal_zone0/trip_point_3_temp:12 /sys/class/thermal/thermal_zone0/trip_point_3_type:critical Since commit e68b16abd91d ("thermal: add hwmon sysfs I/F") the driver have been registering a sysfs entry if get_crit_temp() callback was provided. However when accessed, it was calling get_trip_temp() instead of the get_crit_temp(). Fixes: e68b16abd91d ("thermal: add hwmon sysfs I/F") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Zhang Rui Signed-off-by: Greg Kroah-Hartman --- drivers/thermal/thermal_hwmon.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/thermal/thermal_hwmon.c +++ b/drivers/thermal/thermal_hwmon.c @@ -98,7 +98,7 @@ temp_crit_show(struct device *dev, struc int temperature; int ret; - ret = tz->ops->get_trip_temp(tz, 0, ); + ret = tz->ops->get_crit_temp(tz, ); if (ret) return ret;
[PATCH 4.9 021/116] thermal: hwmon: Properly report critical temperature in sysfs
4.9-stable review patch. If anyone has any objections, please let me know. -- From: Krzysztof Kozlowski commit f37fabb8643eaf8e3b61a72f683770c85eca upstream. In the critical sysfs entry the thermal hwmon was returning wrong temperature to the user-space. It was reporting the temperature of the first trip point instead of the temperature of critical trip point. For example: /sys/class/hwmon/hwmon0/temp1_crit:5 /sys/class/thermal/thermal_zone0/trip_point_0_temp:5 /sys/class/thermal/thermal_zone0/trip_point_0_type:active /sys/class/thermal/thermal_zone0/trip_point_3_temp:12 /sys/class/thermal/thermal_zone0/trip_point_3_type:critical Since commit e68b16abd91d ("thermal: add hwmon sysfs I/F") the driver have been registering a sysfs entry if get_crit_temp() callback was provided. However when accessed, it was calling get_trip_temp() instead of the get_crit_temp(). Fixes: e68b16abd91d ("thermal: add hwmon sysfs I/F") Signed-off-by: Krzysztof Kozlowski Signed-off-by: Zhang Rui Signed-off-by: Greg Kroah-Hartman --- drivers/thermal/thermal_hwmon.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/thermal/thermal_hwmon.c +++ b/drivers/thermal/thermal_hwmon.c @@ -98,7 +98,7 @@ temp_crit_show(struct device *dev, struc int temperature; int ret; - ret = tz->ops->get_trip_temp(tz, 0, ); + ret = tz->ops->get_crit_temp(tz, ); if (ret) return ret;