Re: [PATCH 49/49] staging: rtl8723bs: remove obsolete macro

[Fabio Aiuto]

On Thu, Apr 01, 2021 at 02:57:36AM -0700, Joe Perches wrote:
> On Thu, 2021-04-01 at 11:21 +0200, Fabio Aiuto wrote:
> > remove obsolete macro RT_TRACE
> []
> > diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h 
> > b/drivers/staging/rtl8723bs/include/rtw_debug.h
> []
> > -#ifdef DEBUG_RTL871X
> > -
> > -#ifdefined(_dbgdump) && defined(_MODULE_DEFINE_)
> > -
> > -   #undef RT_TRACE
> > -   #define RT_TRACE(_Comp, _Level, Fmt)\
> > -   do {\
> > -   if ((_Comp & GlobalDebugComponents) && (_Level <= 
> > GlobalDebugLevel)) {\
> > -   _dbgdump("%s [0x%08x,%d]", DRIVER_PREFIX, (unsigned 
> > int)_Comp, _Level);\
> > -   _dbgdump Fmt;\
> > -   } \
> > -   } while (0)
> > -
> > -#endif /* defined(_dbgdump) && defined(_MODULE_DEFINE_) */
> > -#endif /* DEBUG_RTL871X */
> 
> Maybe remove all of these too
> 
> $ git grep DEBUG_RTL871X
> drivers/staging/rtl8723bs/core/rtw_debug.c:#ifdef DEBUG_RTL871X
> drivers/staging/rtl8723bs/core/rtw_debug.c:#endif /* DEBUG_RTL871X */
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:#ifdef DEBUG_RTL871X
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:#ifdef DEBUG_RTL871X
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:#ifdef DEBUG_RTL871X
> drivers/staging/rtl8723bs/include/autoconf.h:/*#define DEBUG_RTL871X */
> drivers/staging/rtl8723bs/include/rtw_debug.h:#ifdef DEBUG_RTL871X
> drivers/staging/rtl8723bs/include/rtw_debug.h:#endif /* DEBUG_RTL871X */
> 
> 

there are a lot of things to remove, I thought to do it in next patchsets

maybe other obsolete tracing macros are involved...

Re: [PATCH 49/49] staging: rtl8723bs: remove obsolete macro

[Joe Perches]

On Thu, 2021-04-01 at 11:21 +0200, Fabio Aiuto wrote:
> remove obsolete macro RT_TRACE
[]
> diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h 
> b/drivers/staging/rtl8723bs/include/rtw_debug.h
[]
> -#ifdef DEBUG_RTL871X
> -
> -#if  defined(_dbgdump) && defined(_MODULE_DEFINE_)
> -
> - #undef RT_TRACE
> - #define RT_TRACE(_Comp, _Level, Fmt)\
> - do {\
> - if ((_Comp & GlobalDebugComponents) && (_Level <= 
> GlobalDebugLevel)) {\
> - _dbgdump("%s [0x%08x,%d]", DRIVER_PREFIX, (unsigned 
> int)_Comp, _Level);\
> - _dbgdump Fmt;\
> - } \
> - } while (0)
> -
> -#endif /* defined(_dbgdump) && defined(_MODULE_DEFINE_) */
> -#endif /* DEBUG_RTL871X */

Maybe remove all of these too

$ git grep DEBUG_RTL871X
drivers/staging/rtl8723bs/core/rtw_debug.c:#ifdef DEBUG_RTL871X
drivers/staging/rtl8723bs/core/rtw_debug.c:#endif /* DEBUG_RTL871X */
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:#ifdef DEBUG_RTL871X
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:#ifdef DEBUG_RTL871X
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:#ifdef DEBUG_RTL871X
drivers/staging/rtl8723bs/include/autoconf.h:/*#define DEBUG_RTL871X */
drivers/staging/rtl8723bs/include/rtw_debug.h:#ifdef DEBUG_RTL871X
drivers/staging/rtl8723bs/include/rtw_debug.h:#endif /* DEBUG_RTL871X */

[PATCH 49/49] staging: rtl8723bs: remove obsolete macro

[Fabio Aiuto]

remove obsolete macro RT_TRACE

Signed-off-by: Fabio Aiuto 
---
 drivers/staging/rtl8723bs/include/rtw_debug.h | 18 --
 1 file changed, 18 deletions(-)

diff --git a/drivers/staging/rtl8723bs/include/rtw_debug.h 
b/drivers/staging/rtl8723bs/include/rtw_debug.h
index d3c77798a5eb..6639d79cd7ec 100644
--- a/drivers/staging/rtl8723bs/include/rtw_debug.h
+++ b/drivers/staging/rtl8723bs/include/rtw_debug.h
@@ -131,8 +131,6 @@
#define _MODULE_DEFINE_ _module_efuse_
 #endif
 
-#define RT_TRACE(_Comp, _Level, Fmt) do {} while (0)
-
 #define DBG_871X(x, ...) do {} while (0)
 #define MSG_8192C(x, ...) do {} while (0)
 #define DBG_8192C(x, ...) do {} while (0)
@@ -216,22 +214,6 @@
 #endif /* defined(_dbgdump) */
 #endif /* DEBUG */
 
-#ifdef DEBUG_RTL871X
-
-#ifdefined(_dbgdump) && defined(_MODULE_DEFINE_)
-
-   #undef RT_TRACE
-   #define RT_TRACE(_Comp, _Level, Fmt)\
-   do {\
-   if ((_Comp & GlobalDebugComponents) && (_Level <= 
GlobalDebugLevel)) {\
-   _dbgdump("%s [0x%08x,%d]", DRIVER_PREFIX, (unsigned 
int)_Comp, _Level);\
-   _dbgdump Fmt;\
-   } \
-   } while (0)
-
-#endif /* defined(_dbgdump) && defined(_MODULE_DEFINE_) */
-#endif /* DEBUG_RTL871X */
-
 void dump_drv_version(void *sel);
 void dump_log_level(void *sel);
 
-- 
2.20.1