Re: [PATCH 5/8] ARM: STi: DT: Add sdhci pin configuration for stih415

2014-05-22 Thread Lee Jones 
> This patch adds the required pin config for the sdhci controller
> present in the stih415 SoC.
> 
> Signed-off-by: Peter Griffin 
> Signed-off-by: Giuseppe Cavallaro 

Switch these round - same with all the other patches.

> ---
>  arch/arm/boot/dts/stih415-pinctrl.dtsi | 21 +
>  arch/arm/boot/dts/stih415.dtsi | 12 
>  2 files changed, 33 insertions(+)

[...]

> diff --git a/arch/arm/boot/dts/stih415.dtsi b/arch/arm/boot/dts/stih415.dtsi
> index d6f254f..6579b1d 100644
> --- a/arch/arm/boot/dts/stih415.dtsi
> +++ b/arch/arm/boot/dts/stih415.dtsi
> @@ -218,5 +218,17 @@
>   resets  = <&powerdown STIH415_KEYSCAN_POWERDOWN>,
> <&softreset STIH415_KEYSCAN_SOFTRESET>;
>   };
> +
> + mmc0: sdhci@fe81e000 {
> + compatible = "st,sdhci";
> + status = "disabled";
> + reg = <0xfe81e000 0x1000>;
> + interrupts = ;
> + interrupt-names = "mmcirq";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_mmc0>;
> + clock-names = "mmc";
> + clocks = <&clk_s_a1_ls 1>;

Nit: These would be easier to read if the '='s were lined up (using tabs).

> + };
>   };
>  };

Apart from that:

  Acked-by: Lee Jones 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 5/8] ARM: STi: DT: Add sdhci pin configuration for stih415

2014-05-22 Thread Peter Griffin 
This patch adds the required pin config for the sdhci controller
present in the stih415 SoC.

Signed-off-by: Peter Griffin 
Signed-off-by: Giuseppe Cavallaro 
---
 arch/arm/boot/dts/stih415-pinctrl.dtsi | 21 +
 arch/arm/boot/dts/stih415.dtsi | 12 
 2 files changed, 33 insertions(+)

diff --git a/arch/arm/boot/dts/stih415-pinctrl.dtsi 
b/arch/arm/boot/dts/stih415-pinctrl.dtsi
index caeac7e..eee2373 100644
--- a/arch/arm/boot/dts/stih415-pinctrl.dtsi
+++ b/arch/arm/boot/dts/stih415-pinctrl.dtsi
@@ -429,6 +429,27 @@
};
};
};
+
+   mmc0 {
+   pinctrl_mmc0: mmc0 {
+   st,pins {
+   mmcclk = <&PIO13 4 ALT4 
BIDIR_PU NICLK 0 CLK_B>;
+   data0  = <&PIO14 4 ALT4 
BIDIR_PU BYPASS 0>;
+   data1  = <&PIO14 5 ALT4 
BIDIR_PU BYPASS 0>;
+   data2  = <&PIO14 6 ALT4 
BIDIR_PU BYPASS 0>;
+   data3  = <&PIO14 7 ALT4 
BIDIR_PU BYPASS 0>;
+   cmd= <&PIO15 1 ALT4 
BIDIR_PU BYPASS 0>;
+   wp = <&PIO15 3 ALT4 IN>;
+   data4  = <&PIO16 4 ALT4 
BIDIR_PU BYPASS 0>;
+   data5  = <&PIO16 5 ALT4 
BIDIR_PU BYPASS 0>;
+   data6  = <&PIO16 6 ALT4 
BIDIR_PU BYPASS 0>;
+   data7  = <&PIO16 7 ALT4 
BIDIR_PU BYPASS 0>;
+   pwr= <&PIO17 1 ALT4 OUT>;
+   cd = <&PIO17 2 ALT4 IN>;
+   led= <&PIO17 3 ALT4 OUT>;
+   };
+   };
+   };
};
 
pin-controller-left {
diff --git a/arch/arm/boot/dts/stih415.dtsi b/arch/arm/boot/dts/stih415.dtsi
index d6f254f..6579b1d 100644
--- a/arch/arm/boot/dts/stih415.dtsi
+++ b/arch/arm/boot/dts/stih415.dtsi
@@ -218,5 +218,17 @@
resets  = <&powerdown STIH415_KEYSCAN_POWERDOWN>,
  <&softreset STIH415_KEYSCAN_SOFTRESET>;
};
+
+   mmc0: sdhci@fe81e000 {
+   compatible = "st,sdhci";
+   status = "disabled";
+   reg = <0xfe81e000 0x1000>;
+   interrupts = ;
+   interrupt-names = "mmcirq";
+   pinctrl-names = "default";
+   pinctrl-0 = <&pinctrl_mmc0>;
+   clock-names = "mmc";
+   clocks = <&clk_s_a1_ls 1>;
+   };
};
 };
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/